Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964933AbWEUTsU (ORCPT ); Sun, 21 May 2006 15:48:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964931AbWEUTsU (ORCPT ); Sun, 21 May 2006 15:48:20 -0400 Received: from mx1.redhat.com ([66.187.233.31]:33925 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S964933AbWEUTsT (ORCPT ); Sun, 21 May 2006 15:48:19 -0400 Date: Sun, 21 May 2006 15:47:04 -0400 From: Dave Jones To: Adrian Bunk Cc: Ulrich Drepper , Chris Wedgwood , dragoran , linux-kernel@vger.kernel.org, ak@suse.de Subject: Re: IA32 syscall 311 not implemented on x86_64 Message-ID: <20060521194704.GJ8250@redhat.com> Mail-Followup-To: Dave Jones , Adrian Bunk , Ulrich Drepper , Chris Wedgwood , dragoran , linux-kernel@vger.kernel.org, ak@suse.de References: <44702650.30507@feuerpokemon.de> <20060521085015.GB2535@taniwha.stupidest.org> <20060521160332.GA8250@redhat.com> <20060521185000.GB8250@redhat.com> <20060521185610.GC8250@redhat.com> <20060521193818.GE3339@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060521193818.GE3339@stusta.de> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1691 Lines: 47 On Sun, May 21, 2006 at 09:38:18PM +0200, Adrian Bunk wrote: > On Sun, May 21, 2006 at 02:56:10PM -0400, Dave Jones wrote: > > > > Actually it is kinda throttled, but only on process name. > > This patch just removes that stuff completely. > > (Also removes a bunch of trailing whitespace) > > > > Signed-off-by: Dave Jones > > > > --- linux-2.6.16.noarch/arch/x86_64/ia32/sys_ia32.c~ 2006-05-21 14:50:57.000000000 -0400 > > +++ linux-2.6.16.noarch/arch/x86_64/ia32/sys_ia32.c 2006-05-21 14:51:48.000000000 -0400 > > @@ -522,17 +522,9 @@ sys32_waitpid(compat_pid_t pid, unsigned > > } > > > > int sys32_ni_syscall(int call) > > -{ > > - struct task_struct *me = current; > > - static char lastcomm[sizeof(me->comm)]; > > - > > - if (strncmp(lastcomm, me->comm, sizeof(lastcomm))) { > > - printk(KERN_INFO "IA32 syscall %d from %s not implemented\n", > > - call, me->comm); > > - strncpy(lastcomm, me->comm, sizeof(lastcomm)); > > - } > > - return -ENOSYS; > > -} > > +{ > > + return -ENOSYS; > > +} > >... > > Why can't we remove sys32_ni_syscall() and call sys_ni_syscall() > instead if all we want to do is to return -ENOSYS? We could, though it's a more invasive patch, which would probably sprinkle extra includes/externs over multiple files, for no practical gain over having this tiny function isolated to this file. Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/