Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 21 Aug 2020 17:21:42 +0900
From:   Hyesoo Yu <hyesoo.yu@samsung.com>
To:     Rob Herring <robh@kernel.org>
Cc:     pullip.cho@samsung.com, lmark@codeaurora.org,
        sumit.semwal@linaro.org, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, labbott@redhat.com,
        linaro-mm-sig@lists.linaro.org, akpm@linux-foundation.org,
        minchan@kernel.org, dri-devel@lists.freedesktop.org,
        linux-mm@kvack.org, joaodias@google.com, robh+dt@kernel.org,
        Brian.Starkey@arm.com, afd@ti.com, iamjoonsoo.kim@lge.com,
        christian.koenig@amd.com, john.stultz@linaro.org, vbabka@suse.cz,
        devicetree@vger.kernel.org, surenb@google.com,
        benjamin.gaignard@linaro.org
Subject: Re: [PATCH 3/3] dma-heap: Devicetree binding for chunk heap
Message-ID: <20200821082120.GA191570@KEI>
MIME-Version: 1.0
In-Reply-To: <20200818164812.GA3602349@bogus>
User-Agent: Mutt/1.5.24 (2015-08-30)
Content-Type: multipart/mixed;
        boundary="----lWUYs60uNheWdrlwd5Sxb-jVEnyT8vPvqGqUNsoxLEsY2Otg=_4fc00_"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <20200818080415.7531-1-hyesoo.yu@samsung.com>
        <CGME20200818074554epcas2p2702e648ba975ea6fbe33c84396b152a9@epcas2p2.samsung.com>
        <20200818080415.7531-4-hyesoo.yu@samsung.com>
        <20200818164812.GA3602349@bogus>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

------lWUYs60uNheWdrlwd5Sxb-jVEnyT8vPvqGqUNsoxLEsY2Otg=_4fc00_
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

Hi,

On Tue, Aug 18, 2020 at 10:48:12AM -0600, Rob Herring wrote:
> On Tue, 18 Aug 2020 17:04:15 +0900, Hyesoo Yu wrote:
> > Document devicetree binding for chunk heap on dma heap framework
> > 
> > Signed-off-by: Hyesoo Yu <hyesoo.yu@samsung.com>
> > ---
> >  .../devicetree/bindings/dma-buf/chunk_heap.yaml    | 46 ++++++++++++++++++++++
> >  1 file changed, 46 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/dma-buf/chunk_heap.yaml
> > 
> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma-buf/chunk_heap.example.dt.yaml: chunk_default_heap: 'alignment', 'memory-region' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> 
> See https://protect2.fireeye.com/v1/url?k=66da9090-3b1117ae-66db1bdf-0cc47a31309a-d3f5cc0866799e96&q=1&e=d42ef5a6-e7ba-494d-8f6b-faf451118f84&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpatch%2F1346687
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
> 
> pip3 install git+https://protect2.fireeye.com/v1/url?k=c99eded1-945559ef-c99f559e-0cc47a31309a-bcc831610d2ce1c6&q=1&e=d42ef5a6-e7ba-494d-8f6b-faf451118f84&u=https%3A%2F%2Fgithub.com%2Fdevicetree-org%2Fdt-schema.git%40master --upgrade
> 
> Please check and re-submit.
> 
> 

Thanks for reply. I missed alignment and memory-region on property.
I added and ran dt_binding_check, and all passed.

I will re-submit the patch v2.

Regards.
Hyesoo yu.

------lWUYs60uNheWdrlwd5Sxb-jVEnyT8vPvqGqUNsoxLEsY2Otg=_4fc00_
Content-Type: text/plain; charset="utf-8"


------lWUYs60uNheWdrlwd5Sxb-jVEnyT8vPvqGqUNsoxLEsY2Otg=_4fc00_--