Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp85483pxa; Fri, 21 Aug 2020 01:42:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3+9WWctDdRJSpZlvmdA0DmKqnurTo/2wIsZ4OqQRyDwSosOOxfbJkHFC9LD8aikrpw0jp X-Received: by 2002:a17:906:698:: with SMTP id u24mr1778977ejb.57.1597999378859; Fri, 21 Aug 2020 01:42:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597999378; cv=none; d=google.com; s=arc-20160816; b=JpnrxFzyyEMeV4IFP1q9oyCo9rdr0ld48sOP8TgBgrqRwUymxNc24gNZqofArwb/Nn pm5jPydTsd3E9DDW2WTOYcycomfxTtklp1UUJ66mA4QkGC3Kz/PZRVuUCzR1w91FkfWD 1Ss8mSLOE44tGvDCFIG4K2g3/5Djou2LjqHodetdx+YvHPQ/DglRzu2WU1UgVuVrMhPV Jfv+d4FsDv2jxWpu53MVrwAWbbEPvi1JLgQawxcqfZNi0a3PrE9k/zXIuO0VfaumFFOQ Ecij33sR3Tpd8U0wyrnSEOh0IrpjwmSOE7r4IaI9WT5MOx4soUhydqU94Zyw0vrihLXV hIbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :ironport-sdr:ironport-sdr; bh=0A48cZhqWXLU8pF4gww97H4pzSMfdL1WJIb9lx6lubY=; b=Fwqk0yerLbjbK0LhIZ3AXsF8xmVt9Ehlg0ainCdRKp1+xnj6+36cKG/tC2QMVBnt9I /0v4MYah69+hTmj/Llg4wRMxQzY8uXk33Cq9GY7HoXwVruXCrIfgB8Tc+18IcXjFbWQ2 QD31XqFnYsNgrc0hTd0MgGk/yK4t7DQgsBUI9f1uvpO6oPeN6mTw+MuOTUkBIN56l5cr fuCn16FRilesXbayxL9WFKOc+GcozywF1LfZ0WIkthyqU6a/QZzoOTr2E3nHJ6oEg7jU VEkayf4JRucb4HFNkdqSzCATdjrapUYf1EsGZ9PSzL9x+DAFr3NPNfePlVDkM30kbYG+ fVIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g1si780124edy.259.2020.08.21.01.42.34; Fri, 21 Aug 2020 01:42:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728008AbgHUIlT (ORCPT + 99 others); Fri, 21 Aug 2020 04:41:19 -0400 Received: from mga12.intel.com ([192.55.52.136]:16703 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726243AbgHUIlP (ORCPT ); Fri, 21 Aug 2020 04:41:15 -0400 IronPort-SDR: 9gWNK2wQmWGx4Pf78A6tZQffAQe+XBDZ9Y/TDBUxT4JsMHWdScsRL+UigdGT3zHEbEAdYN0HOH uODWQW3N8zmQ== X-IronPort-AV: E=McAfee;i="6000,8403,9719"; a="135024940" X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="135024940" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 01:41:14 -0700 IronPort-SDR: wU6wB33vOuYQk4bmvf0tN6XTxL0Kijnb7VWExrEYbjA3kFzXNZCtjsMJ0hgtAGTs/di5LEk6bT VW6DgVR9dbUg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="329972949" Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.170]) ([10.237.72.170]) by fmsmga002.fm.intel.com with ESMTP; 21 Aug 2020 01:41:12 -0700 Subject: Re: [PATCH] xhci: Always restore EP_SOFT_CLEAR_TOGGLE even if ep reset failed To: Greg KH , Ding Hui Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200821070652.27782-1-dinghui@sangfor.com.cn> <20200821073147.GA1681156@kroah.com> From: Mathias Nyman Openpgp: preference=signencrypt Autocrypt: addr=mathias.nyman@linux.intel.com; prefer-encrypt=mutual; keydata= mQINBFMB0ccBEADd+nZnZrFDsIjQtclVz6OsqFOQ6k0nQdveiDNeBuwyFYykkBpaGekoHZ6f lH4ogPZzQ+pzoJEMlRGXc881BIggKMCMH86fYJGfZKWdfpg9O6mqSxyEuvBHKe9eZCBKPvoC L2iwygtO8TcXXSCynvXSeZrOwqAlwnxWNRm4J2ikDck5S5R+Qie0ZLJIfaId1hELofWfuhy+ tOK0plFR0HgVVp8O7zWYT2ewNcgAzQrRbzidA3LNRfkL7jrzyAxDapuejuK8TMrFQT/wW53e uegnXcRJaibJD84RUJt+mJrn5BvZ0MYfyDSc1yHVO+aZcpNr+71yZBQVgVEI/AuEQ0+p9wpt O9Wt4zO2KT/R5lq2lSz1MYMJrtfFRKkqC6PsDSB4lGSgl91XbibK5poxrIouVO2g9Jabg04T MIPpVUlPme3mkYHLZUsboemRQp5/pxV4HTFR0xNBCmsidBICHOYAepCzNmfLhfo1EW2Uf+t4 L8IowAaoURKdgcR2ydUXjhACVEA/Ldtp3ftF4hTQ46Qhba/p4MUFtDAQ5yeA5vQVuspiwsqB BoL/298+V119JzM998d70Z1clqTc8fiGMXyVnFv92QKShDKyXpiisQn2rrJVWeXEIVoldh6+ J8M3vTwzetnvIKpoQdSFJ2qxOdQ8iYRtz36WYl7hhT3/hwkHuQARAQABtCdNYXRoaWFzIE55 bWFuIDxtYXRoaWFzLm55bWFuQGdtYWlsLmNvbT6JAjsEEwECACUCGwMGCwkIBwMCBhUIAgkK CwQWAgMBAh4BAheABQJTAeo1AhkBAAoJEFiDn/uYk8VJOdIP/jhA+RpIZ7rdUHFIYkHEKzHw tkwrJczGA5TyLgQaI8YTCTPSvdNHU9Rj19mkjhUO/9MKvwfoT2RFYqhkrtk0K92STDaBNXTL JIi4IHBqjXOyJ/dPADU0xiRVtCHWkBgjEgR7Wihr7McSdVpgupsaXhbZjXXgtR/N7PE0Wltz hAL2GAnMuIeJyXhIdIMLb+uyoydPCzKdH6znfu6Ox76XfGWBCqLBbvqPXvk4oH03jcdt+8UG 2nfSeti/To9ANRZIlSKGjddCGMa3xzjtTx9ryf1Xr0MnY5PeyNLexpgHp93sc1BKxKKtYaT0 lR6p0QEKeaZ70623oB7Sa2Ts4IytqUVxkQKRkJVWeQiPJ/dZYTK5uo15GaVwufuF8VTwnMkC 4l5X+NUYNAH1U1bpRtlT40aoLEUhWKAyVdowxW4yGCP3nL5E69tZQQgsag+OnxBa6f88j63u wxmOJGNXcwCerkCb+wUPwJzChSifFYmuV5l89LKHgSbv0WHSN9OLkuhJO+I9fsCNvro1Y7dT U/yq4aSVzjaqPT3yrnQkzVDxrYT54FLWO1ssFKAOlcfeWzqrT9QNcHIzHMQYf5c03Kyq3yMI Xi91hkw2uc/GuA2CZ8dUD3BZhUT1dm0igE9NViE1M7F5lHQONEr7MOCg1hcrkngY62V6vh0f RcDeV0ISwlZWuQINBFMB0ccBEACXKmWvojkaG+kh/yipMmqZTrCozsLeGitxJzo5hq9ev31N 2XpPGx4AGhpccbco63SygpVN2bOd0W62fJJoxGohtf/g0uVtRSuK43OTstoBPqyY/35+VnAV oA5cnfvtdx5kQPIL6LRcxmYKgN4/3+A7ejIxbOrjWFmbWCC+SgX6mzHHBrV0OMki8R+NnrNa NkUmMmosi7jBSKdoi9VqDqgQTJF/GftvmaZHqgmVJDWNrCv7UiorhesfIWPt1O/AIk9luxlE dHwkx5zkWa9CGYvV6LfP9BznendEoO3qYZ9IcUlW727Le80Q1oh69QnHoI8pODDBBTJvEq1h bOWcPm/DsNmDD8Rwr/msRmRyIoxjasFi5WkM/K/pzujICKeUcNGNsDsEDJC5TCmRO/TlvCvm 0X+vdfEJRZV6Z+QFBflK1asUz9QHFre5csG8MyVZkwTR9yUiKi3KiqQdaEu+LuDD2CGF5t68 xEl66Y6mwfyiISkkm3ETA4E8rVZP1rZQBBm83c5kJEDvs0A4zrhKIPTcI1smK+TWbyVyrZ/a mGYDrZzpF2N8DfuNSqOQkLHIOL3vuOyx3HPzS05lY3p+IIVmnPOEdZhMsNDIGmVorFyRWa4K uYjBP/W3E5p9e6TvDSDzqhLoY1RHfAIadM3I8kEx5wqco67VIgbIHHB9DbRcxQARAQABiQIf BBgBAgAJBQJTAdHHAhsMAAoJEFiDn/uYk8VJb7AQAK56tgX8V1Wa6RmZDmZ8dmBC7W8nsMRz PcKWiDSMIvTJT5bygMy1lf7gbHXm7fqezRtSfXAXr/OJqSA8LB2LWfThLyuuCvrdNsQNrI+3 D+hjHJjhW/4185y3EdmwwHcelixPg0X9EF+lHCltV/w29Pv3PiGDkoKxJrnOpnU6jrwiBebz eAYBfpSEvrCm4CR4hf+T6MdCs64UzZnNt0nxL8mLCCAGmq1iks9M4bZk+LG36QjCKGh8PDXz 9OsnJmCggptClgjTa7pO6040OW76pcVrP2rZrkjo/Ld/gvSc7yMO/m9sIYxLIsR2NDxMNpmE q/H7WO+2bRG0vMmsndxpEYS4WnuhKutoTA/goBEhtHu1fg5KC+WYXp9wZyTfeNPrL0L8F3N1 BCEYefp2JSZ/a355X6r2ROGSRgIIeYjAiSMgGAZMPEVsdvKsYw6BH17hDRzltNyIj5S0dIhb Gjynb3sXforM/GVbr4mnuxTdLXQYlj2EJ4O4f0tkLlADT7podzKSlSuZsLi2D+ohKxtP3U/r 42i8PBnX2oAV0UIkYk7Oel/3hr0+BP666SnTls9RJuoXc7R5XQVsomqXID6GmjwFQR5Wh/RE IJtkiDAsk37cfZ9d1kZ2gCQryTV9lmflSOB6AFZkOLuEVSC5qW8M/s6IGDfYXN12YJaZPptJ fiD/ Message-ID: Date: Fri, 21 Aug 2020 11:44:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200821073147.GA1681156@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.8.2020 10.31, Greg KH wrote: > On Fri, Aug 21, 2020 at 03:06:52PM +0800, Ding Hui wrote: >> Some devices driver call libusb_clear_halt when target ep queue >> is not empty. (eg. spice client connected to qemu for usb redir) >> >> Before commit f5249461b504 ("xhci: Clear the host side toggle >> manually when endpoint is soft reset"), that works well. >> But now, we got the error log: >> >> EP not empty, refuse reset >> >> xhch_endpoint_reset failed and left ep_state's EP_SOFT_CLEAR_TOGGLE >> bit is still on >> >> So all the subsequent urb sumbit to the ep will fail with the >> warn log: >> >> Can't enqueue URB while manually clearing toggle >> >> We need restore ep_state EP_SOFT_CLEAR_TOGGLE bit after >> xhci_endpoint_reset, even if it is failed. >> >> Signed-off-by: Ding Hui Thanks, nice catch. >> --- >> drivers/usb/host/xhci.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > Shouldn't this have a Fixes: tag on it and be backported to the affected > stable trees? It should, but I like this patch and want it in, so I'll add the tags this time. Thanks -Mathias