Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp101449pxa; Fri, 21 Aug 2020 02:16:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+nYSMb9BCfw8ZeNfDHk4Z2WrulXCizfDOVwci79zILYi7/5TGt+wwIjOWYTpUzS4To6H/ X-Received: by 2002:a17:906:c310:: with SMTP id s16mr2005482ejz.466.1598001363602; Fri, 21 Aug 2020 02:16:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598001363; cv=none; d=google.com; s=arc-20160816; b=qYclIS0wCgFTRDqzJy4eVd0FJ1NjH6zh6tILbuC97HNus5TWk+FLmaVx8vZ8cFKFa2 mw3G0xO7ryP0QjBt83PF08CmzpZIJTuJSEQX3FU96yqTVV4ngnTM3QBfp7c9/9r0T1lx bXjRtShct6J6ODVIHt3RT0wsa5j3Fg3AHBj8MDFSkR2CQR6BmO/ucA1/F5YirZcDNe8r gRSkNkvM2RC3AMIao/Es+YxcbowvYgpbOr1Wfe+x1SF26FVbv07QHUgJcA6M5sLwGYB5 cKQZO6knj3oVKTt50qA8aWdSf30tJZd6FhxHxvZkzOQaTA4r7+r2nmKvqHFiUU4oEtuE jD2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=WI6Dd91SuYv9fYQDwwQZdQZ72f3EjQl6Ld1ksdP0Q78=; b=P4K91j67M1/sKf3Xn9DNF7+JM4OxQagPqwkKlL/QpdsLi/L8GLc9++J4BS+cxGxjC3 erUflfduLlnq3ZpT64PccR3dcxaapNJCeUbODBM03fmeIdlGWdyvIMBwEp6VJVkir8y3 ltRglsnb9cEqimLFVf+bcETTqpWFaVOaMmuWVsa5pJVIwItUlCK2k8VVnfVGIqz/oYFv +UZTSwRMPE1SFkgguPuggylgvF8bXRO3zyyp3Pb0h2lqiN/fLZEcGuhLIetn6RKmUgLv +qvB/jHUuMPRHOqy5tQ5yTVMGBOUb4VvyNJWj1HbpOC0ot7sYT0BMRu8mxbbT6EdME/i xSow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oz19si922750ejb.307.2020.08.21.02.15.40; Fri, 21 Aug 2020 02:16:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728307AbgHUJOg (ORCPT + 99 others); Fri, 21 Aug 2020 05:14:36 -0400 Received: from mga14.intel.com ([192.55.52.115]:48118 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725855AbgHUJOf (ORCPT ); Fri, 21 Aug 2020 05:14:35 -0400 IronPort-SDR: 2bns/17trGbkQnY4S7+BxZdgY8gYPsXzpbOvpomQpnkAR+z5t0oI4mOwtL4CBR4Xt8dYydJqbQ rxOaP6PSRWvg== X-IronPort-AV: E=McAfee;i="6000,8403,9719"; a="154763282" X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="154763282" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 02:14:34 -0700 IronPort-SDR: Bkh9B8RFZMBPfu5d+mES5xY/5CkXNFpuBirBk/Y5TY8vuOOQ78Brr5064ufoZuL6MOD7aUnrpv HwUbzpdy7gdQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="321195575" Received: from linux.intel.com ([10.54.29.200]) by fmsmga004.fm.intel.com with ESMTP; 21 Aug 2020 02:14:35 -0700 Received: from [10.214.149.100] (rtanwar-MOBL.gar.corp.intel.com [10.214.149.100]) by linux.intel.com (Postfix) with ESMTP id 9FFA458045A; Fri, 21 Aug 2020 02:14:30 -0700 (PDT) Subject: Re: [PATCH v8 2/2] Add PWM fan controller driver for LGM SoC To: Andy Shevchenko Cc: u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org, lee.jones@linaro.org, thierry.reding@gmail.com, p.zabel@pengutronix.de, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, songjun.Wu@intel.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com, rahul.tanwar.linux@gmail.com, rtanwar@maxlinear.com References: <20200820105255.GB1891694@smile.fi.intel.com> From: "Tanwar, Rahul" Message-ID: <56c2a40d-6872-8ae7-7214-420b8bb9f027@linux.intel.com> Date: Fri, 21 Aug 2020 17:14:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200820105255.GB1891694@smile.fi.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/8/2020 6:52 pm, Andy Shevchenko wrote: > On Thu, Aug 20, 2020 at 12:50:46PM +0800, Rahul Tanwar wrote: >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. >> This PWM controller does not have any other consumer, it is a >> dedicated PWM controller for fan attached to the system. Add >> driver for this PWM fan controller. > ... > +#include > +#include > +#include >> +#include > This should be mod_devicetable.h. Inlcuding mod_devicetable.h instead of of_device.h results in build failure related to all platform calls. Build is ok if i remove it. Just FYI.. Regards, Rahul