Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp110647pxa; Fri, 21 Aug 2020 02:34:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwO/8OFOG4/v63ljltWPjBXqwWpvGlfq6SNK7gBOTdZiW3+cjRMetSCsn+JvSU2G5b6KawN X-Received: by 2002:a17:906:ca4d:: with SMTP id jx13mr1979555ejb.548.1598002489810; Fri, 21 Aug 2020 02:34:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598002489; cv=none; d=google.com; s=arc-20160816; b=yfLjf52caSH+5CuB1BIFJrW1HvccSvVOgKeO9DqevcF2ydRCoKoZ4t3ktYoywdtZjD GYevgC0BrMQwxXT8q1Vymt2SMKUbLx+0XTSz5D9CM4ZRZz6RfIo4nanuSjdLvUzAZ4PZ 6CQK3Ol1IRHxO9eM71euS3NPzWHr+3kmcWfwDfKbnmeY7f99XgyDQZ3oxlDFNvr4ZeqJ 8OHJjgN0eB8jU2TEak3mWcN9oytgHZXW7LhsdrEfxDPR2IOu6jUzJyi4jkGcBtxWmuT2 0FoqtsfPjx4FqHZc4+L4yVx9yr0liW1+htzARqwoZmSCWjvIC8YXdcAktcJ4g1356TIU AhFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=AiIPUDE+H7YA00VsJuQ9Q/LiNv7edfp2yCNXyzwfy4Q=; b=H0zwyNXm7TQWo7ojVrM4YgYBRRYnrFVKwYSiUfQCERtJFQ1oz18QlxnoYDHxYU082q 0U46zomFR13A6HxUnT1hxHuX7/IpCtMimCx7oyLY/xw3c0vXlQl7+bSMqvQRb0NdqJcx +2iADKteOe1l2Jx/9EFTq7/gNj35qFsnt4UfFs5Ai6rivU+37dhqINaFCDChe1G/R44U 4GxkMtYJYPaDiPATqMFq26O3KQY2636u//+xBv+/e9eXmaprlXZdHhu82aVcx/XW5OKS 0lkFD8u0gcmFwnJGtAhh7+dAm1ROKSMXX98z2B2J3Z15cWwtlje44FyWjtH80XvVGAHH Lrpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rh17si760462ejb.256.2020.08.21.02.34.25; Fri, 21 Aug 2020 02:34:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727903AbgHUJcW (ORCPT + 99 others); Fri, 21 Aug 2020 05:32:22 -0400 Received: from mga02.intel.com ([134.134.136.20]:7297 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727006AbgHUJcT (ORCPT ); Fri, 21 Aug 2020 05:32:19 -0400 IronPort-SDR: fgRQID+h9pfvbwTsHWnvMnunWunmjszIdXpPgNK5Z9TdICbzim7SS3wSJdjnmBAZtOeZ14A95k RZbVymq/XAsw== X-IronPort-AV: E=McAfee;i="6000,8403,9719"; a="143288990" X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="143288990" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 02:32:18 -0700 IronPort-SDR: hvmJUp9IKl+Oil+/Rvte3tIZsqcosPkwVZiubcF0qfk5y9MsFabQxcgpNbw1RalMOxcBKFHASP WAHeoYDVkVNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="321202090" Received: from sgsxdev001.isng.intel.com (HELO localhost) ([10.226.88.11]) by fmsmga004.fm.intel.com with ESMTP; 21 Aug 2020 02:32:14 -0700 From: Rahul Tanwar To: u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org, lee.jones@linaro.org Cc: thierry.reding@gmail.com, p.zabel@pengutronix.de, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, andriy.shevchenko@intel.com, songjun.Wu@intel.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com, rahul.tanwar.linux@gmail.com, rtanwar@maxlinear.com, Rahul Tanwar Subject: [PATCH v9 0/2] pwm: intel: Add PWM driver for a new SoC Date: Fri, 21 Aug 2020 17:32:09 +0800 Message-Id: X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Patch 1 adds dt binding document in YAML format. Patch 2 add PWM fan controller driver for LGM SoC. v9: - Address code quality related review concerns (Andy Shevchenko) - Use devm_add_action_or_reset() instead of explicit unwind calls. v8: - Remove fan related optional properties usage, keep them as default. If needed, change pwm-fan driver separately in future to add them as generic properties. v7: - Address code quality related review concerns. - Rename fan related property to pwm-*. - Fix one make dt_binding_check reported error. v6: - Readjust .apply op as per review feedback. - Add back pwm-cells property to resolve make dt_binding_check error. pwm-cells is a required property for PWM driver. - Add back fan related optional properties. v5: - Address below review concerns from Uwe Kleine-K?nig. * Improve comments about Limitations. * Use return value of regmap_update_bits if container function returns error code. * Modify .apply op to have strict checking for fixed period supported by PWM HW. * Use u64 as type when use min_t for duty_cycle. * Add reset_control_assert() in failure case in probe where it was missing earlier. - Remove fan specific optional properties from pwm dt binding document (Rob Herring) v4: - Address below review concerns from Uwe Kleine-K?nig. * Improve notes and limitations comments. * Add common prefixes for all #defines. * Modify/Improve logic in .apply & .get_state ops as advised. * Skip error messages in probe when error is -EPROBE_DEFER. * Add dependencies in Kconfig (OF & HAS_IOMEM) and add select REGMAP_MMIO. * Address other code quality related review concerns. - Fix make dt_binding_check reported error in YAML file. v3: - Address below review concerns from Uwe Kleine-K?nig. * Remove fan rpm calibration task from the driver. * Modify apply op as per the review feedback. * Add roundup & round down where necessary. * Address other misc code quality related review concerns. * Use devm_reset_control_get_exclusive(). (Philipp Zabel) * Improve dt binding document. v2: - Address below review concerns from Uwe Kleine-K?nig. * Add notes and limitations about PWM HW. * Rename all functions and structure to lgm_pwm_* * Readjust space aligninment in structure fields to single space. * Switch to using apply instead of config/enable/disable. * Address other code quality related concerns. * Rebase to 5.8-rc1. - Address review concerns in dt binding YAML from Rob Herring. v1: - Initial version. Rahul Tanwar (2): Add DT bindings YAML schema for PWM fan controller of LGM SoC Add PWM fan controller driver for LGM SoC .../devicetree/bindings/pwm/intel,lgm-pwm.yaml | 44 ++++ drivers/pwm/Kconfig | 11 + drivers/pwm/Makefile | 1 + drivers/pwm/pwm-intel-lgm.c | 241 +++++++++++++++++++++ 4 files changed, 297 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml create mode 100644 drivers/pwm/pwm-intel-lgm.c -- 2.11.0