Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200814111221.5813-1-jorge@foundries.io> <20200821062121.GA1020247@jade>
 <20200821063657.GA20356@trex>
In-Reply-To: <20200821063657.GA20356@trex>
From:   Jens Wiklander <jens.wiklander@linaro.org>
Date:   Fri, 21 Aug 2020 12:04:22 +0200
Message-ID: <CAHUa44GCpVFGf0U=N0XghiZJWiNBHOrYW4P_JMp3uyoz_7PWzg@mail.gmail.com>
Subject: Re: [PATCHv9] drivers: optee: allow op-tee to access devices on the
 i2c bus
To:     "Jorge Ramirez-Ortiz, Foundries" <jorge@foundries.io>
Cc:     Sumit Garg <sumit.garg@linaro.org>, ricardo@foundries.io,
        Michael Scott <mike@foundries.io>,
        "tee-dev @ lists . linaro . org" <tee-dev@lists.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Aug 21, 2020 at 8:37 AM Jorge Ramirez-Ortiz, Foundries
<jorge@foundries.io> wrote:
>
> On 21/08/20, Jens Wiklander wrote:
> > On Fri, Aug 14, 2020 at 01:12:21PM +0200, Jorge Ramirez-Ortiz wrote:
> > > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to
> > > control this type of cryptographic devices it needs coordinated access
> > > to the bus, so collisions and RUNTIME_PM dont get in the way.
> > >
> > > This trampoline driver allow OP-TEE to access them.
> > >
> > > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> > > ---
> > > v9: params return value must be written before optee_msg_to_param is called
> > > v8: review fixes:
> > >     fix types and add TEEC_ERROR_NOT_SUPPORTED to GP errors
> > > v7: add support for ten bit i2c slave addressing
> > > v6: compile out if CONFIG_I2C not enabled
> > > v5: alphabetic order of includes
> > > v4: remove unnecessary extra line in optee_msg.h
> > > v3: use from/to msg param to support all types of memory
> > >     modify OPTEE_MSG_RPC_CMD_I2C_TRANSFER message id
> > >
> > >  drivers/tee/optee/optee_msg.h     | 21 +++++++
> > >  drivers/tee/optee/optee_private.h |  1 +
> > >  drivers/tee/optee/rpc.c           | 95 +++++++++++++++++++++++++++++++
> > >  3 files changed, 117 insertions(+)
> >
> > Looks good. Did you test this with the recently merged
> > https://github.com/OP-TEE/optee_os/pull/4033 ?
> >
>
> yes, I did retest and it is good.

Good. I'm picking this up.

Thanks,
Jens