Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp197080pxa; Fri, 21 Aug 2020 05:07:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfIBrJ6sCH+VUVsiBKhmnFhaGNBZPakDY7JHsWG2pb/4NUciB0yOnBQKWZpW4zSW7yJnhm X-Received: by 2002:a17:906:a053:: with SMTP id bg19mr2657681ejb.444.1598011628619; Fri, 21 Aug 2020 05:07:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598011628; cv=none; d=google.com; s=arc-20160816; b=MJOhyHUvPi5NlX3LooAgfnLmfVb9lPS6WCfQ/CIkL3ZP2bfKuc6gvpRzkTlZgngGyz OATA8GCsLX6u88gUYjs6JPpCibkRQYnwcgQTjjmWV3m//pJ+D9gfAdJI7lqYoPp4OD0c uMpnZ28W/LT17So/aBWHKzrxHreFRDVhw4p2qoHfSNmuY9Z+P+bARF88VoV+IFfaEC3R mKiLwHPiuAVS0hP46AEndO+1odmpxOO9O+PGSUjXMKSxAgmMvYh5l/tcZRNE8vQEXMKg BgcVI0Zbi5EeSrWSb1diRj4Ao8GBeYnsl2+3zETSbprQJlU+fqMBz+c7Tvsp73qfUzGU bwhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=QtKGfR+1iR3kEPsEfjDAOfFZGutCuRuneaQE3YwB9Lg=; b=vaIiInWUN+yDo+OthXkCTJSHlf4qXIh4iKYSZ+doQU1SFdWkBHpRMhkaAqUjjs4pz3 6iopp9B1m/gzexrkbizR3bnRIkWwsYFIxVsDWtPk2DLn9QR+DAPH0k3TdX0d1yDkPB8f RuXMtolqkvtV9gvhS36tzwcmPuE0SrBadcMlyhzF9B7tqk1bR5dLbe87OBDJPX/jf2+P CT1Vi9o0DWX1FtMR7S0Ijy39zV7Z/k4Y0E869T16zv8TyH8KNqQSy3dTopTPwHYC/RFr VBGkOw2AilR4JqQzdKTzT7ya7aFEkwrWZvS0tVkEckVzteZKVS/wpj49TRveKlxJrxQZ 0qtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OGx1XxSc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bc16si1050410edb.161.2020.08.21.05.06.44; Fri, 21 Aug 2020 05:07:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OGx1XxSc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727087AbgHUMFd (ORCPT + 99 others); Fri, 21 Aug 2020 08:05:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:37003 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725935AbgHUMF1 (ORCPT ); Fri, 21 Aug 2020 08:05:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598011525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QtKGfR+1iR3kEPsEfjDAOfFZGutCuRuneaQE3YwB9Lg=; b=OGx1XxScDqNqx0DyLVsiMUTHwAfWbI2wH19FA03ABwJEZEpGKvLs51V5XzXN4Vyy3fr7i1 4q18ufGNjoq6q+gtCgNYSoFbibHG0aQtHG+HGflngXOxhPaLVeckLqguGuv+bWzdQGm2Jl fDpr9Jek8I4OwLbizGq3Pfz4WUfwpoY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-550-2ptqIlFQPKaVrVvN1P1Tbw-1; Fri, 21 Aug 2020 08:05:21 -0400 X-MC-Unique: 2ptqIlFQPKaVrVvN1P1Tbw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0AF017A162; Fri, 21 Aug 2020 12:05:19 +0000 (UTC) Received: from gondolin (ovpn-113-4.ams2.redhat.com [10.36.113.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0614D5D9CC; Fri, 21 Aug 2020 12:05:12 +0000 (UTC) Date: Fri, 21 Aug 2020 14:05:10 +0200 From: Cornelia Huck To: Pierre Morel Cc: linux-kernel@vger.kernel.org, pasic@linux.ibm.com, borntraeger@de.ibm.com, frankja@linux.ibm.com, mst@redhat.com, jasowang@redhat.com, kvm@vger.kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org, thomas.lendacky@amd.com, david@gibson.dropbear.id.au, linuxram@us.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com Subject: Re: [PATCH v9 2/2] s390: virtio: PV needs VIRTIO I/O device protection Message-ID: <20200821140510.3849410c.cohuck@redhat.com> In-Reply-To: <1597854198-2871-3-git-send-email-pmorel@linux.ibm.com> References: <1597854198-2871-1-git-send-email-pmorel@linux.ibm.com> <1597854198-2871-3-git-send-email-pmorel@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Aug 2020 18:23:18 +0200 Pierre Morel wrote: > If protected virtualization is active on s390, VIRTIO has retricted s/retricted/only restricted/ > access to the guest memory. > Define CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS and export > arch_has_restricted_virtio_memory_access to advertize VIRTIO if that's > the case, preventing a host error on access attempt. > > Signed-off-by: Pierre Morel > --- > arch/s390/Kconfig | 1 + > arch/s390/mm/init.c | 11 +++++++++++ > 2 files changed, 12 insertions(+) (...) > diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c > index 6dc7c3b60ef6..8febd73ed6ca 100644 > --- a/arch/s390/mm/init.c > +++ b/arch/s390/mm/init.c > @@ -45,6 +45,7 @@ > #include > #include > #include > +#include I don't think you need this include anymore. > > pgd_t swapper_pg_dir[PTRS_PER_PGD] __section(.bss..swapper_pg_dir); > (...) With the nit fixed, Reviewed-by: Cornelia Huck