Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp221486pxa; Fri, 21 Aug 2020 05:45:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMprtPbuGuPZQLo1qU8AZSmNrb/qnB75JwGKEXlw9tPTzT/hWtrWg927iEGp0yZBSjsxAu X-Received: by 2002:a17:906:d9db:: with SMTP id qk27mr2590857ejb.230.1598013914820; Fri, 21 Aug 2020 05:45:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598013914; cv=none; d=google.com; s=arc-20160816; b=fLtnS8d/N7tXqmMW84HgR57VgEQQxeKUXPloFhAqtDT/hqkwWFCWpSE6Li9eUCjHwd VDXBiOAPPYY8tlPl1dXNZx5r+qMKn6k3w8r4HrqxXp+SetexlB0s6iEaPh8ySOiMISxP ezriXWlE12mE0SLI7InjkVVam92PsiSMdP0IlofFbJds0BlVZQwllNj3M2ln0JvOODt5 eX2nXBat9bJ9Rcc7zYj4IOfO+PDqrGdLOSyEe5xb99I9oHp443zsDuvrfF4jAHH/J4Lk 5uGG3jXg65aW8Zl9Lbd0rSAK2iHf/69OQJEliajyyBWr8F1J6wvEilkjwhXrmS6U+7mo hiHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=vQ8YtZUq2JY+BH1jqqQCLSvh1WL0FVc7UY1mYQp2AQM=; b=TvOP8LVKgDVfKSen3UqJ4zAZrhbSX9RC1m9Hc1cVR3Wd8GT4RZ9qt3u+qTjF0opWIv fPH/XtNbR2p5gXlUuGklG/uZ+OWswvDo/HUEnQsilZA5GXmgDqAWxWj8+OKTATeZo3e4 oY8A88sQ+9bdY8dTwtnybwShyT+opGalV9b7DT+RKPQDke951YIgLXVzkthQwL40cV8a 8D0Krhmc+g/PX9AV8ubflfPM3mHVPNzpnz4ECZWtnmdyh2BLpRTzkc25EHo4t2PcTo53 Xxd5E4SgU11a+IuW92yYoQq+FoP3KpkmyhHAyQfJxbAA1/Qhz9ZczUUU8p+2xMLbar4T KAng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=Ehr1XCOB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t3si1231397edi.461.2020.08.21.05.44.50; Fri, 21 Aug 2020 05:45:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=Ehr1XCOB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728680AbgHUMlZ (ORCPT + 99 others); Fri, 21 Aug 2020 08:41:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728622AbgHUMlX (ORCPT ); Fri, 21 Aug 2020 08:41:23 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4FDDC061385 for ; Fri, 21 Aug 2020 05:41:22 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id h19so1653146ljg.13 for ; Fri, 21 Aug 2020 05:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vQ8YtZUq2JY+BH1jqqQCLSvh1WL0FVc7UY1mYQp2AQM=; b=Ehr1XCOBzdD5uog8ufwc8p/ZeibsGALJ/DPSRGA30L6oGq3HsS0KFwdyYUsug7ybHg uQac9t59HdWh/sctxLtx59MZmp9zKkXTcoNFgYd3aDVl9zN5KUBN1oZjufXKLn1TDuXt Wtw75wC4NFAvIaPTbdwVKS/HWohfj3La+pWL0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vQ8YtZUq2JY+BH1jqqQCLSvh1WL0FVc7UY1mYQp2AQM=; b=Mtb20piS/UYeOZmQxnuNOBxYp+rCpPBcfSvYmivdpGeBUe4n64ut3GNupfXwxubTj5 Mkdef/VbLxDKsKSjusfqIXYD5mKsYTw2Td3AXrvx1GZ7gAjHNg1PK36SLP5tg4Zrp5de edAFHlTN7j779+FyZMr8eDGut66XBTejFgIILhrF3iaMGxPaO2nrRsinkoinxmDjE/Ql 1UnBGoj/NMyKJ7hush34Hz5gMTcfbAwC5DgGX5Aeml6WfUuPB/4JQGwqj6og9ojaajqR nBx5f4BsjEbUOs87aRTLGP7YO+izUcbAu746b6wwP7Z0T04t0l0yMGFFI71au4WXybIb P1eg== X-Gm-Message-State: AOAM533ZYJCzihN8GmauIJcfy5wUjjS02F4451M6F5LluhP9EXR/Zzuq 4wce85qHbhm1wGr5NgE3OiF7q3sJ0nRBMg== X-Received: by 2002:a2e:b6cc:: with SMTP id m12mr1315840ljo.256.1598013680721; Fri, 21 Aug 2020 05:41:20 -0700 (PDT) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com. [209.85.167.50]) by smtp.gmail.com with ESMTPSA id a2sm375612ljj.40.2020.08.21.05.41.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Aug 2020 05:41:19 -0700 (PDT) Received: by mail-lf1-f50.google.com with SMTP id b30so833950lfj.12 for ; Fri, 21 Aug 2020 05:41:19 -0700 (PDT) X-Received: by 2002:a19:408d:: with SMTP id n135mr1384989lfa.192.1598013678967; Fri, 21 Aug 2020 05:41:18 -0700 (PDT) MIME-Version: 1.0 References: <20200821085011.28878-1-chris@chris-wilson.co.uk> <20200821085011.28878-2-chris@chris-wilson.co.uk> In-Reply-To: <20200821085011.28878-2-chris@chris-wilson.co.uk> From: Linus Torvalds Date: Fri, 21 Aug 2020 05:41:03 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/4] drm/i915/gem: Sync the vmap PTEs upon construction To: Chris Wilson Cc: Linux Kernel Mailing List , intel-gfx , Linux-MM , Pavel Machek , Andrew Morton , Joerg Roedel , Dave Airlie , Joonas Lahtinen , Rodrigo Vivi , stable Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 21, 2020 at 1:50 AM Chris Wilson wrote: > > Since synchronising the PTE after assignment is a manual step, use the > newly exported interface to flush the PTE after assigning via > alloc_vm_area(). This commit message doesn't make much sense to me. Are you talking about synchronizing the page directory structure across processes after possibly creating new kernel page tables? Because that has nothing to do with the PTE. It's all about making sure the _upper_ layers of the page directories are populated everywhere.. The name seems off to me too - what are you "flushing"? (And yes, I know about the flush_cache_vmap(), but that looks just bogus, since any non-mapped area shouldn't have any virtual caches to begin with, so I suspect that is just the crazy architectures being confused - flush_cache_vmap() is a no-op on any sane architecture - and powerpc that mis-uses it for other things). Linus