Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 7+ybf7RvHrGvlHmSGwLCggg9nJPuGU4Qf+XIO9Jw9ywRNA0PxBZzGQCYSW9jeB8BvwTTrx9gus
 5hqoGgyukG1w==
IronPort-SDR: NEotgQyb9Crw2rd72xxsF4uRflRDdb1aOpg5Z3NQFTZooi/8A+9VZjgXRZ+ALOte3p4jrek1dO
 v4/UXAUQXgdQ==
From:   Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [RFC PATCH V3 14/21] mmc: sdhci: UHS-II support, handle vdd2 in
 case of power-off
To:     Ben Chuang <benchuanggli@gmail.com>, ulf.hansson@linaro.org
Cc:     linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        ben.chuang@genesyslogic.com.tw, takahiro.akashi@linaro.org,
        greg.tu@genesyslogic.com.tw
References: <20200710111121.29671-1-benchuanggli@gmail.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <ef621382-b8b9-e8d2-cc54-3e6377050d5b@intel.com>
Date:   Fri, 21 Aug 2020 17:09:55 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200710111121.29671-1-benchuanggli@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/07/20 2:11 pm, Ben Chuang wrote:
> From: AKASHI Takahiro <takahiro.akashi@linaro.org>
> 
> Configure a regulator for VDD2 in case of power-off.
> 
> Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  drivers/mmc/host/sdhci.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 7f2537648a08..d38d734ec83f 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2333,6 +2333,11 @@ void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>  		if (!IS_ERR(mmc->supply.vmmc) &&
>  		    ios->power_mode == MMC_POWER_OFF)
>  			mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, 0);
> +		if (IS_ENABLED(CONFIG_MMC_SDHCI_UHS2) &&
> +		    host->mmc->caps & MMC_CAP_UHS2 &&
> +		    !IS_ERR(mmc->supply.vmmc2) &&
> +		    ios->power_mode == MMC_POWER_OFF)

Probably this can be just:

		if (!IS_ERR_OR_NULL(mmc->supply.vmmc2) &&
		    ios->power_mode == MMC_POWER_OFF)


> +			mmc_regulator_set_ocr(mmc, mmc->supply.vmmc2, 0);
>  		return;
>  	}
>  
>