Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp302823pxa; Fri, 21 Aug 2020 07:40:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSXRmslB27CQUMpO2YQ2dvfx1HtZhIeDsSODkriUv7nMnVK9slLXTzPPnd37sRF+3dQlzb X-Received: by 2002:a17:906:5383:: with SMTP id g3mr3369119ejo.370.1598020843808; Fri, 21 Aug 2020 07:40:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598020843; cv=none; d=google.com; s=arc-20160816; b=SulocR2j621/5HQBwOo/uxt6FF7WRk3g5BY6redSGBeJU7hty3qYnVe5VekBNZM0+Q 08ru/33zujZMTIIvHx5JqZwQy3ZAV9qU4aKN7ibUTIvhqut/epMhaBtjgOep6AElHdSr dD36oYfIk3OUapSVwGxXwkPAjDDrcxyaaYiWaGNoaQ2UDgCsOFFCUBsxuhu0xS5uGJtC 1MVymbZmO+hxbEFMNUTuzyz0TnIh8ByGYMrY1RzAQzliTNuZW7NRbaouTIIlBFJd8xe3 rj7eCUUkFQV8/H3NAaMFhiiLUBFig2L4aGVzniR43z2cBw2S9sFAEWYJHdl2xeQZx2K6 RdSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :reply-to:message-id:subject:cc:to:from:date; bh=9E2ZOzYd0yEUlcgLQy2htBb/ys/d0ta4VprZeGrHGG4=; b=KUiKze+FqQdOC+kn/nMnPam4F/Dcgqqhz7v5LJUk+PNHVSQEf3HvdEt6CpAS1ElH6p TaYdC022Ea5WsA2OjcOvSjkGtS2X5j8nquck304s/xDO89ZzAKF227PTVsHfJ6Hkj4WR TTAZUZ5qEmfG26JLW2gJ7j86YWoebO0xol+bvG05fRS1Vv64oZEtWq/SUm7wXxpsYmg1 80M/DiqSJXlqZmLyWcIMKTskyudVsXBHjeCPhlF0RRdo+5lyxn9OepX1NNf669yzDkGN 57vaahTg2UbXaKKjaFcDlM0pShLwgJ/sTr/O+Z1jqTTFwQDpL7NcDdF0MvcFN5NC0Vfv DW1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cy23si1416081edb.311.2020.08.21.07.40.19; Fri, 21 Aug 2020 07:40:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727808AbgHUOjq (ORCPT + 99 others); Fri, 21 Aug 2020 10:39:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:52232 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726118AbgHUOjp (ORCPT ); Fri, 21 Aug 2020 10:39:45 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 88F92AC82; Fri, 21 Aug 2020 14:40:11 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 61913DA730; Fri, 21 Aug 2020 16:38:37 +0200 (CEST) Date: Fri, 21 Aug 2020 16:38:37 +0200 From: David Sterba To: Alex Dewar Cc: Chris Mason , Josef Bacik , David Sterba , Goldwyn Rodrigues , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: check return value of filemap_fdatawrite_range() Message-ID: <20200821143837.GG2026@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Alex Dewar , Chris Mason , Josef Bacik , David Sterba , Goldwyn Rodrigues , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200821124154.10218-1-alex.dewar90@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200821124154.10218-1-alex.dewar90@gmail.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 21, 2020 at 01:41:54PM +0100, Alex Dewar wrote: > In btrfs_dio_imap_begin(), filemap_fdatawrite_range() is called without > checking the return value. Add a check to catch errors. > > Fixes: c0aaf9b7a114f ("btrfs: switch to iomap_dio_rw() for dio") > Addresses-Coverity: ("Unused value") > Signed-off-by: Alex Dewar Folded to the patch, thanks.