Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] PCI: sprd: Add support for Unisoc SoCs' PCIe
 controller
To:     Hongtao Wu <wuht06@gmail.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Rob Herring <robh+dt@kernel.org>
Cc:     Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Billows Wu <billows.wu@unisoc.com>
References: <1598003509-27896-1-git-send-email-wuht06@gmail.com>
 <1598003509-27896-3-git-send-email-wuht06@gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <a9e4caef-08b5-51c7-848d-1f360c9f3ea2@infradead.org>
Date:   Fri, 21 Aug 2020 08:15:21 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1598003509-27896-3-git-send-email-wuht06@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/21/20 2:51 AM, Hongtao Wu wrote:
> From: Billows Wu <billows.wu@unisoc.com>
> 
> This series adds PCIe controller driver for Unisoc SoCs.
> This controller is based on DesignWare PCIe IP.
> 
> Signed-off-by: Billows Wu <billows.wu@unisoc.com>
> ---
>  drivers/pci/controller/dwc/Kconfig     |  12 ++
>  drivers/pci/controller/dwc/Makefile    |   1 +
>  drivers/pci/controller/dwc/pcie-sprd.c | 256 +++++++++++++++++++++++++++++++++
>  3 files changed, 269 insertions(+)
>  create mode 100644 drivers/pci/controller/dwc/pcie-sprd.c

Hi,

> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 044a376..d26ce94 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -311,4 +311,16 @@ config PCIE_AL
>  	  required only for DT-based platforms. ACPI platforms with the
>  	  Annapurna Labs PCIe controller don't need to enable this.
> 
> +config PCIE_SPRD
> +       tristate "Unisoc PCIe controller - RC mode"
> +       depends on ARCH_SPRD
> +       depends on PCI_MSI_IRQ_DOMAIN
> +       select PCIE_DW_HOST
> +       help
> +         Some Uisoc SoCs contain two PCIe controllers as RC: One is gen2,

	         Unisoc

> +         and the other is gen3. While other Unisoc SoCs may have only one
> +         PCIe controller which can be configured as an Endpoint(EP) or a Root
> +         complex(RC). In order to enable host-specific features PCIE_SPRD must

	    complex (RC).

> +         be selected, which uses the Designware core.
> +
>  endmenu

Also, please follow Documentation/process/coding-style.rst for
Kconfig entries:

  For all of the Kconfig* configuration files throughout the source tree,
  the indentation is somewhat different.  Lines under a ``config`` definition
  are indented with one tab, while help text is indented an additional two
  spaces.


-- 
~Randy