Date: Mon, 22 May 2006 07:34:50 +0200
From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Badari Pulavarty <pbadari@us.ibm.com>, hch@lst.de, bcrl@kvack.org,
       cel@citi.umich.edu, zach.brown@oracle.com, linux-kernel@vger.kernel.org,
       Ian Kent <raven@themaw.net>
Subject: Re: [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead
Message-ID: <20060522053450.GA22210@lst.de>
References: <1146582438.8373.7.camel@dyn9047017100.beaverton.ibm.com> <1147197826.27056.4.camel@dyn9047017100.beaverton.ibm.com> <1147361890.12117.11.camel@dyn9047017100.beaverton.ibm.com> <1147727945.20568.53.camel@dyn9047017100.beaverton.ibm.com> <1147728133.6181.2.camel@dyn9047017100.beaverton.ibm.com> <20060521180037.3c8f2847.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060521180037.3c8f2847.akpm@osdl.org>
User-Agent: Mutt/1.3.28i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 847
Lines: 23

On Sun, May 21, 2006 at 06:00:37PM -0700, Andrew Morton wrote:
> Badari Pulavarty <pbadari@us.ibm.com> wrote:
> >
> > This patch removes readv() and writev() methods and replaces
> >  them with aio_read()/aio_write() methods.
> 
> And it breaks autofs4
> 
> autofs: pipe file descriptor does not contain proper ops

this comes because the autofs4 pipe fd doesn't have a write file
operations.

Badari do you remember any place in your patches where you didn't
add do_sync_write for a file_operations instance?

Ian, what kind of file is the autofs4 pipe?  is it a named pipe or
a fifo or a "real" file?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/