Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp413483pxa; Fri, 21 Aug 2020 10:25:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTEPB0lJRVvwkGaQbVeXKZSMQ0Rd2xwNHv5JftKk6Wakw/RF36nptViHLKKDzjsp5Sfg5n X-Received: by 2002:a50:da44:: with SMTP id a4mr4014994edk.36.1598030746996; Fri, 21 Aug 2020 10:25:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598030746; cv=none; d=google.com; s=arc-20160816; b=EtYDH3vwy6fIK/cldrbLfqTlysc4/CtRzribojQiMvEzQfba6yva1fft/TwJQLcCDy 6baCtvsmnqg0ibeSmXXu1LxZfbavjvas0F1Wio/fi8KaYQADix8U6ZnT/PII3JPwLZqU jWTj2zVTkjAsA9qGXhoqIufD4ACleyOVx0GgdYp8OLDOE0EBQHYQeWkYVH2+hfFr2bKm yjtn5aoCwvaso+V9NmHbvz8JbmJQZZCRM1c0P3yz0M1VUA2ucA0u8fGtAkB2CWdz90cw wOe1vE4uhEVVliz6SLpdmTxDU5xy9F+ak+W0CLOMD60L80ZEt1TQUjiQFp4ShadCT2h/ nHjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HeDqConHReQcjKgBIyyF6DCXNIw131nsn+XwJmVEN24=; b=Z8JQTyaLtKerJ/QN2N+e/7XUnvNydXCkQuiKH7nlcncJ8zgWVz9yQdsFGCpxN5pnU2 wYBVEHCpCMBG3YC0iSI1et1eFWKxhzCYHhreVixYOCcWUgOMdSwH8SAF2He7rja6STdi /XcJf5wQQvIIDg3BDDF5fz1I/MAg4NdaPBNXjPCdv9/CP3e1Xhf3D8uo6ooZbefi4v02 WLKi4tGbsIH21K6dChuYUsQN3PmXCSKuZHzQzjwzEpmPjarMjGxG8X2iB+8pYY+RZ/6c Sqc9YlanZ4eMwuSRCyGF7jwa10ZCufpLnQIFUNVBTo1LK8hZv6ujREgLs9xr1Vo4qgej lqiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mqjqBUj3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s3si1609758edy.554.2020.08.21.10.25.23; Fri, 21 Aug 2020 10:25:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mqjqBUj3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729169AbgHURYF (ORCPT + 99 others); Fri, 21 Aug 2020 13:24:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:48324 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727944AbgHUQPd (ORCPT ); Fri, 21 Aug 2020 12:15:33 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EFF8D22BED; Fri, 21 Aug 2020 16:15:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598026532; bh=I24xA+xdUYKV5J6GVNJn/ZBPTE2W97W1L7NFtlcKG18=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mqjqBUj3E91G4KCeMWzT621AZ4E8LVQyMOWBDjVO/nm9BWdKqkGEvzSinW8Hgz1hy enPb+O6mpEcdr6glbZeUL0VtHGdwZpxYpEoOWuYjMIzSs4XYowFt1f9adpixdK63Xt m5v/ILefK2pPkrSuv0YdK/m6cOPg+wp2eN4xJ608= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jing Xiangfeng , Mike Christie , "Martin K . Petersen" , Sasha Levin , open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.8 54/62] scsi: iscsi: Do not put host in iscsi_set_flashnode_param() Date: Fri, 21 Aug 2020 12:14:15 -0400 Message-Id: <20200821161423.347071-54-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200821161423.347071-1-sashal@kernel.org> References: <20200821161423.347071-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jing Xiangfeng [ Upstream commit 68e12e5f61354eb42cfffbc20a693153fc39738e ] If scsi_host_lookup() fails we will jump to put_host which may cause a panic. Jump to exit_set_fnode instead. Link: https://lore.kernel.org/r/20200615081226.183068-1-jingxiangfeng@huawei.com Reviewed-by: Mike Christie Signed-off-by: Jing Xiangfeng Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/scsi_transport_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index 7ae5024e78243..df07ecd94793a 100644 --- a/drivers/scsi/scsi_transport_iscsi.c +++ b/drivers/scsi/scsi_transport_iscsi.c @@ -3291,7 +3291,7 @@ static int iscsi_set_flashnode_param(struct iscsi_transport *transport, pr_err("%s could not find host no %u\n", __func__, ev->u.set_flashnode.host_no); err = -ENODEV; - goto put_host; + goto exit_set_fnode; } idx = ev->u.set_flashnode.flashnode_idx; -- 2.25.1