Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp414125pxa; Fri, 21 Aug 2020 10:26:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziyjs6ybOKDRH39fTt8oilnPCSzImrnWFr5UUPQM4QijuTMQziws4Vc54LISJCfYYs/Evv X-Received: by 2002:a17:907:42cc:: with SMTP id nz20mr3875113ejb.429.1598030803451; Fri, 21 Aug 2020 10:26:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598030803; cv=none; d=google.com; s=arc-20160816; b=O8+l8BqUBylUauTAaXcjHB5w7wvbKkPQv6IuQA6v1M3mnMHHlprCs3UOhb2Ch4p02A XdWouL881klQGaoqxZBGb4S8lA5naRhGKdh3bBzKhTIke8BKR7Kc6OvV4H+aH/dV5Fuf w/z+cD9ZBluES4tfCSd2A+4ZQ0N6i3ZTvkgqQvMYLN918YD834hBJfrpcRRUaiADGDOq QiRkz+dYJO1AQvlswsr8KbygQ7NQtlISAA3y4Z2PFQPlu1jcttu3is9hpBiz86DfRHrz lKsa1RTMfTQYbJIof2WyrqegyexnY4lziztHdS/4+O1CT8rnXRBCHW2o3c2dfHMOd9lG Sccg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JhTB0IRLtEDawVNLGA3XSfBf9xvFIZ7PeqnyFOAGAbs=; b=JYeIv5H3q6lep/zNv+IgTNJrODH8RX1BmwMWQ8joPol02r7vHiJvgAgt4PXWm6npLn loHJeLznAOF77BtK7OKsV6DXx3c6iAceOQwAsMtykdesHcun1bfDlBOir7uDxVOADUpJ jK39EvQI+NmgCpaVT0SuxS+Gvv5v6vm1esE8f2LjULghqQ42v4uGHi3Cevd+WL5yba67 jftQAxGQg0VeB6jW/sI6+qzExwAazUxzUw7nvUzy+mMDWEDyy6eclC9aRSJWodPXDYU6 L1F0mjRtJ6/c+JZaSqwQfiRC3BlNfJSookSWOYB+dxpycKtmB9CZY0VNflOT2d3ZQ6OR zJWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZZCJjL9Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n9si1576624edo.79.2020.08.21.10.26.18; Fri, 21 Aug 2020 10:26:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZZCJjL9Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727952AbgHURZQ (ORCPT + 99 others); Fri, 21 Aug 2020 13:25:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:48060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727902AbgHUQPY (ORCPT ); Fri, 21 Aug 2020 12:15:24 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69E2C21741; Fri, 21 Aug 2020 16:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598026524; bh=4P0E1TdwEUvHFMgvNrSm/DXS5S0ovHvkEWD5HGQ/MOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZZCJjL9Zj5J6cnTtuS7R5txtxAvHS2wjGPeb1SvKdU18XZgduni6tLj/MVWIDPAp2 Sx6YWE+KzqMGtKWbJLsOVobZAX/868WwDirgT1UbHFZkPeg/NFuKPrdzCx7ijhlSvP Y9AUMP6hcKGV245REWMBcDF98CFJlkxL+lHX9yPo= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Li Guifu , Chao Yu , Jaegeuk Kim , Sasha Levin , linux-f2fs-devel@lists.sourceforge.net Subject: [PATCH AUTOSEL 5.8 47/62] f2fs: fix use-after-free issue Date: Fri, 21 Aug 2020 12:14:08 -0400 Message-Id: <20200821161423.347071-47-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200821161423.347071-1-sashal@kernel.org> References: <20200821161423.347071-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Li Guifu [ Upstream commit 99c787cfd2bd04926f1f553b30bd7dcea2caaba1 ] During umount, f2fs_put_super() unregisters procfs entries after f2fs_destroy_segment_manager(), it may cause use-after-free issue when umount races with procfs accessing, fix it by relocating f2fs_unregister_sysfs(). [Chao Yu: change commit title/message a bit] Signed-off-by: Li Guifu Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/super.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 20e56b0fa46a9..0deb839da0a03 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -1173,6 +1173,9 @@ static void f2fs_put_super(struct super_block *sb) int i; bool dropped; + /* unregister procfs/sysfs entries in advance to avoid race case */ + f2fs_unregister_sysfs(sbi); + f2fs_quota_off_umount(sb); /* prevent remaining shrinker jobs */ @@ -1238,8 +1241,6 @@ static void f2fs_put_super(struct super_block *sb) kvfree(sbi->ckpt); - f2fs_unregister_sysfs(sbi); - sb->s_fs_info = NULL; if (sbi->s_chksum_driver) crypto_free_shash(sbi->s_chksum_driver); -- 2.25.1