Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp416344pxa; Fri, 21 Aug 2020 10:30:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfqDYLZxAzqHvrTcLxAOD71XwVrlryrvfbrB27W46qkMl29Au/swREokY9YnRuLNgLt+fb X-Received: by 2002:a17:906:528d:: with SMTP id c13mr4017091ejm.61.1598031018481; Fri, 21 Aug 2020 10:30:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598031018; cv=none; d=google.com; s=arc-20160816; b=CZyXq0Gbuoi+RwJzq7Vv89c9Dekt758lHFGLN0TaD6dEfdmDjSPmYtYVFoo/Td6QXR sp8i6KrjCRL/h1H4aGGjiA63qIY/+fkFtPnC16pOzZSCiyhKtCnwz0BMU1giYOit6pHZ PAYEZU8e5wStSoN9RZPXURb9lrljTz94sAl/2GBTn4wqCdqfNKtgjPJXUB5hIx1aOsaW dkMBEGlrka+VVIrDSnXJ87LpuNgC69BfRGYZ5daaHJDOw+UarYhmeY7/lDT6GUfCz8VJ a+rWmmaC9xDlR4/61dfXrrn6ZZd4n877kSdekcVDN5rMyQzSUn5kQaW8jZXmJ3GAXHIV sQGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RFe/Sse2NCO/HJ6CSzcaMSTevf7+CNG9MrjsTN+fzPA=; b=e0G55g5T5uvDBiA06uef018QpgtVOwjYFcj60BAv23NRAqbg7NHap3qokNfjWFbJy+ eUBYWioanSIMRH0GQwyzmt69HaL4MHs4RELlVnmgK3dqRGETVGVRZPndcOu+8pAOZn9P 3y+hyxqS1Js2Hr5Q99RDOg1LJ6DPK89y7IVDvUZFOZh11vo08gkvn8MGXB7qDff8+88V A61+KmEred33E5GpwDYmNSsFY/YxJsBpMP/wnzHRsHMSW6ZRF/GeiQdQgiUkPLU4o9fB +nwx4Uzwh46Pz5wsowwdCmkvY8PFYfn1pFUdxx+amyMQ7ARErTfap4J3WAipbQnST/mA +Ing== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aunaR5FB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d17si1638039edz.218.2020.08.21.10.29.55; Fri, 21 Aug 2020 10:30:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aunaR5FB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728896AbgHUR2U (ORCPT + 99 others); Fri, 21 Aug 2020 13:28:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:46686 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727024AbgHUQOr (ORCPT ); Fri, 21 Aug 2020 12:14:47 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 297DD20855; Fri, 21 Aug 2020 16:14:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598026483; bh=6AiJeu8UD5jdIPklU0UJ85alxQ5UPRtJBuOG4bUtfxI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aunaR5FBdgQt5wL42NKzGamqwzNXUyi6DEPTvvWE1Dy9It7NKiCigUYdVlX7FmQ7S LCg/cylpYLQ4Hwdu9QblneSmZ9OyNQ2WOECr3Qu6pp4N0jJv184wHz233y/sNsgEMV VSszcKZYfstI0+vuTXEGxSMDgn6CKaQZgUVlk940= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Evgeny Novikov , Greg Kroah-Hartman , Sasha Levin , devel@driverdev.osuosl.org Subject: [PATCH AUTOSEL 5.8 16/62] staging: rts5208: fix memleaks on error handling paths in probe Date: Fri, 21 Aug 2020 12:13:37 -0400 Message-Id: <20200821161423.347071-16-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200821161423.347071-1-sashal@kernel.org> References: <20200821161423.347071-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Evgeny Novikov [ Upstream commit 11507bf9a8832741db69efd32bf09a2ab26426bf ] rtsx_probe() allocates host, but does not free it on error handling paths. The patch adds missed scsi_host_put(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov Link: https://lore.kernel.org/r/20200623141230.7258-1-novikov@ispras.ru Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/rts5208/rtsx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index be0053c795b7a..937f4e732a75c 100644 --- a/drivers/staging/rts5208/rtsx.c +++ b/drivers/staging/rts5208/rtsx.c @@ -972,6 +972,7 @@ static int rtsx_probe(struct pci_dev *pci, kfree(dev->chip); chip_alloc_fail: dev_err(&pci->dev, "%s failed\n", __func__); + scsi_host_put(host); scsi_host_alloc_fail: pci_release_regions(pci); return err; -- 2.25.1