Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750727AbWEVIQk (ORCPT ); Mon, 22 May 2006 04:16:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750728AbWEVIQk (ORCPT ); Mon, 22 May 2006 04:16:40 -0400 Received: from mx1.redhat.com ([66.187.233.31]:35795 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1750727AbWEVIQk (ORCPT ); Mon, 22 May 2006 04:16:40 -0400 Message-ID: <44717355.1060403@themaw.net> Date: Mon, 22 May 2006 16:16:21 +0800 From: Ian Kent User-Agent: Thunderbird 1.5.0.2 (X11/20060501) MIME-Version: 1.0 To: Christoph Hellwig CC: Andrew Morton , Badari Pulavarty , bcrl@kvack.org, cel@citi.umich.edu, zach.brown@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead References: <1146582438.8373.7.camel@dyn9047017100.beaverton.ibm.com> <1147197826.27056.4.camel@dyn9047017100.beaverton.ibm.com> <1147361890.12117.11.camel@dyn9047017100.beaverton.ibm.com> <1147727945.20568.53.camel@dyn9047017100.beaverton.ibm.com> <1147728133.6181.2.camel@dyn9047017100.beaverton.ibm.com> <20060521180037.3c8f2847.akpm@osdl.org> <20060522053450.GA22210@lst.de> In-Reply-To: <20060522053450.GA22210@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1217 Lines: 32 Christoph Hellwig wrote: > On Sun, May 21, 2006 at 06:00:37PM -0700, Andrew Morton wrote: >> Badari Pulavarty wrote: >>> This patch removes readv() and writev() methods and replaces >>> them with aio_read()/aio_write() methods. >> And it breaks autofs4 >> >> autofs: pipe file descriptor does not contain proper ops > > this comes because the autofs4 pipe fd doesn't have a write file > operations. > > Badari do you remember any place in your patches where you didn't > add do_sync_write for a file_operations instance? > > Ian, what kind of file is the autofs4 pipe? is it a named pipe or > a fifo or a "real" file? The autofs4 fill_super does an fget on a pipe file handle passed in the mount options. It uses the write method of the returned file struct to send packets back to the daemon. The fill_super method checks to see if there is a write method present in the returned file struct and emits this message if it's not found. Ian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/