Message-ID: <4471741A.1000804@themaw.net>
Date: Mon, 22 May 2006 16:19:38 +0800
From: Ian Kent <raven@themaw.net>
User-Agent: Thunderbird 1.5.0.2 (X11/20060501)
MIME-Version: 1.0
To: Christoph Hellwig <hch@lst.de>
CC: Andrew Morton <akpm@osdl.org>, Badari Pulavarty <pbadari@us.ibm.com>,
       bcrl@kvack.org, cel@citi.umich.edu, zach.brown@oracle.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write
 instead
References: <1146582438.8373.7.camel@dyn9047017100.beaverton.ibm.com> <1147197826.27056.4.camel@dyn9047017100.beaverton.ibm.com> <1147361890.12117.11.camel@dyn9047017100.beaverton.ibm.com> <1147727945.20568.53.camel@dyn9047017100.beaverton.ibm.com> <1147728133.6181.2.camel@dyn9047017100.beaverton.ibm.com> <20060521180037.3c8f2847.akpm@osdl.org> <20060522053450.GA22210@lst.de>
In-Reply-To: <20060522053450.GA22210@lst.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 963
Lines: 26

Christoph Hellwig wrote:
> On Sun, May 21, 2006 at 06:00:37PM -0700, Andrew Morton wrote:
>> Badari Pulavarty <pbadari@us.ibm.com> wrote:
>>> This patch removes readv() and writev() methods and replaces
>>>  them with aio_read()/aio_write() methods.
>> And it breaks autofs4
>>
>> autofs: pipe file descriptor does not contain proper ops
> 
> this comes because the autofs4 pipe fd doesn't have a write file
> operations.
> 
> Badari do you remember any place in your patches where you didn't
> add do_sync_write for a file_operations instance?
> 
> Ian, what kind of file is the autofs4 pipe?  is it a named pipe or
> a fifo or a "real" file?

Ahh. Sorry missed the actual question.
It's a FIFO created with pipe(2).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/