Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200717060849.12469-1-liwei.song@windriver.com>
 <CAJvTdKm9WHgQuP38Y2o1zQ-VgLKMMDup4crAPrW3pexoWft+6Q@mail.gmail.com> <52f16995-6d2d-fa7d-ed5e-682db3461d03@windriver.com>
In-Reply-To: <52f16995-6d2d-fa7d-ed5e-682db3461d03@windriver.com>
From:   Len Brown <lenb@kernel.org>
Date:   Fri, 21 Aug 2020 14:50:04 -0400
Message-ID: <CAJvTdKms0Qj3d+g_tK8oboMXebYgnPm51EdSL_UvLdw3GV6A3A@mail.gmail.com>
Subject: Re: [PATCH] tools/power turbostat: call pread64 in kernel directly
To:     Liwei Song <liwei.song@windriver.com>
Cc:     Linux PM list <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Re: offset size

The offsets on this file are the MSR offsets.
What MSR are you trying to access at offset 0xc0010299?

Re: pread vs pread64

If I take on faith that you have some kind of 32-bit execution
environment that makes pread into pread32 instead of pread64, and that
truncates an off_t to 32-bits from 64-bits, and it actually makes
sense to request a read at this large offset...

would we really have to invoke syscall() directly -- couldn't we
invoke pread64() directly? (eg. below)

thanks,
-Len


@@ -490,11 +491,12 @@ int get_msr_fd(int cpu)
        return fd;
 }

-int get_msr(int cpu, off_t offset, unsigned long long *msr)
+int get_msr(int cpu, unsigned long long offset, unsigned long long *msr)
 {
        ssize_t retval;

-       retval = pread(get_msr_fd(cpu), msr, sizeof(*msr), offset);
+       retval = pread64(get_msr_fd(cpu), msr, sizeof(*msr), offset);

        if (retval != sizeof *msr)
                err(-1, "cpu%d: msr offset 0x%llx read failed", cpu,
(unsigned long long)offset);

On Thu, Aug 13, 2020 at 10:17 PM Liwei Song <liwei.song@windriver.com> wrote:
>
> with multilib lib32 support, the rootfs will be 32-bit,
> the kernel is still 64-bit, in this case run turbostat
> will failed with "out of range" error.
>
> Thanks,
> Liwei.
>
> On 8/14/20 05:43, Len Brown wrote:
> > Huh?
> >
> > On Fri, Jul 17, 2020 at 2:09 AM Liwei Song <liwei.song@windriver.com> wrote:
> >>
> >> with 32-bit rootfs, the offset may out of range when set it
> >> to 0xc0010299, define it as "unsigned long long" type and
> >> call pread64 directly in kernel.
> >>
> >> Signed-off-by: Liwei Song <liwei.song@windriver.com>
> >> ---
> >>  tools/power/x86/turbostat/turbostat.c | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
> >> index 33b370865d16..4c5cdfcb5721 100644
> >> --- a/tools/power/x86/turbostat/turbostat.c
> >> +++ b/tools/power/x86/turbostat/turbostat.c
> >> @@ -33,6 +33,7 @@
> >>  #include <sys/capability.h>
> >>  #include <errno.h>
> >>  #include <math.h>
> >> +#include <sys/syscall.h>
> >>
> >>  char *proc_stat = "/proc/stat";
> >>  FILE *outf;
> >> @@ -381,11 +382,11 @@ int get_msr_fd(int cpu)
> >>         return fd;
> >>  }
> >>
> >> -int get_msr(int cpu, off_t offset, unsigned long long *msr)
> >> +int get_msr(int cpu, unsigned long long offset, unsigned long long *msr)
> >>  {
> >>         ssize_t retval;
> >>
> >> -       retval = pread(get_msr_fd(cpu), msr, sizeof(*msr), offset);
> >> +       retval = syscall(SYS_pread64, get_msr_fd(cpu), msr, sizeof(*msr), offset);
> >>
> >>         if (retval != sizeof *msr)
> >>                 err(-1, "cpu%d: msr offset 0x%llx read failed", cpu, (unsigned long long)offset);
> >> --
> >> 2.17.1
> >>
> >
> >


-- 
Len Brown, Intel Open Source Technology Center