Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp504592pxa; Fri, 21 Aug 2020 12:55:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyR2JmgRjtieUr0mfCPH58jRqX3NVmnF80q7sFDBSlPpvVpQVC5Os1jQNyVIw0g7XgbWvfi X-Received: by 2002:a17:907:2163:: with SMTP id rl3mr4304355ejb.355.1598039748240; Fri, 21 Aug 2020 12:55:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598039748; cv=none; d=google.com; s=arc-20160816; b=CVg/F9+6c0JndWJ6Kj6laTtsdd0F1JCQHdO2uUgeVHx7sbw1vJS1J/NDhX8/dKc61b R6RtZGdLMmDpRG2PosXY1qcBCWA5/6OngyoNfHD3rFugtl8zDfBXhAtbTDnNEuLtp/RT 28tH7rhTV5jKuaBIM7JwKDr3KVMeQ5qm4588HittA0wt0YwS8mHb4jzG3hPCAtYneVmm 0n5Z0fjljsGRvwPBFkJz1VdrZwCqlWntzlDudIQXzyY1zEgZ2v+y/ZFX3hlQFK+cWLA/ w5m7/oSPtF22q3XFk/KQYHyfOm/T2KY+cFtSvxVdU9o/VNVqA+QVtf5rlKJE6SaC3Kl5 3A5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SwQmKOlsNP/z38IYejjYj+yvvrS1Eywv52+2HVAlv9Q=; b=n4rnI77GGD7bz2DuMxb3DCd9arwPcBpI5iBkRLoSuj6nUvMhDLFcplFsQFVlio/cBb Eip6q8TwoRmIhtr3Pr3RULQQcnrG9EeJ4ql8t8J9Le+z1EDvZI+3WX+yuz3/nms8GMow 7fQOb4DjNjOfXGWZrRTo1B+e952yj5VVhs+SOoNrugh9epSWGPYAFV0labVLV82HiuKH Sp0SiQcFxrgQVri5Kv0YvIYLKZemBWeI+pPNZFDEOvJ8wEvMUlYMlFo3VaYM4B9dsv5r VMJRLUKNlcuUUz6NT1/r7O5quGvpIf0w1RF23cjtSaZQZJuph6pEcC1okPJThy5TPfhD oP5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=R1LdeZIF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nv4si1896633ejb.737.2020.08.21.12.55.25; Fri, 21 Aug 2020 12:55:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=R1LdeZIF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726858AbgHUTye (ORCPT + 99 others); Fri, 21 Aug 2020 15:54:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726749AbgHUTyI (ORCPT ); Fri, 21 Aug 2020 15:54:08 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9E8CC0613ED for ; Fri, 21 Aug 2020 12:54:05 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id k13so1335830plk.13 for ; Fri, 21 Aug 2020 12:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SwQmKOlsNP/z38IYejjYj+yvvrS1Eywv52+2HVAlv9Q=; b=R1LdeZIF9QjkB4RICKULaFwrCsS1XuI99/vuiq4cUyDFMXBxzUFujL6oWyYM2UH1nh tWsZAtfxgGw6HkqEKt7TA3Ijkwr1LM5uL39F+VTZxX20aJt3RSZikDLByfg7RB4zZr5x 8gQzvir0FqNAzAZV4VAGlv9FBJ+2iKZA31XYI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SwQmKOlsNP/z38IYejjYj+yvvrS1Eywv52+2HVAlv9Q=; b=n96BNj7lHhQSWn5D/3LikHoAC1mWlP9aRf6x0FHyLwhUGJvSOwMeGpS3fMhxOiNQAp ugt4IG2sMgf4Q8uxK6iZFOHl4PDNXrndnur/QRJWFP4yDR7hF5pT9zoK10kIakzMyg5i C1TZ63QJXEan6zH0pRsBV4HqFL1LmxhNBe5MdBH0+aceMvWl+O0qYaRp/4SqTZykDznM b9Se2PJ+RL672IY2mHDJmjIkdsr/pYv33xOy9qknucjFyvyrrTtX8f3vepUsUl+961Li t0d2UoULilZmXCJyuN95DdxP8Lq3pRzG9tDhGWIUH4kYwFNE8NFlROXxSzjLFk73dFVd mRjA== X-Gm-Message-State: AOAM530OpqZ8Wrk7DFHQ0EHwNdYqEc/5TWi9D2xM1SdUKdZ9XLXtXh13 pagOTU4AosbQKrFODlDFIBsTQg== X-Received: by 2002:a17:902:9a43:: with SMTP id x3mr3388759plv.31.1598039645460; Fri, 21 Aug 2020 12:54:05 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z77sm3469389pfc.199.2020.08.21.12.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2020 12:54:02 -0700 (PDT) From: Kees Cook To: Ingo Molnar Cc: Kees Cook , Will Deacon , Catalin Marinas , Mark Rutland , Ard Biesheuvel , Peter Collingbourne , James Morse , Borislav Petkov , Ingo Molnar , Russell King , Masahiro Yamada , Arvind Sankar , Nick Desaulniers , Nathan Chancellor , Arnd Bergmann , x86@kernel.org, clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 14/29] arm64/build: Warn on orphan section placement Date: Fri, 21 Aug 2020 12:42:55 -0700 Message-Id: <20200821194310.3089815-15-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200821194310.3089815-1-keescook@chromium.org> References: <20200821194310.3089815-1-keescook@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly handled in the linker script. With all sections now handled, enable orphan section warnings. Acked-by: Will Deacon Signed-off-by: Kees Cook --- arch/arm64/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index 6de7f551b821..61a46f56ff33 100644 --- a/arch/arm64/Makefile +++ b/arch/arm64/Makefile @@ -29,6 +29,10 @@ LDFLAGS_vmlinux += --fix-cortex-a53-843419 endif endif +# We never want expected sections to be placed heuristically by the +# linker. All sections should be explicitly named in the linker script. +LDFLAGS_vmlinux += --orphan-handling=warn + ifeq ($(CONFIG_ARM64_USE_LSE_ATOMICS), y) ifneq ($(CONFIG_ARM64_LSE_ATOMICS), y) $(warning LSE atomics not supported by binutils) -- 2.25.1