Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp530345pxa; Fri, 21 Aug 2020 13:39:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXPdj0YDB9fHphDe8lc5LQARehEdWbqwTamgSpKtJWqIYo9yb5qjWV71RaxoYCO4mV/czc X-Received: by 2002:a17:906:d8f:: with SMTP id m15mr4596411eji.494.1598042359959; Fri, 21 Aug 2020 13:39:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598042359; cv=none; d=google.com; s=arc-20160816; b=stYPNx0QTIPOWZUKT3byLr5+mTfzbu0SLAxqMZpMZgMqC/WF+Lspuxq/bTGpCPf8V+ /ONNINY78zYTsGjijLAoJcGsjkAFds7gZLQUktKuvSPufniWWK8/8R4wLU/tVK0+US2V xhaQ1va84qVi8FAcyn+juNecbEHFJ9/MUsx6XqOk3iJjMLr6jUEI13EdJZWuTvE0h4NX 0aX5W5HZ2U7dopeXRicsGErFcW5H3/LYHgIeU5S1s5T7Jmw+5v5g6z9f8Tc/3+ETTvEE qeNGrdKi286NSXPwdIirO9Qxb5lCz8AZc+9SyApJ2KJTQF6XvO4XWMSu8KPZ9dhxnYXG 0i8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=X/XoRlNP5JQO7JX2kXp4LhcpVbGmN2+bMJSBk4lkJ/I=; b=UUDm5imF1FbRkfV7UV/NA+Xv9bWJ2VkwVebOyMZ6XfWtmYp29pphg2BvMH/2nrxEmB /AcZAwXAyN53kS4nCsdmmuj/xtX9uE2CqQVT+OtQD9cOyVyoPxsQEmoZj6dluVN1tDPK F63rPL3PVGyIi4BiHumx8DYivmDEjKt3h/OxIFSR+AmxpIm/wtL9SKxtk9mEWvhd0/pO QVAi1X/+7ENi3h0lAqCxYiiIMHcB3zbU3TlAnKQrW10mq1J8rr6ttSDD7xd7rmgulpz3 fIWSXZ968cCByzSI7H2EWrgIPvInKhwaBVqrBvEb1LjA6Je0fh5442SWCwLQJ5n9VAuZ ldKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dbaA4CUK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w13si2031485edq.220.2020.08.21.13.38.55; Fri, 21 Aug 2020 13:39:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dbaA4CUK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726466AbgHUUfu (ORCPT + 99 others); Fri, 21 Aug 2020 16:35:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:43982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbgHUUft (ORCPT ); Fri, 21 Aug 2020 16:35:49 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1298420724; Fri, 21 Aug 2020 20:35:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598042149; bh=iPJvCED2WCBB6L3Yu9e5XQUakMAYNcGoa6MXkWUrumA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dbaA4CUK3S7ylOEHuTbLGNOwHFvx8fACqtTK81nq1Pfs6mklJI2pVOyllUZIBwgkA 2gP2mGv6TFJUrJrpJs3Y5YUwJe4jzcPSu8xJJ7m7w/1L+3XPF6jJI66onZTm3lhCCT 10TD6KyGhdLdFgTyXgMiVJZigkVH74U4HKn1XHl4= Date: Fri, 21 Aug 2020 13:35:48 -0700 From: Andrew Morton To: Joerg Roedel Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chris Wilson , intel-gfx@lists.freedesktop.org, Pavel Machek , Linus Torvalds , Dave Airlie , Joonas Lahtinen , Rodrigo Vivi , David Vrabel , Joerg Roedel , stable@vger.kernel.org Subject: Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range() Message-Id: <20200821133548.be58a3b0881b41a32759fa04@linux-foundation.org> In-Reply-To: <20200821123746.16904-1-joro@8bytes.org> References: <20200821123746.16904-1-joro@8bytes.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Aug 2020 14:37:46 +0200 Joerg Roedel wrote: > The __apply_to_page_range() function is also used to change and/or > allocate page-table pages in the vmalloc area of the address space. > Make sure these changes get synchronized to other page-tables in the > system by calling arch_sync_kernel_mappings() when necessary. There's no description here of the user-visible effects of the bug. Please always provide this, especially when proposing a -stable backport. Take pity upon all the downstream kernel maintainers who are staring at this wondering whether they should risk adding it to their kernels.