Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.0.3\))
Subject: Re: [PATCH 0/7] Overhaul find_get_entries and pagevec_lookup_entries
From:   William Kucharski <william.kucharski@oracle.com>
In-Reply-To: <20200819150555.31669-1-willy@infradead.org>
Date:   Fri, 21 Aug 2020 20:34:38 -0600
Cc:     linux-mm <linux-mm@kvack.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Hugh Dickins <hughd@google.com>,
        Johannes Weiner <hannes@cmpxchg.org>, Jan Kara <jack@suse.cz>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <F3875B5A-52FF-41B8-8F57-2F25659949D6@oracle.com>
References: <20200819150555.31669-1-willy@infradead.org>
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Aug 19, 2020, at 9:05 AM, Matthew Wilcox (Oracle) =
<willy@infradead.org> wrote:
>=20
> This started out as part of the THP patchset, but it's turned into a
> nice simplification in its own right.  Essentially we end up unifying
> find_get_entries() and pagevec_lookup_entries() into one function =
that's
> better than either, and we get rid of a lot of code in the callers as
> a result.
>=20
> I'm running this through xfstests right now, but something similar to
> this has already passed xfstests as part of the THP patchset.
>=20
> I've done my best to avoid off-by-one errors for 'end', but I wouldn't =
be
> surprised if I made a mistake.  We're not consistent with whether =
'end'
> is inclusive or exclusive and I didn't want to make extensive changes
> to ensure they were consistent.
>=20
> Matthew Wilcox (Oracle) (7):
>  mm: Use pagevec_lookup in shmem_unlock_mapping
>  mm: Rewrite shmem_seek_hole_data
>  mm: Add an 'end' parameter to find_get_entries
>  mm: Add an 'end' parameter to pagevec_lookup_entries
>  mm: Remove nr_entries parameter from pagevec_lookup_entries
>  mm: Pass pvec directly to find_get_entries
>  mm: Remove pagevec_lookup_entries
>=20
> include/linux/pagemap.h |  3 +-
> include/linux/pagevec.h |  4 --
> mm/filemap.c            | 19 +++++----
> mm/shmem.c              | 85 ++++++++++++++---------------------------
> mm/swap.c               | 38 +-----------------
> mm/truncate.c           | 33 +++-------------
> 6 files changed, 45 insertions(+), 137 deletions(-)

Very nice cleanups and the code makes more sense, thanks.

Reviewed-by: William Kucharski <william.kucharski@oracle.com>=