Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 22 Aug 2020 12:02:24 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc:     Li Yang <leoyang.li@nxp.com>, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: dts: ls1021a: fix QuadSPI-memory reg range
Message-ID: <20200822040224.GC27575@dragon>
References: <20200728105006.7952-1-matthias.schiffer@ew.tq-group.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200728105006.7952-1-matthias.schiffer@ew.tq-group.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 28, 2020 at 12:50:06PM +0200, Matthias Schiffer wrote:
> According to the Reference Manual, the correct size is 512 MiB.
> 
> Without this fix, probing the QSPI fails:
> 
>     fsl-quadspi 1550000.spi: ioremap failed for resource
>         [mem 0x40000000-0x7fffffff]
>     fsl-quadspi 1550000.spi: Freescale QuadSPI probe failed
>     fsl-quadspi: probe of 1550000.spi failed with error -12
> 
> Fixes: 85f8ee78ab72 ("ARM: dts: ls1021a: Add support for QSPI with ls1021a SoC")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Idiomatically we use 'ARM: ...' for arm32 DTS patch prefix.

I fixed it up and applied the patch.

Shawn

> ---
>  arch/arm/boot/dts/ls1021a.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index b2ff27af090e..9435ce527e85 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -181,7 +181,7 @@
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0x0 0x1550000 0x0 0x10000>,
> -			      <0x0 0x40000000 0x0 0x40000000>;
> +			      <0x0 0x40000000 0x0 0x20000000>;
>  			reg-names = "QuadSPI", "QuadSPI-memory";
>  			interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-names = "qspi_en", "qspi";
> -- 
> 2.17.1
>