Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: /tgECFdLSz61qZ4rt/WqgVHIIGVNmxu8azP01t3xuApMr09oFS7l8wOcmpIN8WKrqZMWqqV/Ui
 jkF0KmEewaEA==
IronPort-SDR: w+1lVZezxPiYtIAfwBALW9KJ6hUs7BWHPRIy8uzlAaArGVbklPYIzdYbBPISVJZxENsW3sWluk
 sE62Ty4DVTCA==
Subject: Re: [PATCH v9 2/2] Add PWM fan controller driver for LGM SoC
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org,
        lee.jones@linaro.org, thierry.reding@gmail.com,
        p.zabel@pengutronix.de, robh+dt@kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        songjun.Wu@intel.com, cheol.yong.kim@intel.com,
        qi-ming.wu@intel.com, rahul.tanwar.linux@gmail.com,
        rtanwar@maxlinear.com
References: <cover.1598001442.git.rahul.tanwar@linux.intel.com>
 <fedf5d1ace7c389a5fc0116865b9b88aa3ddeaa5.1598001442.git.rahul.tanwar@linux.intel.com>
 <20200821105618.GO1891694@smile.fi.intel.com>
From:   "Tanwar, Rahul" <rahul.tanwar@linux.intel.com>
Message-ID: <d8c85de1-dacf-e8eb-6e49-131d007f3a6b@linux.intel.com>
Date:   Sat, 22 Aug 2020 13:21:28 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20200821105618.GO1891694@smile.fi.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Andy,

On 21/8/2020 6:56 pm, Andy Shevchenko wrote:
> On Fri, Aug 21, 2020 at 05:32:11PM +0800, Rahul Tanwar wrote:
>> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller.
>> This PWM controller does not have any other consumer, it is a
>> dedicated PWM controller for fan attached to the system. Add
>> driver for this PWM fan controller.
> ...
>
>> +#include <linux/bitfield.h>
>> +#include <linux/clk.h>
>> +#include <linux/module.h>
>> +#include <linux/of_device.h>
> We haven't settle this yet...

I investigated more about it. I was getting build error because we were
relying on of_device.h for including platform_device.h. You are right that
we are not using anything from of_device.h. So i removed of_device.h from
driver and added include <linux/platform_device.h> & build is ok.

Regarding mod_devicetable.h header, it gets included indirectly from
<linux/pwm.h> which includes of.h which includes mod_devicetable.h. So i
think no point including it again in the driver.

Regards,
Rahul

>> +#include <linux/pwm.h>
>> +#include <linux/regmap.h>
>> +#include <linux/reset.h>