Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on
 Intel NUC boxes
From:   Chris Clayton <chris2553@googlemail.com>
To:     =?UTF-8?B?5ZCz5piK5r6EIFJpY2t5?= <ricky_wu@realtek.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "philquadra@gmail.com" <philquadra@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>
References: <862172f0-cd23-800c-27b1-27cb49e99099@googlemail.com>
 <a9a94d7f-4873-7a10-4911-f3c760257c5c@googlemail.com>
 <5729c72bbc2740d3917619c85e2fde58@realtek.com>
 <20200804074831.GB1761483@kroah.com>
 <11e224ca299b48f1bea07082f2ff7c00@realtek.com>
 <0afbd711-0bda-d9a3-138d-5c713b4e2ed9@googlemail.com>
 <19de15c2f07d447dace6bea483d38159@realtek.com>
 <152ef6c0-f3c0-bb67-4175-adced3c720cd@googlemail.com>
 <e1c295f28e3d4bdd8c78dfd3a5ed398c@realtek.com>
 <68b9bdd2-a05e-7fb0-ec9a-70b03e0c5289@googlemail.com>
 <20da8b4b-8426-9568-c0f1-4d1c2006c53f@googlemail.com>
Message-ID: <29b12ecc-6e5c-8c1a-942b-ad23a95d020a@googlemail.com>
Date:   Sat, 22 Aug 2020 08:24:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101
 Thunderbird/80.0
MIME-Version: 1.0
In-Reply-To: <20da8b4b-8426-9568-c0f1-4d1c2006c53f@googlemail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Ricky.

On 05/08/2020 13:48, Chris Clayton wrote:
> Hi Ricky
<snip>
>>
>> Ah, OK. I'll prepare the patch and send it to you once I've tested it.
>>
> 
> Please see the patch included below. As you suggested, it removes the code that does the OC power down on card readers
> that are not members of your A series. The patch is against a fresh pull of Linus's tree this morning
> (v5.8-2768-g4da9f3302615).
> 
> I've tested the resultant kernel on my Intel NUC6CAYH box (which contains an NUC66AYB board) and the rts5229 works fine.
> I've also tested it on my laptop which also has a card reader supported by the rtsx_pci driver (an RTL8411B) and that
> also works fine.
> 
> As I mentioned yesterday, I think it's a candidate for the 5.4 ans 5.7 stable series.
> 
> Thanks for your patience!
> 
> Chris
> 
> Signed-off-by: Chris Clayton <chris2553@googlemail.com>
> 
> --- a/drivers/misc/cardreader/rtsx_pcr.c        2020-08-05 07:10:21.752072515 +0100
> +++ b/drivers/misc/cardreader/rtsx_pcr.c        2020-08-05 07:11:05.568074278 +0100
> @@ -1172,10 +1172,6 @@ void rtsx_pci_init_ocp(struct rtsx_pcr *
>                         rtsx_pci_write_register(pcr, REG_OCPGLITCH,
>                                 SD_OCP_GLITCH_MASK, pcr->hw_param.ocp_glitch);
>                         rtsx_pci_enable_ocp(pcr);
> -               } else {
> -                       /* OC power down */
> -                       rtsx_pci_write_register(pcr, FPDCTL, OC_POWER_DOWN,
> -                               OC_POWER_DOWN);
>                 }
>         }
>  }
> 
> 

Is there some problem with my patch? If you are too busy to deal with it, perhaps I can submit directly it to Greg/Arnd.

Thanks

Chris