Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp946635pxa; Sat, 22 Aug 2020 05:41:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzp3lnnI33qzx0sGqTCTXff7kDpCo3sHdvdHCHwNZzWXfKJyUmib5LwgZbCIOCAxgMvGrTR X-Received: by 2002:aa7:da18:: with SMTP id r24mr5371923eds.358.1598100096832; Sat, 22 Aug 2020 05:41:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598100096; cv=none; d=google.com; s=arc-20160816; b=vx8xDoToUJD2mGiR6xzL13lwuADwvjIsv7IjutCXSyjQ+qhFdh+v9q+3OEQHlZX913 JDSAXMs5Ahqpm+xj2gJraw2eFxHEp+dnydxfd/S82FKppfpxFsUw0hln9OpF8Pp+PRhB i8u2TS+w4GJ8SBCZ8sUkK/fmB9irKSCAPmrRS7PtPVFKGhlkcRewGJiUjqZWKDwyz2NN BDoV8B/Qeay5A50q+jUgSGjNEe3ODAAm5w1o93v0PeN2XPphFb4obRLtpmFkWuh3u8Qo AeyOOjwSaBEZwnGZ1gQrPAR2VTKyxQZKq5Hk+A+cBd1hBuESVXzze1e21B1xdaWyedaa Tmag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=I0WMrfxGYGWkQ81nFOYlptwTsjS7dexlcxZh2RL/wGU=; b=GG73W3svN+hSdRq9fap6CO4e/iI8Djr95YJv8IVbgwdp6UG2rjkqRpUZG4gX3OOjIw dKghgOhrCUa9j81SZ+17/vCNmzp+cW8tCSb1MvrfXIymgcnswzysp3Mq9S6cpSJKIG+f DYP9otRdiIJAUqVt9/G+1n+gBCHYfpHBiTON7R1Vf+LdYiQBGfxl4W+RcGpib1EQiOjM 5/3QXzJRSYiSiPcr84XpZ4D8lARtmr4vVSuoyINr9G8VuSsyZ5HpJysCltuLz/dqrQWP IETTGnBZlJc5YbNcR7JwNIhLTxZ+mJP5FD18LS44QTtkgs+Ebgxr6o8QPQ6NA6keQQ/A pGhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l60si3402851ede.535.2020.08.22.05.41.13; Sat, 22 Aug 2020 05:41:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728041AbgHVMhl convert rfc822-to-8bit (ORCPT + 99 others); Sat, 22 Aug 2020 08:37:41 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:42647 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728020AbgHVMhk (ORCPT ); Sat, 22 Aug 2020 08:37:40 -0400 Received: by mail-wr1-f65.google.com with SMTP id d16so4301104wrq.9; Sat, 22 Aug 2020 05:37:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Zsjdj30vPVAczb2I1jVNJYKyxUg3Yx5VcTWg2Jlo+tA=; b=Vx1LklBS0TeKPVb267O/2XxB2ZDPeeLVibAs0k1/aA4XcXzHmNQqoJCkL3DnAnG8k3 EpZLz3zBza0/XZXJDitpXxchLetSgXGPslql55HwTL7lS615X/jKcxZ/sk+SVE27ZFh6 fnDwRUnr4nDzX9053buvrEpWfE8NiZNV8Co5om/Vs/VY3JZoCHbd4Ze4pTl/0D76Yth1 g3Y4sSfh0aCjGK10zzGH1HI0T69smWMGwvHQmw1IoKM5hZY2vwU6ObgzJrKDuIlW24/j mcUDPDiM51lkEUw37qtGakblQZCwI0rp1N8+jV8NvEchCo3qOqb9qlNOQ8asBXu1s1ms EA1Q== X-Gm-Message-State: AOAM533093hfpnHcq8+t6hPmpLlk7WnYvzCZ1IxgfICiyHq4sCyUZGX9 FnggEP49863N7ECre+pmTLs= X-Received: by 2002:adf:fc52:: with SMTP id e18mr2269869wrs.185.1598099858314; Sat, 22 Aug 2020 05:37:38 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id g70sm13284254wmg.24.2020.08.22.05.37.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Aug 2020 05:37:37 -0700 (PDT) Date: Sat, 22 Aug 2020 14:37:35 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Cc: Kukjin Kim , Andi Shyti , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com Subject: Re: [PATCH v2 6/9] spi: spi-s3c64xx: Check return values Message-ID: <20200822123735.GE20423@kozik-lap> References: <20200821161401.11307-1-l.stelmach@samsung.com> <20200821161401.11307-7-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20200821161401.11307-7-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 21, 2020 at 06:13:58PM +0200, Łukasz Stelmach wrote: > Check return values in prepare_dma() and s3c64xx_spi_config() and > propagate errors upwards. > > Signed-off-by: Łukasz Stelmach > --- > drivers/spi/spi-s3c64xx.c | 47 ++++++++++++++++++++++++++++++++------- > 1 file changed, 39 insertions(+), 8 deletions(-) This should be a third patch - backportable fixes should go at beginning. Fixes: 788437273fa8 ("spi: s3c64xx: move to generic dmaengine API") Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof