Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp948317pxa; Sat, 22 Aug 2020 05:45:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwnLzVatnyu7mYlqO5KNl7VmSM4Er0LSdNp4TNa+FN1t6oAsvxymrIlqtW2u/BK1smNax+ X-Received: by 2002:a17:906:7108:: with SMTP id x8mr7001906ejj.447.1598100328966; Sat, 22 Aug 2020 05:45:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598100328; cv=none; d=google.com; s=arc-20160816; b=ddMbusaa2p+BJVwSI+wPlWo0xNv8ushqs3IxQzbgjP/pnRPtm1aSzVcDb1lRlnLEHz 4NESk7FoLB+H3qUMRzTJ1hwF3OPsbvCh5flCG/EbELeFBwWTpC3bA1qs1feFCgpmz46+ Z2DstJMaAkMBUzpgER/A0YRFsAu3bV1THS8KNQXknOe4wFut/rr156mVEnAlK8e5wFiX J4grrGavJku3bHRbmh/PuSPvHdDT778TcenQn9OYow0XjwhvX8W2c82fXTwPwA4yojTE dgTwOofXHNpJNewpvjE50hg9Sj0oK0PI/PjChRyruC0vw9WwTN3UZgD30hDa4px/QeWM Aprg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=gGDmqiem3BijAJgcDihHUIDbQVg7N5MH4zaA1aZPeSA=; b=SqxbEFhU1qcZDUwHs9UFSajVbmVq0EKCnQaFm92NV0/Rq7swmGjLUxW6YgObnjBO4d DoFhHQY8SlSCJd/keI6LdNF6MGGRRHhnjdmoeDq+veIWnQXdDKzFD4IaLjUrX0fQMkP8 JRFcqVk7v+pZwCD6VAYVy1VDWn5LnwJ113c/ua2w5qnaWZHpFhg+/mgCrKUAT89eST9j k+aKtN1uS6dQYCPy1roQzYXzihCDJhlxtzk5Il2cibrr6Xzi1vSt5fa24ztDv58rgSl6 rIBEObV/x4hHIKu5ndB1OHRO9+Q4QABz5T6hRlEEF8yeYFpqbv5fAomFUA/WP4ykWPf8 Fz6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v16si3064432ejq.43.2020.08.22.05.45.04; Sat, 22 Aug 2020 05:45:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728070AbgHVMoC convert rfc822-to-8bit (ORCPT + 99 others); Sat, 22 Aug 2020 08:44:02 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:56059 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728057AbgHVMoB (ORCPT ); Sat, 22 Aug 2020 08:44:01 -0400 Received: by mail-wm1-f66.google.com with SMTP id a65so624149wme.5; Sat, 22 Aug 2020 05:44:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=b/LQHLcTnWB1iXJZRAUqfkq4diYrkCqNNZRoscuAqx0=; b=qA1jEFzfh0rVYRn8nyG/LVeNUuCVYNa68oOnBjlypABfSZPa+nA+PWh8HBOnYVrp6P YnqlEpfUEVSYQ0X9/GvZHwygVXqi5PjzcFOS3ymimk05sXNs4DtQ2cKI7yvAAsVHr5FA BvekRB5xi5Eg6wfMY/i0QN3crtZxt732Dh5y4/yLXU8lr4O2i1u1V+8za9ApO4DSa5Za ipxw0WI2O1KNun6TsjABkAmymzF+PAvElk9MkAMrFD29jGsYD1WaervyBnWZtsTeM8rS mSrIjyQxSgFOzOhYCUiVLYmlPwgRaH+xYoTEsdjGJqtpTEY1/shfLpvH172FgWzsE+hY GuiQ== X-Gm-Message-State: AOAM532vGcmWhSItCvKTUDvOV5w1qMoVg5nry/+ar699Y7WfByArFAkB WqGMmzwlV1nXZ/aK64Mi9xhMyjkP+U4= X-Received: by 2002:a1c:e912:: with SMTP id q18mr7508362wmc.130.1598100239317; Sat, 22 Aug 2020 05:43:59 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id v12sm10482993wri.47.2020.08.22.05.43.58 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Aug 2020 05:43:58 -0700 (PDT) Date: Sat, 22 Aug 2020 14:43:56 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Cc: Kukjin Kim , Andi Shyti , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com Subject: Re: [PATCH v2 8/9] spi: spi-s3c64xx: Increase transfer timeout Message-ID: <20200822124356.GG20423@kozik-lap> References: <20200821161401.11307-1-l.stelmach@samsung.com> <20200821161401.11307-9-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20200821161401.11307-9-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 21, 2020 at 06:14:00PM +0200, Łukasz Stelmach wrote: > Increase timeout by 30 ms for some wiggle and set the minimum value to > 100 ms. This ensures a non-zero value for short transfers which > may take less than 1 ms. The timeout value does not affect > performance because it is used with a completion. > > Similar formula is used in other drivers e.g. sun4i, sun6i. > > Signed-off-by: Łukasz Stelmach > --- > drivers/spi/spi-s3c64xx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof