Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp963406pxa; Sat, 22 Aug 2020 06:14:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyK0fQoDJ2xnBvwadcOfpGuVaCo4L/N2Z5io7zT1+xtRWo8pa3KMu3w533bvpJkarJA/d1E X-Received: by 2002:a17:906:7790:: with SMTP id s16mr7736634ejm.254.1598102090037; Sat, 22 Aug 2020 06:14:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598102090; cv=none; d=google.com; s=arc-20160816; b=sq9t9q3avYNVhJ4LHG4kEc+5p+ZwUb2Q5GLnWYQ6ubmnTZqw6ijpfiMwhDjtqKHa+P mr5c+eFHz6+nHDOnq3WPIUKzCF91hG/sO1biy2Ann3+wvllOs6lT42ydM+zfnrXxsjLt 9VA/CW3YQsOkecDMTAAQ0+CDmAYJVx+W2UX4Flui6grvwzjnhFviSlpqznKen9u9Mhhq EzxMOleA93whJB3RCiDTnUwh0JF1jonFdSDYwmwddzN4MLZzlSMQ055UKNjQ8LDiHIBE eGwlSulXt1rmVTILBDHdD1l+iTk6pcSX6MzaeyR8GRbjrq70yyNLGNWe687I8mUrMBYR sjeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=W7icbdrjXIMjEIuPepc0EKhRXc/76Hvc8/WClwhuPEY=; b=QhmwC2KuF3et5IwsXPsXNamSgn6r7og6s9oM59IUK1qy0ev6PnQZmw1N0rO4/mo3w6 +h4cYlWL7OIjItmLqvWAUj7jYaJPZ1JYf1zYUJGTu+q/dunnkvK/9/mhYv4IMudXZehw pfBPKKRfbuX8egHu8eus2KwffURwzwFB2IqhEBy4510c02W0IqHv2q7thlEqz5YyBiX7 t6wc4qMiB8FTOsJsV+MOehIw8i2XFrSgbEsdSBcOOtoeAD57xjTvp5VkgEaZdjhX/I5Z G+LIUkWOZPrWfOgHpDZfZ+DE+jhHSTEGTo6KGsHHp0a1wuA+P9Kzi+ynPR4H6L3HNrM3 hpRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=iTfHddlf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mb5si3129387ejb.206.2020.08.22.06.14.26; Sat, 22 Aug 2020 06:14:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=iTfHddlf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728052AbgHVNNY (ORCPT + 99 others); Sat, 22 Aug 2020 09:13:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727827AbgHVNNW (ORCPT ); Sat, 22 Aug 2020 09:13:22 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9912C061573; Sat, 22 Aug 2020 06:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=W7icbdrjXIMjEIuPepc0EKhRXc/76Hvc8/WClwhuPEY=; b=iTfHddlfukLpE8OPjam/73lwat Co5qhCkH1ok53KdJjF15cQ+6VVRx2sX8go2p8vEZAJVXb7nmdctqb/wcJBZ3ECDpeyBbByBFiDfFk ibnHWaKau2hb5v2Bbs4Ty8c3/k/SLWdQijHR4hzrSaFd6CYe9udAad3XhRJoxOTj/TfTqz/fLzInQ e2pmszP0jSl4eSoRujZzznOd8aupwNj6WyTtbkhZh14Am1hZKzl1FAjNOsDC16b021I6ukuFfalmp 3uFUVbo01VL91mhXWHtjjIDa51Kt3Bj1M9YRb0VmGG0dePYDNXR6mWtIoyg8PThBtxMfG+cT8yj22 ZmtmDXTQ==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9TKa-0004jA-Ez; Sat, 22 Aug 2020 13:13:12 +0000 Date: Sat, 22 Aug 2020 14:13:12 +0100 From: Christoph Hellwig To: Dave Chinner Cc: Ritesh Harjani , Anju T Sudhakar , hch@infradead.org, darrick.wong@oracle.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org Subject: Re: [PATCH] iomap: Fix the write_count in iomap_add_to_ioend(). Message-ID: <20200822131312.GA17997@infradead.org> References: <20200819102841.481461-1-anju@linux.vnet.ibm.com> <20200820231140.GE7941@dread.disaster.area> <20200821044533.BBFD1A405F@d06av23.portsmouth.uk.ibm.com> <20200821215358.GG7941@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200821215358.GG7941@dread.disaster.area> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 22, 2020 at 07:53:58AM +1000, Dave Chinner wrote: > but iomap only allows BIO_MAX_PAGES when creating the bio. And: > > #define BIO_MAX_PAGES 256 > > So even on a 64k page machine, we should not be building a bio with > more than 16MB of data in it. So how are we getting 4GB of data into > it? BIO_MAX_PAGES is the number of bio_vecs in the bio, it has no direct implication on the size, as each entry can fit up to UINT_MAX bytes.