Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1136763pxa;
        Sat, 22 Aug 2020 12:35:39 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzWl4tCpursdUvmzJHvSKog8wBbNSDJyy6D8+CqWY+QN91XqxLNE927zO3anwSjDRNATq/C
X-Received: by 2002:a17:906:d967:: with SMTP id rp7mr5415572ejb.68.1598124939125;
        Sat, 22 Aug 2020 12:35:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1598124939; cv=none;
        d=google.com; s=arc-20160816;
        b=q1BmKlh/q7WSo/9gO35/Znu9unOGiEBGG/y7VLDy0AcMIdoFH8UAOLG/tQoXvRyP7h
         +c8W6vxS8BSomjchZXyjgGqoZO4zH6Otatnue5j8A6qCPmyd91GPl6lKdYSprHxEgFeC
         doCmE+WY20RJPQFrLOvdQtl7c3exl618spHNsZVLLFqnWh8PqiUcLrIfln6GSAO3+Ntt
         1TL81vVGsx8zAOLLefjpf/I8N9GSt/6FDg3dNI6DkMeoICBkaxU7Q9p8bRuRC1Ob+g7I
         BKPfl6B0oao0DA0Sr2IjbVNHuRyUCEkIT5pzNe80JA1+LUBjp/aiDvHCCSMyO+dNBrSs
         ucLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=LhNB6AsXzjd7GqIP3ihV5gyhga/IuY8As4f9InkshIk=;
        b=mZY3eZkXkQNwGWfUHdcDqK9xURWWRmZUsBZf5N2XWdVeSAcZ8sp4LhdaN3qN58t6Jn
         LzQBcDt7Xu+wCZW099kukUMJ9oQlGRrU81iVkM05KdwgT9CgYpNfzn0N9uUwyFCkddcS
         UTevf4Fdbjtwa2brdWn2otq1Kb6dKT9T+XDTIX9tn57Jbd8IUwbKvMS/xA1VgsQE/Z5s
         AfgSPYvNvpoQMSsl6f5mlsKd+VI2vaC2Vk69AlMWWsTKAdK0dO3J00mv104CnmcdYb5R
         lQM3hEF9lsbxDA6e9zmXzcGR0fWvWqXoXAnD+JeFdHlKlmwuSFOxi7NBMvMsgqlncYqK
         vmxQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id f16si1490739ejt.722.2020.08.22.12.34.41;
        Sat, 22 Aug 2020 12:35:39 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728654AbgHVTd1 (ORCPT <rfc822;uzarths@gmail.com> + 99 others);
        Sat, 22 Aug 2020 15:33:27 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59652 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728551AbgHVTd1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 22 Aug 2020 15:33:27 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C8CAC061573;
        Sat, 22 Aug 2020 12:33:27 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id C2E6015CE720B;
        Sat, 22 Aug 2020 12:16:31 -0700 (PDT)
Date:   Sat, 22 Aug 2020 12:33:15 -0700 (PDT)
Message-Id: <20200822.123315.787815838209253525.davem@davemloft.net>
To:     Jianlin.Lv@arm.com
Cc:     netdev@vger.kernel.org, kuba@kernel.org, Song.Zhu@arm.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: Remove unnecessary intermediate variables
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200822020431.125732-1-Jianlin.Lv@arm.com>
References: <20200822020431.125732-1-Jianlin.Lv@arm.com>
X-Mailer: Mew version 6.8 on Emacs 26.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 22 Aug 2020 12:16:32 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jianlin Lv <Jianlin.Lv@arm.com>
Date: Sat, 22 Aug 2020 10:04:31 +0800

> It is not necessary to use src/dst as an intermediate variable for
> assignment operation; Delete src/dst intermediate variables to avoid
> unnecessary variable declarations.
> 
> Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>

It keeps the line lengths within reasonable length, so these local
variables are fine.

Also, the appropriate subsystem prefix for this patch should be "vxlan: "
not "net: " in your Subject line.  If someone is skimming the shortlog
in 'git' how will they tell where exactly in the networking your change
is being made?

Anyways, I'm not applying this, thanks.