Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1204546pxa; Sat, 22 Aug 2020 15:42:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyS5k4t3nPfZkWEKIlefMj1xF3mDrlc3Q1B5/Nf1zzs6Bnm4CkaRft3Syufv+RKtADZx9As X-Received: by 2002:a50:935a:: with SMTP id n26mr8871238eda.107.1598136132591; Sat, 22 Aug 2020 15:42:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598136132; cv=none; d=google.com; s=arc-20160816; b=FtnQS/Ic5qaMSWjQEVST31n7uvkW3wy30gPmEahHEm28DqK6kS6BTSb+sBWVp1PnNN 2LyGvvwKxSEZ4Q9YVZj3Py0fvY6MSqx2SjC8OK7BD0AY1tkM0YkVLlkkRKMDlCgFck/6 ojz2jKT4UYLIt4qA63VjJkVJl3wUSQ5tGXtPphvhLZCCsl4UfTK3DjJvU+jQY1LxXK3y pamgqXEaJrXItUyv893O7Incw5IQ+elFKOOqwwTUDVMgtw+MfgUtx+m4Aajsibz7ds1W TPqCBF+UYXVo/7MUFFaXOTyIIQE4b8tHE3RnQoXXPif9KT0yADnhqt86iqqI0ZFwk3hn kxvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=+q8nCecTC7ny1tg3dn9hgsMvOBmut0dwN9vEu63h4i4=; b=mT9MFtMKGF8a/F5Fk0rEO+p5KSFDybY/omnAmkt0v83GYpUloMKPeMR7sGwyse9yN8 iAUtPhwHN+Zs9kHgWwb7aY+erzbddLlNsEEFLsT3Vku9WxAcn0tUcjEU2CNZRXAYIgVf NS/KU8NouAFkhTFoMM+PgUt7ZNkAjhmKUxTIe1+JROLqp6ODRO5PJmjbiSmDdtTYugGg AjzUpSf3LRuUPas/s3FNgJeUcVQhf33cD7UhQo/8V6AghgNKLn9LlF4/dl9dBrqCRhlA c2eykgGbApUovyBFf1UqOLK8t5ovxVoV7/2yw63xxH8VZPh7cfJEazeKhJjRG3lnquir LxuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f24si2271846ejw.458.2020.08.22.15.41.48; Sat, 22 Aug 2020 15:42:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727940AbgHVVZp (ORCPT + 99 others); Sat, 22 Aug 2020 17:25:45 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:36176 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726970AbgHVVZo (ORCPT ); Sat, 22 Aug 2020 17:25:44 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 391521C0BB0; Sat, 22 Aug 2020 23:25:42 +0200 (CEST) Date: Sat, 22 Aug 2020 23:25:41 +0200 From: Pavel Machek To: Chris Wilson Cc: Andrew Morton , Joerg Roedel , linux-mm@kvack.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, Linus Torvalds , Dave Airlie , Joonas Lahtinen , Rodrigo Vivi , David Vrabel , Joerg Roedel , stable@vger.kernel.org Subject: Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range() Message-ID: <20200822212541.GB14071@amd> References: <20200821123746.16904-1-joro@8bytes.org> <20200821133548.be58a3b0881b41a32759fa04@linux-foundation.org> <159804301810.32652.14249776487575415877@build.alporthouse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3uo+9/B/ebqu+fSQ" Content-Disposition: inline In-Reply-To: <159804301810.32652.14249776487575415877@build.alporthouse.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3uo+9/B/ebqu+fSQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > The __apply_to_page_range() function is also used to change and/or > > > allocate page-table pages in the vmalloc area of the address space. > > > Make sure these changes get synchronized to other page-tables in the > > > system by calling arch_sync_kernel_mappings() when necessary. > >=20 > > There's no description here of the user-visible effects of the bug.=20 > > Please always provide this, especially when proposing a -stable > > backport. Take pity upon all the downstream kernel maintainers who are > > staring at this wondering whether they should risk adding it to their > > kernels. >=20 > The impact appears limited to x86-32, where apply_to_page_range may miss > updating the PMD. That leads to explosions in drivers like Is this alone supposed to fix my problems with graphics on Thinkpad X60? Let me try... Best regards, Pavel =09 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --3uo+9/B/ebqu+fSQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl9BjVUACgkQMOfwapXb+vLhDwCgsB41bHFj++LVnm2DkfXOTwEm k7UAoLObJuOLmCfuoVbRfRzOInnL8XTV =ayRy -----END PGP SIGNATURE----- --3uo+9/B/ebqu+fSQ--