Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 23 Aug 2020 11:12:28 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Chris Healy <cphealy@gmail.com>
Cc:     srinivas.kandagatla@linaro.org, robh+dt@kernel.org,
        andrew.smirnov@gmail.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, stefan@agner.ch,
        linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
        festevam@gmail.com
Subject: Re: [PATCH v3 1/2] dt-bindings: nvmem: Add syscon to Vybrid OCOTP
 driver
Message-ID: <20200823031227.GT30094@dragon>
References: <20200821212102.137991-1-cphealy@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200821212102.137991-1-cphealy@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Aug 21, 2020 at 02:21:01PM -0700, Chris Healy wrote:
> From: Chris Healy <cphealy@gmail.com>
> 
> Add syscon compatibility with Vybrid OCOTP driver binding. This is
> required to access the UID.
> 
> Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")

The bindings doc was not added by this commit though.

> Cc: stable@vger.kernel.org
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> ---
>  Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt b/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
> index 56ed481c3e26..5db39f399568 100644
> --- a/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
> +++ b/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
> @@ -11,7 +11,7 @@ Required Properties:
>  Example for Vybrid VF5xx/VF6xx:
>  
>  	ocotp: ocotp@400a5000 {
> -		compatible = "fsl,vf610-ocotp";
> +		compatible = "fsl,vf610-ocotp", "syscon";

It's not only about fixing example.  More important one is "compatible"
property of the bindings.

Shawn

>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		reg = <0x400a5000 0xCF0>;
> -- 
> 2.26.2
>