Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1407487pxa; Sun, 23 Aug 2020 01:32:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyawEYRSxz//sL1frWed+12QG7tgrgcQUuJrxWAef3luaC/s7aP74WSy3Una/TdAqe9vaGx X-Received: by 2002:a17:906:454f:: with SMTP id s15mr606877ejq.130.1598171537955; Sun, 23 Aug 2020 01:32:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598171537; cv=none; d=google.com; s=arc-20160816; b=MY7Fv2dsouE6ooZODO0LXYeRziAJLDihepgfTD9es1Z7Fr2pXWBis0b23h26tbKoDF Kurgq4vawHu+RrgdGqg5rVZcYHYDAXPHJU82jEaH+4piY4fy/YPftyTZ4EbHlcq+CliQ X8g7TRx82n8lZjuodSOGqykt/nzJHNo0WyGELRFSoQ0HtJlHwGrIrQ72XGQadQtSS4Dk lRj8Hmzp1YLCOe8EYFkOHCpDjMiYoWj71OGH2xsT6SVaYfPaMphvjDYcEmc0GaG/WS2V 44O1+TEZhJVX+1s5WxfExHDfMtch1T387AszYSEdjB2o/dUebDwVlOr9Jy50V/Ptzk2S 5owA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=HorE3eSfXz4Gki6guH9XnAbsktXH9J/H5OfUk+fj9ww=; b=XwfMSosV8QkIzzbuBJ+YjyB4L80zw+vTJt4qFY5EclA8r7lu9KoWYS1BYRKwvLSTlB 8hzxZzVCqEQeOdYPsgz7j820p7UavSoMsWf3yowMQq27ThwoKI4fvH35tyvcdJ89OObJ Jxz2tGl/8eApOSLBN0Ek4T4QiUVkytf1YjHjJNbeg6cgduseVL8VvQ/IPfUZXOKyXz9b qdCJb23n9XQE1lOaCwYqkgqQ2VWe4dP07R3rIHWtcqZrZ8K322HQl9gkx3YOJgqhH7Go zDFonHFChRr27iiNJi9RBCJAg6jL8ARqEZwjBn5xNprLNp1DqIK75NCoFYA5BbCQ05DY gHtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=D9m4vGhh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s18si4480296ejh.195.2020.08.23.01.31.54; Sun, 23 Aug 2020 01:32:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=D9m4vGhh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727064AbgHWIVY (ORCPT + 99 others); Sun, 23 Aug 2020 04:21:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbgHWIVW (ORCPT ); Sun, 23 Aug 2020 04:21:22 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11815C061573; Sun, 23 Aug 2020 01:21:22 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id k13so2763939plk.13; Sun, 23 Aug 2020 01:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=HorE3eSfXz4Gki6guH9XnAbsktXH9J/H5OfUk+fj9ww=; b=D9m4vGhhadKVAw7CoQBmjIajZLQNNltNmMM6DDOZqZzdNZoB0yI7WVyi0OXKbppRBo 2U6LWFugxmTinh1FdA5xCI9UPTEb9d5izBpr47nrZeXk5PgTPWzD7GVYmrsS4okAgG4d /dGRUHaoNgNWVzGj0k+3JwnRb+sMi9+b78mT5Rh9y9GVFmnunZAOv928a2ikFBa88CF9 QlxypZvyFajyAPumyDoidP5LkXzxA7T4cLZYDxKZAaIvvfqypORK8sQyKokiJl9OjmAK M677vY1Y6yT/u5grPENUNzXZzL3/Chz0JtqmqZT0FnemSOrSxRGGdqWar6C1MKnybOul cR2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HorE3eSfXz4Gki6guH9XnAbsktXH9J/H5OfUk+fj9ww=; b=ZQ+8omlOopra+WHH99c1tnrdR1/l0REq6Cb4j1De16v0vaTmatLMnjC3l0nLXRhYpT o7/LPGhpcSqUszuYuheZ/TDiY+r9fki3vU4QL5NOeTSDmgRBOCs3RKeDgu070FAtEpPs fjf1B4TCmK66qyZZF+80Tz7iTlhAZhT+hQWhwpVH1h5Dng7y8f/TMTE86I575q/8KSLs /sjGCDjNq0Aqs+CtOwrU+pbTfH1GzPYFRz/0rGKEo98kYa9ny8pq/8z2++K0LYf/ZVVH DLy5Vk/dB5xiM+AEyixtg8QkvC4wWJtdziQeF2PyFngOnDAwNmYWb/0O75A+Fpf0Fpuu 8KVQ== X-Gm-Message-State: AOAM5323Sasrog3SG1e95lRMSegTP7SLgnJ2C6/u5TWQK2R+3jz3OLkO /jUGXjrpM7kW2TklNqkCFZQ= X-Received: by 2002:a17:90a:a791:: with SMTP id f17mr412787pjq.136.1598170881504; Sun, 23 Aug 2020 01:21:21 -0700 (PDT) Received: from localhost.localdomain ([157.32.237.182]) by smtp.gmail.com with ESMTPSA id q17sm7416783pfh.32.2020.08.23.01.21.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2020 01:21:20 -0700 (PDT) From: Himadri Pandya To: davem@davemloft.net, kuba@kernel.org Cc: linux-kernel-mentees@lists.linuxfoundation.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Himadri Pandya Subject: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd() Date: Sun, 23 Aug 2020 13:50:42 +0530 Message-Id: <20200823082042.20816-1-himadrispandya@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Initialize the buffer before passing it to usb_read_cmd() function(s) to fix the uninit-was-stored issue in asix_read_cmd(). Fixes: KMSAN: kernel-infoleak in raw_ioctl Reported by: syzbot+a7e220df5a81d1ab400e@syzkaller.appspotmail.com Signed-off-by: Himadri Pandya --- drivers/net/usb/asix_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c index e39f41efda3e..a67ea1971b78 100644 --- a/drivers/net/usb/asix_common.c +++ b/drivers/net/usb/asix_common.c @@ -17,6 +17,8 @@ int asix_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, BUG_ON(!dev); + memset(data, 0, size); + if (!in_pm) fn = usbnet_read_cmd; else -- 2.17.1