Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1568625pxa; Sun, 23 Aug 2020 07:54:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5MLJ2bnb5hzJShs4uTb3WNb1AL0WjPtXDR7IaXDInFOeL3JmpUdl6677hsmLLmfTIGovp X-Received: by 2002:a05:6402:1e5:: with SMTP id i5mr1577940edy.194.1598194465884; Sun, 23 Aug 2020 07:54:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598194465; cv=none; d=google.com; s=arc-20160816; b=aG6QjTKnyiKaSM05fJv3WGC9QuImFYIxa7V7GsCd+TuSKJjE6UL983ezKWAhhDYhf0 Wq60Atw//Nb7asML4sAB+ukePOrr7Fyu9cOzxqQPWz5qpD3nPMuklvcnkHq3xcmbJsjf 12RrAhWayhHmn+l2YUTOH/CbyqXz+5ye4m4icGMVR4sK7+laC0R6N98GMqa2h69MdLHg eF+w5TN56ztppsRtTm64hVM8Op0mfTOrJeeYP00sz6kCjAGOqMgbJFLXUcErGmVDl7bw vRo21luAOWWpvWf2SuYwrofpiOxcMK+O8LyvXDIV21/f05uwY7tFGPRTg4t9zbSMBIKQ PDiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=AoJGLxZW55JhlY2GEfIz7uu2eAHRtrALRgBzNusjE08=; b=Zy/QaCkccBmIw5rpQB7O09DwY9hSKeMOBTRUUUE/ZMOF4f9aDBiBclaCyMRuZGibAX EC/ETB216U00h44Q83HyVWjyJ6wEtrdGjwazZYQtG+YhSfkHeQo0U1N2gpvKYzwbQlXX T2FXcWjFxtBDfetaH74ISu9ZoLHbWjx+caCtI7SJfn1A+gkwQJBLDhoGlsj9ZC0+Gi4N GvNVd7cWkhzZYE/tGuLbOeZ5ygb64YDyS6Tr2auEYmqIQgjJi9fgxow0zoCsx0GHkDTX 5nKbELz8uwIhXdthBN1R9ehkcnXsn+5rEuEQdB5XiM+JVNp3Ps2fS+mQGih6FL6/ifdN MIbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q8si5007130ejo.528.2020.08.23.07.54.03; Sun, 23 Aug 2020 07:54:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727809AbgHWOgZ (ORCPT + 99 others); Sun, 23 Aug 2020 10:36:25 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40512 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbgHWOgY (ORCPT ); Sun, 23 Aug 2020 10:36:24 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k9r6A-00BN8J-45; Sun, 23 Aug 2020 16:35:54 +0200 Date: Sun, 23 Aug 2020 16:35:54 +0200 From: Andrew Lunn To: Dinghao Liu Cc: kjlu@umn.edu, "David S. Miller" , Jakub Kicinski , Heiko Stuebner , Caesar Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: arc_emac: Fix memleak in arc_mdio_probe Message-ID: <20200823143554.GE2588906@lunn.ch> References: <20200823085650.912-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200823085650.912-1-dinghao.liu@zju.edu.cn> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 23, 2020 at 04:56:47PM +0800, Dinghao Liu wrote: > When devm_gpiod_get_optional() fails, bus should be > freed just like when of_mdiobus_register() fails. > > Fixes: 1bddd96cba03d ("net: arc_emac: support the phy reset for emac driver") > Signed-off-by: Dinghao Liu Reviewed-by: Andrew Lunn Andrew