Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1607489pxa; Sun, 23 Aug 2020 09:15:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8A4kDH3gs02Bk66z6jRVtlYBRReKyF3lovfp/kMFMTKPdq0eSWizSNR1X9WaOIpUpdipM X-Received: by 2002:a50:bac2:: with SMTP id x60mr1956323ede.210.1598199353812; Sun, 23 Aug 2020 09:15:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598199353; cv=none; d=google.com; s=arc-20160816; b=Zi+lfbxVXX0BtY7rlgx2TmDr+OeJJT6rh4MfWPWSvWmZNLNzBUqF8DmSCeqOuvc+NQ mTKMXzEb3dTkkwHkZApReZXxHdQmG7CBPRTdxr2iOsAs+EmejGjVG3ZGZggEwucGuuI7 2O0EXrLZJ6SsyUSbjhpoYM6MCiEu2fr1cp62ygBqqY68tHtTPJ6vrKUg2HB/FF/ATpv1 uBI8/d94ea+iytJ6/CaICoeN2VpI9a0g+PQcufJda7U13yss51caEkEtMsEUhT0nKzj4 uhvPWvw2UcJjGH7EFNOXXcbMVpAe38kGsrp2AhhWjSkcL2PoGc/c3eoox3oFbyShdKmi V6rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=uiIwgoN8j4l1vWIYyI1v/xXd5x3acl1U9/be6Q6vTcI=; b=Tnv9KGlFPru2cuIBqT59D+PDnPtRM4rRQgeS2xDgS+te70Il90RSjiYsGPn7NcpHPQ X8kz5F3kwVvwspTKeu4Ypp+btFELIN/k9pG7b++e6933TTGKpOmkisr4MAN/ux8hQd4G 3+m0pDa5nFiDv8tjAOJwLnxPnJLxX2Fo/KnkRIThCMzQonu5YrPJqBC+Bq6LHViObFs7 fC3TC+Z25C0ay+t08xBOosYTPVEvmJrQfRWPnN+tbn+6UIvVWRvATDJ1bRV076iO3Ib8 s7bD3oNviKklOi+egkbLoK0UkJoPLzNz6ZTMUfnbMuLQYDH8Qk4bdrF3aHQQC0AvnzGn pgOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dU35rCUC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cc8si6004226edb.204.2020.08.23.09.15.01; Sun, 23 Aug 2020 09:15:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dU35rCUC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727949AbgHWPuO (ORCPT + 99 others); Sun, 23 Aug 2020 11:50:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:55784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbgHWPuN (ORCPT ); Sun, 23 Aug 2020 11:50:13 -0400 Received: from localhost (unknown [122.171.38.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 62EFB2067C; Sun, 23 Aug 2020 15:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598197813; bh=B9LTAHlLuLxN0M4KmQQUmWtA81D9H08rXF+h2iRvExE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dU35rCUCQXkJ3T+Hhtw0NBrc7cMYu+4tHq6LJfR2Mvn5JQ+3yccS+nDbh48mYFDF1 1YSB4HcT0SjAPYA35/QSCvSQtvFYzM3mWKdRLFooUWtl0/nqCMTEk7wr3cXDMlwGW5 HmU+oytG9pHtU5XtYtWcLejU0GCmOTjSRURHho0E= Date: Sun, 23 Aug 2020 21:20:09 +0530 From: Vinod Koul To: Sivaprakash Murugesan Cc: agross@kernel.org, bjorn.andersson@linaro.org, bhelgaas@google.com, robh+dt@kernel.org, kishon@ti.com, svarbanov@mm-sol.com, lorenzo.pieralisi@arm.com, p.zabel@pengutronix.de, mgautam@codeaurora.org, smuthayy@codeaurora.org, varada@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Selvam Sathappan Periakaruppan Subject: Re: [PATCH V2 3/7] phy: qcom-qmp: Use correct values for ipq8074 PCIe Gen2 PHY init Message-ID: <20200823155009.GV2639@vkoul-mobl> References: <1596036607-11877-1-git-send-email-sivaprak@codeaurora.org> <1596036607-11877-4-git-send-email-sivaprak@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1596036607-11877-4-git-send-email-sivaprak@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29-07-20, 21:00, Sivaprakash Murugesan wrote: > There were some problem in ipq8074 Gen2 PCIe phy init sequence. > > 1. Few register values were wrongly updated in the phy init sequence. > 2. The register QSERDES_RX_SIGDET_CNTRL is a RX tuning parameter > register which is added in serdes table causing the wrong register > was getting updated. > 3. Clocks and resets were not added in the phy init. > > Fix these to make Gen2 PCIe port on ipq8074 devices to work. Applied to fixes, thanks > > Fixes: eef243d04b2b6 ("phy: qcom-qmp: Add support for IPQ8074") > no need of empty line here, have fixed it up while applying -- ~Vinod