Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 5WlYJUdYwNLXV47jNIpwExsvpgDVhSCLbPKXSJBec8U1XvM5v29rq4zGXgmMiX2zce9dxIYPiC
 Q5CPQj9KBtmBMlEuN0GGRtmmjHP3KQXh/UFvCUJv6a66AshbSdxr8HNEHTWUyV53sEWd9gyCbV
 v3gfUj/MGbBQqHVNbm5HvJOuHM87AwXckM764RV0LXybcs5PeWTunX4+2n2JT7u/ZySBElf/iE
 zoO3EXi0MVdbHkWb186M1uwxJRKnS90ex6gFn92tfVmqXqNwFEgYqsiKC+pQeEmwYPhh0xsYzt
 XME=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     Niklas Cassel <Niklas.Cassel@wdc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: scsi_debug: Remove superfluous close zone in
 resp_open_zone()
Thread-Topic: [PATCH] scsi: scsi_debug: Remove superfluous close zone in
 resp_open_zone()
Thread-Index: AQHWd7sKZy5BiYNcUEKAwI5V0qcAbA==
Date:   Sun, 23 Aug 2020 23:44:32 +0000
Message-ID: <CY4PR04MB375193F975BECD0B5C45C026E7590@CY4PR04MB3751.namprd04.prod.outlook.com>
References: <20200821130007.39938-1-niklas.cassel@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 341ce7b9-b6f9-4f7c-ee07-08d847be7c7c
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2020 23:44:32.8696
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Enu5YEQFag+/1Q7v6wKUc1IHaC+CHODamDPwk7nNKTA9Ie8OCxmqoEo4OXDRdjyv5uAdUfgWLdC+ysid6w5fRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR04MB3751
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020/08/21 22:00, Niklas Cassel wrote:=0A=
> resp_open_zone() always calls zbc_open_zone() with parameter explicit=0A=
> set to true.=0A=
> =0A=
> If zbc_open_zone() is called with parameter explicit set to true, and=0A=
> the current zone state is implicit open, it will call zbc_close_zone()=0A=
> on the zone before proceeding.=0A=
> =0A=
> Therefore, there is no need for resp_open_zone() to call zbc_close_zone()=
=0A=
> on an implicitly open zone before calling zbc_open_zone().=0A=
> =0A=
> Remove superfluous close zone in resp_open_zone().=0A=
> =0A=
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>=0A=
> ---=0A=
>  drivers/scsi/scsi_debug.c | 2 --=0A=
>  1 file changed, 2 deletions(-)=0A=
> =0A=
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c=0A=
> index 064ed680c0530..912d6f4878bae 100644=0A=
> --- a/drivers/scsi/scsi_debug.c=0A=
> +++ b/drivers/scsi/scsi_debug.c=0A=
> @@ -4482,8 +4482,6 @@ static int resp_open_zone(struct scsi_cmnd *scp, st=
ruct sdebug_dev_info *devip)=0A=
>  		goto fini;=0A=
>  	}=0A=
>  =0A=
> -	if (zc =3D=3D ZC2_IMPLICIT_OPEN)=0A=
> -		zbc_close_zone(devip, zsp);=0A=
>  	zbc_open_zone(devip, zsp, true);=0A=
>  fini:=0A=
>  	write_unlock(macc_lckp);=0A=
> =0A=
=0A=
Looks good.=0A=
=0A=
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=