Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2013575pxa; Mon, 24 Aug 2020 02:31:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbsp1Gu/MIMlF7q1Vx1evdNv8yl4bZiV9UbzYEOts8JyV7Dle8sHSFLCDGOrI2hIMdO5IZ X-Received: by 2002:a50:fd84:: with SMTP id o4mr4461541edt.76.1598261499534; Mon, 24 Aug 2020 02:31:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598261499; cv=none; d=google.com; s=arc-20160816; b=qlxk210sGYcvnTm7zlY7Ri78ENdUK9P81jQZTCZKZV/3LT2Ayut3OlqkiZnkqUkyNx OMD2TFNtEThD2nmThw94mSL+d+axXHTKaOY1XP7KLALYOHP46Fh/uR24dct7jMOppr8l T7Ztv5gcDlh0BZj3LUdwyrTvEqZzqfYlCxTWmeV9bEqI5QsxoXaZfiUb3vw0lXZh8njN Qnot9hL0MoRQxxl3piZVuPDVOHiNQIvjPFKLZ4J8BEU7RF2/c0/bUIuJajtaN637913F htCiM5Sm+2jl0TCUXbyqiY8LQh7j1DZHaEcmAOAF5m10DbA5q16dt49eGNbmbxdFeXuQ oLig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:subject :from:to; bh=aJuVOoRHf8zmZBZVIDlRd4JmFREs3gxyA+u73+be0oc=; b=Otn9vbs7tXllb+HLdAwFJpfYPVYaXZ6orumb4mYz+gAwyFePIpZzVpmKElDbCEAMtM UXU9j7j0wMmgDDADjYKgSJ9mJaM6uU7aLhjtjzJabeBMd8SiMQmveCQaw1LxeyDIGizo Mnbj5qqakUJpvX1g8x6bnqewNW4qL1uaKpGxys9/THUKiZgrnYe08+Hpec7cmi7cswkK nV1luW5eZLAMg087vJ4Jo0JJLTMaWY7ynhqvuV2Bf7tZzxo869Pz7Albo4K5kn+xgkgM JynReYbGyKgjIxwHTb/mfooQvL4wipLTMavd2H4eHSLWGkOcRVDJT6xjOXQ3Inq6Bqxt fKhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d90si4974931edd.489.2020.08.24.02.31.16; Mon, 24 Aug 2020 02:31:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728677AbgHXJ2q (ORCPT + 99 others); Mon, 24 Aug 2020 05:28:46 -0400 Received: from foss.arm.com ([217.140.110.172]:57364 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729716AbgHXJ2h (ORCPT ); Mon, 24 Aug 2020 05:28:37 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8CADD1063; Mon, 24 Aug 2020 02:28:36 -0700 (PDT) Received: from [10.57.5.66] (unknown [10.57.5.66]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C34483F71F; Mon, 24 Aug 2020 02:28:35 -0700 (PDT) To: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, ak@linux.intel.com, acme@redhat.com From: Al Grant Subject: [PATCH] perf: correct SNOOPX field offset Message-ID: <9974f2d0-bf7f-518e-d9f7-4520e5ff1bb0@foss.arm.com> Date: Mon, 24 Aug 2020 10:28:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org perf_event.h has macros that define the field offsets in the data_src bitmask in perf records. The SNOOPX and REMOTE offsets were both 37. These are distinct fields, and the bitfield layout in perf_mem_data_src confirms that SNOOPX should be at offset 38. From: Al Grant include/uapi/linux/perf_event.h | 2 +- tools/include/uapi/linux/perf_event.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h index 077e7ee69e3d..3e5dcdd48a49 100644 --- a/include/uapi/linux/perf_event.h +++ b/include/uapi/linux/perf_event.h @@ -1196,7 +1196,7 @@ union perf_mem_data_src { #define PERF_MEM_SNOOPX_FWD 0x01 /* forward */ /* 1 free */ -#define PERF_MEM_SNOOPX_SHIFT 37 +#define PERF_MEM_SNOOPX_SHIFT 38 /* locked instruction */ #define PERF_MEM_LOCK_NA 0x01 /* not available */ diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h index 077e7ee69e3d..3e5dcdd48a49 100644 --- a/tools/include/uapi/linux/perf_event.h +++ b/tools/include/uapi/linux/perf_event.h @@ -1196,7 +1196,7 @@ union perf_mem_data_src { #define PERF_MEM_SNOOPX_FWD 0x01 /* forward */ /* 1 free */ -#define PERF_MEM_SNOOPX_SHIFT 37 +#define PERF_MEM_SNOOPX_SHIFT 38 /* locked instruction */ #define PERF_MEM_LOCK_NA 0x01 /* not available */