Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2016354pxa; Mon, 24 Aug 2020 02:37:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2jMIdy015WR6S7CCJSfHaiOCRtrDx0AOl1Ub89EgR8YCCvGJh2e64S43CBFPyHfSxNVi0 X-Received: by 2002:a17:906:a206:: with SMTP id r6mr4574716ejy.70.1598261879530; Mon, 24 Aug 2020 02:37:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598261879; cv=none; d=google.com; s=arc-20160816; b=RZxKtL+RDqXVmmGfpXR1hF6WGE1Oy+EqvjHatnva0wWejenBAUcq/4jGn7Kkt80P2f apl3WlgR2Z1nnixEWUjVG/XWHYeFNSvITmFf0hfJ157J6MfI+vD0SuCWg3alOje6C74/ nu4KRnA4znxl3QpOqtCYQaaJZwKQOu2IZ2knZOFSJFopq6c89mZHiYtx14U8qPx7xHc/ zrMAn1zFMe7Kx9xXCblDE4Bsxu6/q+pxgQO2TXNR0GhucZEjLAuEC7LBzLIikjQwHiJA rTSfMjNcdi1jfkka8Q6ZWp7cPufAh8tHCtQn2k3eBT0gR9wRDmVYSU/VxreJITWcOsVn VeBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=2c62FwNBS6YhXIYpxTWmjKU5GA/X62+luvLi1+7VjyU=; b=oRMJlowHEMeGRRML5EfUVo50pMnTLPQeZHmr3AS6n8TBCOxIKVUda3Qzi+7bwAtjeE RvqgkNVamAgJOTnL7j3SvgmaUWzlY1xn5k2k/XSO6Jl0SkIkrYLSHK8U1kMOaRlSwyLX H+vnfFslvxD5y6RZBZaok9lPgoCi+1M1yPQ8mJGBkP/gOe9jLLLgwJ3k6h7O7gCZGfdi 30r+u8ep8WbyCZimUKbNl5g59hJfpf7DAdPZm12libRQwSQmPTMPhgZbdaVp8LC2ryjB tJle9yl4dpX5xaBiqJ8xAsrGT8mSxWkgxUZKUHHGIpMFKx+ViFb8wC/RK7s0RTmG/Vrr 7Srg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p59si807664edd.55.2020.08.24.02.37.36; Mon, 24 Aug 2020 02:37:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729606AbgHXJge convert rfc822-to-8bit (ORCPT + 99 others); Mon, 24 Aug 2020 05:36:34 -0400 Received: from gw-eagle2.siemens.com ([194.138.20.69]:11513 "EHLO gw-eagle2.siemens.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726730AbgHXJgc (ORCPT ); Mon, 24 Aug 2020 05:36:32 -0400 X-Greylist: delayed 489 seconds by postgrey-1.27 at vger.kernel.org; Mon, 24 Aug 2020 05:36:30 EDT Received: from mail2.dc4ca.siemens.de (mail2.dc4ca.siemens.de [139.25.224.94]) by gw-eagle2.siemens.com (Postfix) with ESMTPS id 592E1468008; Mon, 24 Aug 2020 11:28:13 +0200 (CEST) Received: from DEMCHDC8A0A.ad011.siemens.net (demchdc8a0a.ad011.siemens.net [139.25.226.106]) by mail2.dc4ca.siemens.de (Postfix) with ESMTPS id 4E10D1552BD22; Mon, 24 Aug 2020 11:28:13 +0200 (CEST) Received: from CNPEK01M06MSX.ad011.siemens.net (139.24.237.223) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Mon, 24 Aug 2020 11:28:12 +0200 Received: from CNPEK01M06MSX.ad011.siemens.net ([139.24.237.223]) by CNPEK01M06MSX.ad011.siemens.net ([139.24.237.223]) with mapi id 15.01.2044.004; Mon, 24 Aug 2020 17:28:09 +0800 From: "Wang, Sheng Long" To: Johan Hovold CC: Sheng Long Wang , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Kiszka, Jan" Subject: RE: [PATCH v3] usb-serial:cp210x: add support to software flow control Thread-Topic: [PATCH v3] usb-serial:cp210x: add support to software flow control Thread-Index: AQHWdscbn5u/RYWMnkqBpjeEIyjP+KlBhWMAgATzlACAAInCwA== Date: Mon, 24 Aug 2020 09:28:09 +0000 Message-ID: References: <20200820075240.13321-1-china_shenglong@163.com> <97836b78-740b-cf70-4803-27305b6e0a4d@siemens.com> <20200824090948.GC21288@localhost> In-Reply-To: <20200824090948.GC21288@localhost> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcejAwNDNjYnhcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy0xZTQ5YzYxZC1lNWVjLTExZWEtYmU1OS1iMDBjZDE2OTA4NjRcYW1lLXRlc3RcMWU0OWM2MWYtZTVlYy0xMWVhLWJlNTktYjAwY2QxNjkwODY0Ym9keS50eHQiIHN6PSIyNTEwIiB0PSIxMzI0MjczNDg4ODE2NTU1ODciIGg9Ik4yT21wR1RxOUxNKzQ2dUl5MXE4QlJMRWtFbz0iIGlkPSIiIGJsPSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1JVRk5DZ1VBQUhBQUFBQWpSNlBnK0huV0FZWmFyOHdMMmVEL2hscXZ6QXZaNFA4QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUJBQUFBVGFuck9nQUFBQUFBQUFBQUFBQUFBQT09Ii8+PC9tZXRhPg== x-dg-rorf: x-document-confidentiality: NotClassified x-originating-ip: [139.24.108.238] x-tm-snts-smtp: D19F5371A4BF487AD73746162E220B87BAA644334B4D139CA133D1D1F789C5EE2000:8 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Johan, Thanks for your reminding. I am adjusting patch according to the latest Linux Master branch. With best regards, Wang Sheng Long Siemens Ltd., China RC-CN DI FA R&D SW Tianyuan road No.99 611731 CHENGDU, China Mobil: +86 15281074996 mailto:shenglong.wang.ext@siemens.com -----Original Message----- From: Johan Hovold Sent: Monday, August 24, 2020 5:10 PM To: Kiszka, Jan (CT RDA IOT SES-DE) Cc: Sheng Long Wang ; Wang, Sheng Long (EXT) (RC-CN DI FA R&D SW) ; johan@kernel.org; gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] usb-serial:cp210x: add support to software flow control On Fri, Aug 21, 2020 at 07:32:58AM +0200, Jan Kiszka wrote: > On 20.08.20 09:52, Sheng Long Wang wrote: > > From: Wang Sheng Long > > > > When data is transmitted between two serial ports, the phenomenon of > > data loss often occurs. The two kinds of flow control commonly used > > in serial communication are hardware flow control and software flow > > control. > > > > In serial communication, If you only use RX/TX/GND Pins, you can't > > do hardware flow. So we often used software flow control and prevent > > data loss. The user sets the software flow control through the > > application program, and the application program sets the software > > flow control mode for the serial port chip through the driver. > > > > For the cp210 serial port chip, its driver lacks the software flow > > control setting code, so the user cannot set the software flow > > control function through the application program. This adds the > > missing software flow control. > > > > Signed-off-by: Wang Sheng Long > > > > Changes in v3: > > -fixed code style, It mainly adjusts the code style acccording to > > kernel specification. > > Patch does not apply. You forgot to rebase over latest tty/tty-next or > linux master. That should be the usb-next branch of the usb-serial tree: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/ or linux-next (or, currently, Linus's master branch). You can use "scripts/get_maintainer.sh --scm" to determine which tree to base your work against. Johan