Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2093057pxa; Mon, 24 Aug 2020 05:06:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyz/Cu86qtDXOIMGv9E9jrxOZfn4t0a61tZofRN3UVdSs8NDA0A/9jR1rAuqGcWObZnVcWq X-Received: by 2002:a17:906:6d91:: with SMTP id h17mr4950664ejt.531.1598270765380; Mon, 24 Aug 2020 05:06:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598270765; cv=none; d=google.com; s=arc-20160816; b=lacMzyKPPFQmJWzIsXdRCBkVn2DFUZIHqxxk3USVSqNz3R8M2glmtYEnmLLkXv5hUR A7OInhvuS8jue0iRm6CEoLx5KoLDoTr0HWNn6xYzdsG3LvZqar2rKaX/+ZaS8LD8AFr7 j5NxtkNbakvK1jo34sm/mvg/Zf3uQ30FlhG09eeV/w2odl8btTMJJozvmXNo0idjrtwB +jvLR/WjldHNFNvmxwLce1A/uY+JD3PaAYgUuYZ+rOXXYYoRdk1a4y/Oq8W1k6m2PyNy 8xMFtUPzsm+WTgh5hy5BqXn5fyJ+xEPD159E7U4NGmTs4DcYO+qto1ya8+eBVRWyE9rs j7nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=JvAhYgDArfu0pdL50YfwluKUoYJZWmt0VRn59qSVqcA=; b=0nzcVecPlVZPAdV9ulRnWi/Ari3DVSk7BtP5B0HBEUV0jY1owro1/zs6n0Sl+GIrOR KjEfviAE7q4wV9mCbKlFeXo51Pkl3JIUOM4Z8Zv8CleR1CDO4UoRpygXvPhXpGX7zBev AWsXEPMS6rSUFmoD1f4H+lJmrnjedtVb30ubfJZtD8lB4PJBf2RnkNBpYy7UvSi4qAI5 ckLJDTNsyQObccKmO8lnyskxbB74caGLNx2ap6MOBHPlx69sjzHzyf7HvL4K9TMdL46d xbnSfZCF8kZZ9IfHQ0lVgaesovG8aghtE0SneGs81F/ho2dACge1kUGr4XvdINvuZYwx 8GdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s1si3665835ejd.278.2020.08.24.05.05.41; Mon, 24 Aug 2020 05:06:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726495AbgHXMEp (ORCPT + 99 others); Mon, 24 Aug 2020 08:04:45 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:45206 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725926AbgHXMEp (ORCPT ); Mon, 24 Aug 2020 08:04:45 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 863A729903F; Mon, 24 Aug 2020 13:04:42 +0100 (BST) Date: Mon, 24 Aug 2020 14:04:38 +0200 From: Boris Brezillon To: Vignesh Raghavendra Cc: Jan Kiszka , Tudor Ambarus , Mark Brown , Boris Brezillon , Ramuthevar Vadivel Murugan , , , , , , Subject: Re: [RESEND PATCH v3 7/8] mtd: spi-nor: Convert cadence-quadspi to use spi-mem framework Message-ID: <20200824140438.14e72ca6@collabora.com> In-Reply-To: <00394d38-20d9-60a5-0068-5f9f023520c2@ti.com> References: <20200601070444.16923-1-vigneshr@ti.com> <20200601070444.16923-8-vigneshr@ti.com> <00394d38-20d9-60a5-0068-5f9f023520c2@ti.com> Organization: Collabora X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Aug 2020 17:14:56 +0530 Vignesh Raghavendra wrote: > Hi Jan, > > On 8/24/20 11:25 AM, Jan Kiszka wrote: > [...] > > >> +MODULE_AUTHOR("Vignesh Raghavendra "); > >> > > On the AM65x, this changes mtd->name (thus mtd-id for > > parser/cmdlinepart) from 47040000.spi.0 to spi7.0. The besides having to > > deal with both names now, "spi7" sounds like it could easily change > > again if someone plugs or unplugs some other SPI device. Is this intended? > > > > You could use DT aliases to make sure OSPI0 is always at given bus num > (say spi7): > > aliases { > spi7 = &ospi0; > }; FWIW, we've added the ->get_name() method [1][2] to avoid such regressions. [1]https://elixir.bootlin.com/linux/latest/source/include/linux/spi/spi-mem.h#L218 [2]https://elixir.bootlin.com/linux/latest/source/drivers/spi/spi-fsl-qspi.c#L810