Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] virt: vbox: Use current_uid() in
 vbg_misc_device_requestor()
To:     Denis Efremov <efremov@linux.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
References: <20200824125330.487083-1-efremov@linux.com>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <4f9ecef2-4ab1-e2c3-b8d4-0f24e999bd23@redhat.com>
Date:   Mon, 24 Aug 2020 16:35:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200824125330.487083-1-efremov@linux.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 8/24/20 2:53 PM, Denis Efremov wrote:
> Modify vbg_misc_device_requestor() to use current_uid() wrapper.
> 
> Signed-off-by: Denis Efremov <efremov@linux.com>

Thank you, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/virt/vboxguest/vboxguest_linux.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
> index 32c2c52f7e84..6215a688edaf 100644
> --- a/drivers/virt/vboxguest/vboxguest_linux.c
> +++ b/drivers/virt/vboxguest/vboxguest_linux.c
> @@ -35,7 +35,7 @@ static u32 vbg_misc_device_requestor(struct inode *inode)
>   			VMMDEV_REQUESTOR_CON_DONT_KNOW |
>   			VMMDEV_REQUESTOR_TRUST_NOT_GIVEN;
>   
> -	if (from_kuid(current_user_ns(), current->cred->uid) == 0)
> +	if (from_kuid(current_user_ns(), current_uid()) == 0)
>   		requestor |= VMMDEV_REQUESTOR_USR_ROOT;
>   	else
>   		requestor |= VMMDEV_REQUESTOR_USR_USER;
>