Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2217348pxa; Mon, 24 Aug 2020 08:18:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTAoYoes1EIWa+ZVUpL18G2Kt3vscLheXsIxXwLtfe8K3hoflzKLxParvjXnzofiM8j7Ib X-Received: by 2002:a17:906:5e0b:: with SMTP id n11mr6340017eju.523.1598282305855; Mon, 24 Aug 2020 08:18:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598282305; cv=none; d=google.com; s=arc-20160816; b=aooShEYkMp6KfsPbXqZj5O65o6J3R0XwRowryilbgAEA3Z8ON5cZERb1Ey+EcyYAU7 sjvMvLrAq9iTx9wxKzG/pCNahMPN6uZ7ITmVXJg558Gcnq0FDqC6Rh5gE5g1jzwaSINi hbFBA7XGBGtXJ9JE2IgKVEc/PA+BxJafWl5SzTfk1w3RnMqikYl7OptY5iaVK/iacZsa oJSK3HjfqlSi3VdwdpR+7CFIRqZZ4qdAzP9P22LgYRPjx0nEK9CKCnpqoEWulwvFiqyf MJJ9f3YnamI9kr+xJPCB+/2LFiWaeTjHNcpRx2ApoMsKWwNLr/hDnTZuvMaQKJNmIpZ4 X8zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Ft6wc5VfTYIAYBRMcefs4v6sNIQDuOanV1trNUY+S14=; b=Qq52pu8RQzQvwkINTs3QVlIsYTNuX3yhvT5mi7dkyJG881+BGhMjoqimf3L3WA3hAo +dNdldbhyMEBRVS7ysZJOCyPR65xWxqeoB7CWrrkntCHrotWKYwGqEuK020lYGkxLmAS tcjTdrMW5p5tHoio0i/ZonX/D5DiCCJ8CCZ8FYlAtMhpq+PVZFoZJwdGkrpaCWp4gOT0 2WRf7XfBuX7Ut1hpgnCA4Qxp6cbCUz0lbQWxtFK0/OTw0aANayo/EwjBQgGnBfdldBuO h3zIUjdAUJt6yB7naG74S1ESHxdPYM4bkZj4D2HjXNcH0rscINy6POp88V5fNGyO2hit SoaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g3si642334ejj.248.2020.08.24.08.18.01; Mon, 24 Aug 2020 08:18:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726413AbgHXPQp (ORCPT + 99 others); Mon, 24 Aug 2020 11:16:45 -0400 Received: from verein.lst.de ([213.95.11.211]:54830 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727091AbgHXPN3 (ORCPT ); Mon, 24 Aug 2020 11:13:29 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 26FBD68AFE; Mon, 24 Aug 2020 17:13:01 +0200 (CEST) Date: Mon, 24 Aug 2020 17:13:00 +0200 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: syzbot , thomas.tai@oracle.com, airlied@redhat.com, kraxel@redhat.com, virtualization@lists.linux-foundation.org, dri-devel@lists.freedesktop.org, hch@lst.de, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, robin.murphy@arm.com, syzkaller-bugs@googlegroups.com Subject: Re: Is: virtio_gpu_object_shmem_init issues? Was:Re: upstream boot error: general protection fault in swiotlb_map Message-ID: <20200824151300.GA28575@lst.de> References: <0000000000000c1f0005ac333382@google.com> <20200824150650.GD21321@char.us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200824150650.GD21321@char.us.oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 24, 2020 at 11:06:51AM -0400, Konrad Rzeszutek Wilk wrote: > So it fails at > > 683 dev_WARN_ONCE(dev, 1, > 684 "swiotlb addr %pad+%zu overflow (mask %llx, bus limit %llx).\n", > 685 &dma_addr, size, *dev->dma_mask, dev->bus_dma_limit); > > > which makes no sense to me as `dev` surely exists. I can see in the console log: > > virtio-pci 0000:00:01.0: vgaarb: deactivate vga console > > So what gives? Well, look at the if around the WARN_ON - dma_capable failed on the swiotlb buffer. This means the virtio drm thingy has a dma mask (either the actual one set by the driver, or bus_dma_mask), which isn't enough to address the swiotlb buffer.