Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2222067pxa; Mon, 24 Aug 2020 08:25:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGfcejVTK4GoT7ErEfVRUmR9dTJZ1XgHMPtlUcyKGyH1jhEezXZ1ZMIh7ObTrB8Jc/Ikff X-Received: by 2002:a17:906:3647:: with SMTP id r7mr1962393ejb.336.1598282731564; Mon, 24 Aug 2020 08:25:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598282731; cv=none; d=google.com; s=arc-20160816; b=jdk5nsWpEhOt7hxTPRiljkXkM3p259jfSItHd9kOAGI7GtFPKuuq4aZdHicUucPopU 41Z/vfTNR9x8VdUyacH5rVJZKzOCvFiB5aW75Z1ukOzTDqN9J/Zlx4YM3URmPtHJOLti KMmpgc7DCLxQvaI1JloGPb6wvyrOkUAgJk4/S5kpREsLyuHSVcNrkU84kyvrLjeACfrc sNKpbo+evNqm+yAjhukLc5MuG/cDuCjButRNJ8QgC+3FRCKPoyvVEeqUihQ6W2bVski4 E/gPPIr5As1k+1O2JP6WAUb+9VK4fJGTx/+t4kqpzSK8suZkHslFTltAcEXEnskOAn30 e03A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GPa/f1s9d2u/PuYPCiIU+4Nee5fNzjjdkCFYgSpocY4=; b=cquB8hWU2mVxYkzxrhXh1QEqOAhGWYZbu8Om9uEIkUvJXqNWa4d15epaRybSqiWgfQ CXy++ihMTU3ArgzzQFkXFIe4v8QS4UUPJ8FXEKfHT4JyR36sZIfDfB8Ix8UfTll4fTuw WnmVAoRdtZ3MrC/HYBj59f2vXg/V6d5kJr1c8a9XMls7Xh8qFD1qVFi0wPqnt97/WPFN eOmuCRFDzWDIDBVpJyf5Cc3kFH0uV0JgxibtwRuyjLOEFI+enaE3OA9+KrNV69I5NLft 53ekOV8bMdq9BMCnA/8C/yq5JObUbPQHuytU1aqCH6695CmLZno7JmsX19WCJdgIwsG4 gCqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=OmmOLV8x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b33si8180277edf.62.2020.08.24.08.25.08; Mon, 24 Aug 2020 08:25:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=OmmOLV8x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728014AbgHXPYP (ORCPT + 99 others); Mon, 24 Aug 2020 11:24:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727835AbgHXPR4 (ORCPT ); Mon, 24 Aug 2020 11:17:56 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58D55C06179A; Mon, 24 Aug 2020 08:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=GPa/f1s9d2u/PuYPCiIU+4Nee5fNzjjdkCFYgSpocY4=; b=OmmOLV8xzcX7qqjpLomJ8zGwQd z2K0FTYxiyLFlVv+FLrifaHYjUYOlUwJD2Kko0doP0aDjPHosbMMmq+hlzdZix9Azb5uij+QoPiJC W3ofjxVxCXijvp+O9eSARifw4k1xAUcjaJuSm5RG5cug0w/Jk4Lu4l0qQfiGglAhwbgFN6UmsWqAL MXkLeoaN+cbt7rsRo3/cahvkpPoYNz2fKN/hIMWsBXByUOKAWcj5rQkhEfRUE2oHy5zw/6KqsdQ1z bhJ+yMQ4Lypok8ULGhOmwoz8rM0jgOtHJLg9hF8f0DF4soyq6nhppYCxTsYiaWqbFPYDHrFsMiQei w5ieW9rA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAEDZ-0004Dt-Dq; Mon, 24 Aug 2020 15:17:05 +0000 From: "Matthew Wilcox (Oracle)" To: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , "Darrick J . Wong" , linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: [PATCH 10/11] iomap: Inline data shouldn't see THPs Date: Mon, 24 Aug 2020 16:16:59 +0100 Message-Id: <20200824151700.16097-11-willy@infradead.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200824151700.16097-1-willy@infradead.org> References: <20200824151700.16097-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Assert that we're not seeing THPs in functions that read/write inline data, rather than zeroing out the tail. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig --- fs/iomap/buffered-io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 52d371c59758..ca2aa1995519 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -210,6 +210,7 @@ iomap_read_inline_data(struct inode *inode, struct page *page, return; BUG_ON(page->index); + BUG_ON(PageCompound(page)); BUG_ON(size > PAGE_SIZE - offset_in_page(iomap->inline_data)); addr = kmap_atomic(page); @@ -727,6 +728,7 @@ static size_t iomap_write_end_inline(struct inode *inode, struct page *page, flush_dcache_page(page); WARN_ON_ONCE(!PageUptodate(page)); + BUG_ON(PageCompound(page)); BUG_ON(pos + copied > PAGE_SIZE - offset_in_page(iomap->inline_data)); addr = kmap_atomic(page); -- 2.28.0