Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2388406pxa; Mon, 24 Aug 2020 12:44:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpy3nKeiGfrsTPmber3NTuWONGQnCSiZ1h8qxRsiWiLicyc7neV4+y+SAgKexf+iNST7dp X-Received: by 2002:a17:906:2349:: with SMTP id m9mr6985462eja.425.1598298283661; Mon, 24 Aug 2020 12:44:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598298283; cv=none; d=google.com; s=arc-20160816; b=QYHjL393BL2sR3v3ysAVgLlN4lQp8BtTZi/O0KKXfk3iw0lyI+CLeGhAAQr0ZIUzQZ hpPVosoMKBUyBqbINRLyaNb+7FOn6+eoLvb8z2mh0C69t5vEWgI+lQspX1Tl6RjysQey i1gaU6lfXYW6o1vaemxNKg/icu7Hsr9BELvxAwHrZFZmBvT4zfOH8r9BCuctDTW786OB KuFVPdUV6bjhtYSTd5Ei2po+NxO3QWsdIUFVfGis6mbVl89pgAtk0GtdMECKI/DDEAk2 M6GqL+ft8mQd+R1lpnAormEMMYosjVYnEGvWDlpzd1Vpyl9+KwhN+cC6ZEeXHV5B7ifM Y8OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=AzOJico8/qMqh5XrPOsBzo3DODlYYxJ8T6teXje2stc=; b=bPM73fhrwy1mMmyEyCyKrdXSsQccVykr4jEdmGuHcctuHUA5bth5JPNlXzPQRS3WJz pOZjiIlZW6ewCbRsw6gFC6BB4hjJpeyzxtcAOz520W/kuSv+kR3AcEzePXd+qgJYamNz gSKulhRlHyAdeuNamvQWY0ITtQYeFiq5TJ0BNcszZNUHD3bpUEXLerDqIaqcy5xegol8 5CVWPf9VNWpVb7dujNNI07JiWeCxM+yz2AY2aJgo5Vz8OKLH5Jt1uANuS6Ztr2g6E1cJ Txeg9LuH8ieRobOIoEstSrixERYQv71+OLUlY8u05TnPBAC9uFbFkAh4JTUq+C49lFbU sC2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=j5cAOFhj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gv9si1152780ejb.192.2020.08.24.12.44.19; Mon, 24 Aug 2020 12:44:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=j5cAOFhj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726598AbgHXTng (ORCPT + 99 others); Mon, 24 Aug 2020 15:43:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbgHXTng (ORCPT ); Mon, 24 Aug 2020 15:43:36 -0400 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6F1AC061573; Mon, 24 Aug 2020 12:43:35 -0700 (PDT) Received: by mail-qt1-x843.google.com with SMTP id y65so749250qtd.2; Mon, 24 Aug 2020 12:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AzOJico8/qMqh5XrPOsBzo3DODlYYxJ8T6teXje2stc=; b=j5cAOFhjod3Jr4iibRyDFaFNcAGyUZV4DEIiverC/4HNQKQ4AlEFy19TPJLBIVOPJ3 F6c92KKdQrQharBINQ+/EozCRZ6tiXj6aluWbEjFeytQhMSEt6/hnZGVtxipX5DiyYGl riipWPFZvjzCtoUZQOksGIXpEmjfTetgDKOaVsnpUsfBDY8GugrNlaYKrpXhfhCeJLRN mWhRZ+krwq/fVUIt7pkITmZ1Gnq0U8+YzkwdSA0Gh9DwIH3IQAAC9Mr1nXIggm0UxiRr 1QdIqijmey7tgK+hXWBve5fY8X7KHN+iB4Qtx0mYAhrMztCvVKv8qcpzTALyid7FqpN0 dfvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AzOJico8/qMqh5XrPOsBzo3DODlYYxJ8T6teXje2stc=; b=t028sGzs8EYoeUmjBAhtQaNAMcOMGhRbF7JZYXzRhi7kMFcgiRXl8CAa/wVSVOB4KQ o6FH6QIy3n/Ri48lsutTmnoOeM5VEKpK/p4PLgn32svWm7BJ9REIMiilbf76sgA3nf1F VU8SGL9W53cXHfMCJOTsQo86Oy6T6VdoIaWdKkA4eCvhUV+AT4jvKbGfUXoFZQJNJGz1 jkjZJFVf06nQDqh3/T5yoZtt1FxHBMvCm0Un8hqkxlZ/5YNF9TOnLah9nLgQZDCMykQM Mv9PlhFhGmO8gSGWYNxSUS5Ki4Vr4xn7BSZbEP+dkjXkA71xTg/0VG8jM8Xbmr4T4OMZ 7gdA== X-Gm-Message-State: AOAM532XzWB2//B7T18KacHSryekTaeKBeaZEvD8OOaK/VHFZWTkqZhC uaB0Ov5NKI8AmlUlayiEgkA= X-Received: by 2002:ac8:2a6f:: with SMTP id l44mr6324506qtl.278.1598298214884; Mon, 24 Aug 2020 12:43:34 -0700 (PDT) Received: from tong-desktop.local ([2601:5c0:c100:b9d:e9aa:e42d:21e4:5150]) by smtp.googlemail.com with ESMTPSA id c9sm10085584qkm.44.2020.08.24.12.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2020 12:43:34 -0700 (PDT) From: Tong Zhang To: danil.kipnis@cloud.ionos.com, jinpu.wang@cloud.ionos.com, axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ztong0001@gmail.com Subject: [PATCH] rnbd: fix uninitialized variable Date: Mon, 24 Aug 2020 15:43:22 -0400 Message-Id: <20200824194322.337375-1-ztong0001@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org variable err is uninitialized when bio is an error code Signed-off-by: Tong Zhang --- drivers/block/rnbd/rnbd-srv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c index 0fb94843a495..818eff323825 100644 --- a/drivers/block/rnbd/rnbd-srv.c +++ b/drivers/block/rnbd/rnbd-srv.c @@ -149,6 +149,7 @@ static int process_rdma(struct rtrs_srv *sess, bio = rnbd_bio_map_kern(data, sess_dev->rnbd_dev->ibd_bio_set, datalen, GFP_KERNEL); if (IS_ERR(bio)) { rnbd_srv_err(sess_dev, "Failed to generate bio, err: %ld\n", PTR_ERR(bio)); + err = bio goto sess_dev_put; } -- 2.25.1