Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2391413pxa; Mon, 24 Aug 2020 12:50:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy15QU0pBvOCmhD9SUgu0576CmxK7oR87Oio0k0oYV9u55RSM3DrM5cqkQlta3aSs+15WST X-Received: by 2002:a17:906:f0c1:: with SMTP id dk1mr2157020ejb.44.1598298650188; Mon, 24 Aug 2020 12:50:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598298650; cv=none; d=google.com; s=arc-20160816; b=bHraSauXl3eF7CrK74ZzvtmGEDSHK5upG3PSZ/BWXX6/3oI096IFIT9qwJO7rqdpsE yH03L9eVxUAkSmNJayr8p9LWa0ndIQKlWandzNLhNzhSDwfcM3CnUD47/OIlp5PgZHT+ tb8fL1N2fJEjw59wDUG1HRf7qeK+1qdjKyRp3sVPyg4gADB04yMm3BJPJ9Q4T3wsJTE5 Ju81MKHn2rH4FmT4sSbUbpQesVUw4csYGN0hSpxVfsiuact/R8LQRdLKuKDovxjLvtAH Tf8Yfj6xrF/C0xuEL2Ay7e/nm0de1uHF15tVPJ61TQCjYUt/9lK+MV8a+iFV6RyMDO8m JzDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=plOSeJr9JbCX/G7XioOegDbHP0AUWpDmZ+AWPNX08Us=; b=qX/kman4gbf52C5c4FlCD5vDAvaIJO4HEwHHZrZ9klC6cWqAZnM2xwMFCVbuPU6IRR 7LH5OJYvreGgGOtiO/741K9YQeL4q1vFwkPfwua56tmOpJEQSskWGESbD6pTkFJhg2uk czwRaMOJXBGqRUF6SZbN28JsyOEvZY0mGEjWmhfOvl5z325KBAX3QRRgiAbVRNz7JSlG zLv/dLab/6CGOjlWuE7AYG8uZcuS22yBjbw6cO7TJBiVqEBQMwiCKNnnBddK9v+OC7JU rcHDiukYqvdxkeUj+I2gcFAFzqK7DoYb+t3OedC2uFsHhHmdR/rHdKgffFJstlQc750H AmIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Es/OR0qt"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bm16si7626251ejb.525.2020.08.24.12.50.26; Mon, 24 Aug 2020 12:50:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Es/OR0qt"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726541AbgHXTrD (ORCPT + 99 others); Mon, 24 Aug 2020 15:47:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbgHXTrC (ORCPT ); Mon, 24 Aug 2020 15:47:02 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD7EAC061573; Mon, 24 Aug 2020 12:47:01 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id u126so9959274iod.12; Mon, 24 Aug 2020 12:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=plOSeJr9JbCX/G7XioOegDbHP0AUWpDmZ+AWPNX08Us=; b=Es/OR0qtgjM2R2DENxTrthzTAgIsD/sruK0Tr3HWZIiM0DoftVL5QVAGhH+k8oaPRN oCycgNP5ueJMyg+Bm6i6qOsxxMJwm1F52m/f1P+l/djMEjADyaFr1L7TnTcJ/zLRB7LK 4WkpTkNd/b405luQUa+Y+fAGNHEHXnIdrX2D7+xwwPGaH6YkVLB1IPdQZZRdLu+dEqfC NpCwdxTT4W403uS5yG31z88spS7F2ozRVIzv9VyIISKMPMsm/mU+d0GyPaS/TM3Zzj5I QUUEz23TleayixgylvRtnZUN8WY8Om61UR+xFnwQgMFfoJ78z0QN2mHYXRdRF0jC/+m5 mCaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=plOSeJr9JbCX/G7XioOegDbHP0AUWpDmZ+AWPNX08Us=; b=MpE9D3GMlVBWQextK5WcEopJhhUnSYNXC/2S3IP0CJl6pkBo9+PZQkwzXBKi0G9ZtG OV9dtB4CivumP4Pdc3+7Dk+HZziUP9rJWSnF8QrdqGXok0VV8n/Ik1dfPuYsOhzJLx51 Io1HYS+sY/5UpbgkAjy4ju6LLob4kjj5lsZtzYrxxSMyYh3EafwCCLUAe2PvC/id+F2o hYIdikWDAy+gs7myq7b1G3AbiYOiXW7Bloll4wUrCZg/nq9JARZb7wNuuvZSOJBbpYuL ht2NZc7C/ExdJ+59SFZjW5/fvxQtIaP3TgFfJr9KgRN/Cxv4XcNwil3STi+5MtzwZmMV BYhw== X-Gm-Message-State: AOAM532gtqH1t4Q3xapv10RiXYv8XUgN1eXRwIEw1iHZMk7gCZI3ccUS PPULOgJs0Kxc6EYsDA042loREWiDp5b2jfkZWXQ= X-Received: by 2002:a02:82c3:: with SMTP id u3mr7153952jag.81.1598298421260; Mon, 24 Aug 2020 12:47:01 -0700 (PDT) MIME-Version: 1.0 References: <20200824194322.337375-1-ztong0001@gmail.com> <3b904063-ca08-092d-a861-e1c80d511ab1@kernel.dk> In-Reply-To: <3b904063-ca08-092d-a861-e1c80d511ab1@kernel.dk> From: Tong Zhang Date: Mon, 24 Aug 2020 15:46:50 -0400 Message-ID: Subject: Re: [PATCH] rnbd: fix uninitialized variable To: Jens Axboe Cc: danil.kipnis@cloud.ionos.com, Jinpu Wang , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Got it. Thanks Jens. On Mon, Aug 24, 2020 at 3:45 PM Jens Axboe wrote: > > On 8/24/20 1:43 PM, Tong Zhang wrote: > > variable err is uninitialized when bio is an error code > > It's fixed in Linus's tree: > > commit 17bc10300c69bd51b82983cdadafa0a7791f074e > Author: Nathan Chancellor > Date: Mon Aug 17 23:49:25 2020 -0700 > > block/rnbd: Ensure err is always initialized in process_rdma > > -- > Jens Axboe >