Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2398312pxa; Mon, 24 Aug 2020 13:03:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxb+BZwebtKQ8oNXi6yayRrr1xL7Tih1tdC3z14yiYzZpLWybhGXfVHE2x49WuVLM8J3PZe X-Received: by 2002:a17:906:4089:: with SMTP id u9mr7443776ejj.235.1598299434460; Mon, 24 Aug 2020 13:03:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598299434; cv=none; d=google.com; s=arc-20160816; b=SB3AWFqfkytY5rL9MLjfH3D71Mh9WqjQrToKgefoEi8jg3jd3gEctyQlzRlsAA3kUF qks7sqa0F96BoWYdKCs2KTN2rUyBaKeqmFG0XNwfTFFKPG5IHyIOf8VoUi/v7x72nupx uzROpD9UGEKsgaY7CMaHaQCxcRzvQrwGvMs0XJDTj6zAo6jpbBviMPITtIRXDYl0VO9C iMqc9Rg384xnL9rJ7pOibs5pEr/0OPYXUNvJPESiqiuIfnjijE38T/4Rcv73yAf8rnCn g98yRynpfFj+jypy1+TFNELh7Jwu/VX+20jLu/jhuhBD4+c7fexyGRuigseHHTXzm2Ew xZjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=C8lKf4ORmfqEPGg/u/S9g7wmze0cyqq99uKDJUmoY6g=; b=niyMd1aEZzxie4hw2RdovqH2jsaDLp9R1d39EHD3nGJ1bxP+X2e5EMgEL8Nglwa3u9 YhfrngkRuAL7ve/GNjTmCTC0Ru8L3rqJGYO3imYQ4L8W+qSs9R4z9GTQTNbl090h9sIc Ee7g2mz+E0SS5XExB556zD98iUWNDoCEpvePZO9mSMd6xp9RMrroPvGcbRgbYd5XpqmV q/0hpZ6VOYnJH5aKuTyBIWSknAA2zmZXlr5pyvRSa1IZUKGTSbICwUVImCJssTbXMEEO avK7TdqGkdIJR/nHlSj8qIym4C5p6THVqMDULfk8C5A5NpmPWsC5uKyqhTcVqfysh0DY kh0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=sxS3hCoq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cb14si7233397edb.325.2020.08.24.13.03.31; Mon, 24 Aug 2020 13:03:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=sxS3hCoq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726513AbgHXUBT (ORCPT + 99 others); Mon, 24 Aug 2020 16:01:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbgHXUBS (ORCPT ); Mon, 24 Aug 2020 16:01:18 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 273E7C061573; Mon, 24 Aug 2020 13:01:18 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id i26so9208064edv.4; Mon, 24 Aug 2020 13:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=C8lKf4ORmfqEPGg/u/S9g7wmze0cyqq99uKDJUmoY6g=; b=sxS3hCoqrdvLAzjdfIC3Q8aHGfsiccjZ3yuleXvJF78H8hcuJow6cb7aurAtd59Bni N042Cqv7KgPT+kfvm9k2B3r/1A7SEREtCarU4MNMBilQCerdh+pxWKRz3lQIkfcjZD/N jykow2vv7cUUdA92oQPqrRGhTVOfqKi+BJbIx1cqkrucrr+VFdlcwi1yhzeBXnl5odoU AGBW93GD2WV52VC8JXJlsbFSnIJ9hc5KNbX/F8v0EbYuC4lPRNz4zwcloS+iNcSBSNUh BpaZxm6Dx7ynVdu6B1CFGbfu6u9DAGLn9/F1mtterVW1bRL4OkJMq9U6n8CGMs/W73Q2 m4MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C8lKf4ORmfqEPGg/u/S9g7wmze0cyqq99uKDJUmoY6g=; b=YblAdF2HeoTyHJnWP1XdjpFwoCZmtww4A0/N2V6nFIngMwPCDL54ZZcCr0Btcj7DOY HmxvNnHJ9tJAsDs1vrIYpA4sBaL2g7wtQhz86pehQOM/XQOF3dnuDa9GW7wxuVzgXEDa fw/ggPKNjh1TTedNLndrdWfoZEk56Gn8CwjdDtk1lkxVMnhNBzkAhhQIjetcMHHpNu5F GLZAZc7rkli9lAGRBH8nIQvWYtJ2zEvYeg4MESEO2zowChnnmD6NwjvAZvvdwf/EAa7h 08Mr8sI3mCnzSJlana2HbGI5O5IKgxes/mpfAuh5bFbQ+XU+cD0o6kLcDMAuXA+X9QIG LKOg== X-Gm-Message-State: AOAM533c+FaqkNzAJdMOoIhkwitH753LoHNAWpfrCQ/v5VgThBqw9frn Trnz+rM6vtOKcNwdYmUPY1/LGyjimso= X-Received: by 2002:a50:8f44:: with SMTP id 62mr7338692edy.3.1598299274966; Mon, 24 Aug 2020 13:01:14 -0700 (PDT) Received: from [192.168.43.227] ([148.252.128.110]) by smtp.gmail.com with ESMTPSA id u10sm10295771edo.14.2020.08.24.13.01.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2020 13:01:14 -0700 (PDT) Subject: Re: [likely PATCH] media: lmedm04: Fix misuse of comma To: Joe Perches Cc: LKML , Mauro Carvalho Chehab , linux-media , Julia Lawall References: From: Malcolm Priestley Message-ID: Date: Mon, 24 Aug 2020 21:01:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Good catch the interrupt URB is not running because usb_submit_urb is tangled with it. It only really affects signal strength. add Fixes: 15e1ce33182d ("[media] lmedm04: Fix usb_submit_urb BOGUS urb xfer, pipe 1 != type 3 in interrupt urb") Cc: Regards Malcolm