Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2399860pxa; Mon, 24 Aug 2020 13:06:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsAx5CcEdx6LP1swzoxDxTn0oXbycB66BD0Hp5+psTzk1ohNZgaVcgDpfx/WWrEAIX0ZNm X-Received: by 2002:a50:fe0a:: with SMTP id f10mr6851595edt.264.1598299579915; Mon, 24 Aug 2020 13:06:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598299579; cv=none; d=google.com; s=arc-20160816; b=lsnzGpaWuLI31UiBVEpLgZPe5ETbsMk6u9grrtS/BzpA15E51OTfe+Ir6g3W/QN4RD 5VYyKPG+NokFTZO3h9/HU9lqAucGVeGihZNrE1uU63Eed8H531JRHMwazLJVOYgIdKo1 mdwE+1VVg/20LSCkCC4Hi0RJBOBBAGtBaBi4PJKbRWLlKkoYonFqdyTNcxe/P8yOxQG4 TqGA53axMNeLsHuRJmzVRssEu4eIZNRyZ4oY9WrgsO1PSPrKNDEeSgJ4DX5oYMMCZVjz Pees4yAUrUvhBpHosW4bV5HbX9OhsoSY621jhezO4uAI4iKSO8xKkem/HoCxLSR8Fji8 HSxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=ceAFY4V0L9FeKzdnMeWapnb0HnFMpOfFLJaJ1yKSjR4=; b=nptUAPPWcabsMPALymOSOw0wEpCPWB/i0EkfNxJVUf3OYtFqIunjBvtl7eabxndAzZ gxhdHAAh+IRPco+UbPm55FCoR/yGbu3mK/+0HXIlDuzLpviULAwL9Aa1xI1xwFfU1fv2 43Pg18XjqYsnIUZMpixJLDqJRSBRqxsdiWlON54mNho1VJwxYtbVtnuq2XnYBOxk5pQm ouZFYspmQQii8CKsVo6fLiZj5ECuR/5iBiqU932olUW5CEIKYDQjFkQO9LsWxq+u2Aod c5gpjQm+Wgci3Tav1cqF6PUxhYS7zWrm3ZCgO6FNkVJAB7tWmd0MEamMe9As4BlRa07j pS/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v19si7597234ejc.260.2020.08.24.13.05.56; Mon, 24 Aug 2020 13:06:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726856AbgHXUCb (ORCPT + 99 others); Mon, 24 Aug 2020 16:02:31 -0400 Received: from smtprelay0247.hostedemail.com ([216.40.44.247]:53332 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726241AbgHXUCa (ORCPT ); Mon, 24 Aug 2020 16:02:30 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 801F0180A9F52; Mon, 24 Aug 2020 20:02:28 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,,RULES_HIT:41:355:379:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2904:3138:3139:3140:3141:3142:3622:3865:3870:3871:3872:3873:3874:4250:4321:5007:10004:10400:10450:10455:10848:11026:11232:11658:11914:12297:12555:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:19904:19999:21080:21451:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: front11_580342427055 X-Filterd-Recvd-Size: 1408 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Mon, 24 Aug 2020 20:02:27 +0000 (UTC) Message-ID: Subject: Re: [likely PATCH] media: lmedm04: Fix misuse of comma From: Joe Perches To: Malcolm Priestley Cc: LKML , Mauro Carvalho Chehab , linux-media , Julia Lawall Date: Mon, 24 Aug 2020 13:02:26 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-08-24 at 21:01 +0100, Malcolm Priestley wrote: > Good catch the interrupt URB is not running because usb_submit_urb is tangled with it. > > It only really affects signal strength. > > add > > Fixes: 15e1ce33182d ("[media] lmedm04: Fix usb_submit_urb BOGUS urb xfer, pipe 1 != type 3 in interrupt urb") > Cc: If that's a request for me, I won't as I can't test. As the maintainer, you should do that.