Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2513505pxa; Mon, 24 Aug 2020 16:57:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzhZ1k51R0DVTijbSiYgX6eOuWaEn17DbMPF/S+QhRi7kSQTozsYYnfuFB8ybRPUuotIlP X-Received: by 2002:a17:906:c294:: with SMTP id r20mr7737070ejz.280.1598313427056; Mon, 24 Aug 2020 16:57:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598313427; cv=none; d=google.com; s=arc-20160816; b=s9yuU8IjAi3xwQmtaYtGe4USXrEOFCC7IBfENWvSwhsH2azWCrL+dERid/YAqyWA/P BTK2OWlOFNvr9hylax/4hbFTlXxSsYFge3CmQRPBVtns4wiQg1X4ohTlATbZl1Xbc26n Gi6GN8R9Ptn/ZF8gqOrZ6x/CjjXWQNectZVZzKM2HwwsIKkfA53yv7TCMjeVp2KOQa3y VYYS1Qkk2r0WcoUp3c8XfnQxzclPV1+mKAraOtTE/UNfA8uigYhBYYKsSsVx54tJ3N5f ORYzgw1GoOpqXAU8vUu+nR6l1/1p2VParuKYEEUKxe/fMEwqmVTooEa0aiPU4X2dKXhA Vzzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ujWCjcSR/bAZg9MwcscRzHtuycpqFdL16XF+IQprx/U=; b=aTNmx3/bTYcMg5i5Z8GUkdOaRJ8pFJEC75pO+uHSmvMSuYS+9aij09ElUvzXfzyuXf mtTLfFWs/8Inv+CJojwc1Ia8mUHMcPIf0AnMhNlFmk5RqO0O7Sv3ihpwUuTjiuO4bteW EQMXmfoKOgXb7r58FtW1p30XKbBEZrnJaPOx7ZNbPZOtwJuHdatgSlovkNbiw0s7M+nS Hs12Jpws0p9YFz+vBm+LCg1mZIwDcuEBMH8v9QbDXdnDPDKGvCrtulH74x5UVNfhJr82 eObTcseeCXielGhMd4tz0ne+qQDPYNjGH6L7LStcuZuUfMbbuz5+g+ljB/QS7EShNVBX jRjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ce15si8290288edb.291.2020.08.24.16.56.43; Mon, 24 Aug 2020 16:57:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726889AbgHXX4J (ORCPT + 99 others); Mon, 24 Aug 2020 19:56:09 -0400 Received: from mail108.syd.optusnet.com.au ([211.29.132.59]:39941 "EHLO mail108.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726218AbgHXX4I (ORCPT ); Mon, 24 Aug 2020 19:56:08 -0400 Received: from dread.disaster.area (pa49-181-146-199.pa.nsw.optusnet.com.au [49.181.146.199]) by mail108.syd.optusnet.com.au (Postfix) with ESMTPS id 591AC1AA954; Tue, 25 Aug 2020 09:56:05 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1kAMJo-0005hi-Lg; Tue, 25 Aug 2020 09:56:04 +1000 Date: Tue, 25 Aug 2020 09:56:04 +1000 From: Dave Chinner To: "Matthew Wilcox (Oracle)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 3/9] iomap: Use kzalloc to allocate iomap_page Message-ID: <20200824235604.GD12131@dread.disaster.area> References: <20200824145511.10500-1-willy@infradead.org> <20200824145511.10500-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200824145511.10500-4-willy@infradead.org> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=QIgWuTDL c=1 sm=1 tr=0 cx=a_idp_d a=GorAHYkI+xOargNMzM6qxQ==:117 a=GorAHYkI+xOargNMzM6qxQ==:17 a=kj9zAlcOel0A:10 a=y4yBn9ojGxQA:10 a=JfrnYn6hAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=Eo_zldZ1eKELjHi0JfAA:9 a=CjuIK1q_8ugA:10 a=1CNFftbPRP8L7MoqJWF3:22 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 24, 2020 at 03:55:04PM +0100, Matthew Wilcox (Oracle) wrote: > We can skip most of the initialisation, although spinlocks still > need explicit initialisation as architectures may use a non-zero > value to indicate unlocked. The comment is no longer useful as > attach_page_private() handles the refcount now. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > --- > fs/iomap/buffered-io.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) The sooner this goes in the better :) Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com