Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2514652pxa; Mon, 24 Aug 2020 16:59:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzeIz0pcVverOz7kFkc/wZL3zr7+7MtOtpVYs1GZtNyCsHMI3DFv0hVF4lHEBHxP6RGr5y5 X-Received: by 2002:a05:6402:2057:: with SMTP id bc23mr7813331edb.179.1598313599067; Mon, 24 Aug 2020 16:59:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598313599; cv=none; d=google.com; s=arc-20160816; b=XoUqNyfMUdH+4hRyxsBYc5fYQAk7YX8awy8rpLgscnTXt6lqqzJrWTHBww4SH3fYwv XnaBGlkO2mSOHo2bVWCe9QIYygybjkVhIBFOvTwSttMr40nVHPLg8uJdYYfyzBy70uO3 Uwif4eivwydr5ZLcfRWFBRD8ZrLGA6btI8rIqiXqoc7QNDxD2KbBhzL1k71PWGP0fgJQ DkQF1blMZFsQ2AOYGYpir3vKJ6/BP4BeyTrAF7zTn2ovZO2h8ccPHqBUZRnEzEX2rgjG WZJafKebN8FsJA2r2xpC6l08Kl4HW9ZXTI41xFs6lhu/zrfEaolQ0v74uMjtyxHza4OX Ow5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=QFFIM91Ac1O+6m4Mayr/LQqvYRGRs5ILrQGeqvYl32w=; b=M//OFvAfmtUDMLgzJ0VsAXmD8QWjTNl8pm8mvo4wIDmdXdoPyLkrXN2aLENbKk3OKr +/0rq2yXca1BaVBIQdhNx+5Vc07Xva71Y5ytpC+zFr4viDCbHbwTpt+GGJzrfWgY3Rh3 P0FubAGK1P+nTGniH82Q4s5RniBCPY075O9GeTzLlpSaxYdC66GD0vK3pcvNGL1NnoXM uruqRrmhKGHZJ9kDZessNGL9jo0DmH3poYKjn2JCt2tUqrDf5LAFSSmHfg3IPBh2ym/T d3dlgE/ckDE6cmpEIG70uNgWCR9gr3zoEVq1ZBc6aNqvLhG4DZ4UuO002ljfJcOyyHqz sw+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i6si7493667ejc.494.2020.08.24.16.59.36; Mon, 24 Aug 2020 16:59:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727021AbgHXX4h (ORCPT + 99 others); Mon, 24 Aug 2020 19:56:37 -0400 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:33098 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726218AbgHXX4h (ORCPT ); Mon, 24 Aug 2020 19:56:37 -0400 Received: from dread.disaster.area (pa49-181-146-199.pa.nsw.optusnet.com.au [49.181.146.199]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 804798232F2; Tue, 25 Aug 2020 09:56:34 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1kAMKH-0005ho-Pp; Tue, 25 Aug 2020 09:56:33 +1000 Date: Tue, 25 Aug 2020 09:56:33 +1000 From: Dave Chinner To: "Matthew Wilcox (Oracle)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 4/9] iomap: Use bitmap ops to set uptodate bits Message-ID: <20200824235633.GE12131@dread.disaster.area> References: <20200824145511.10500-1-willy@infradead.org> <20200824145511.10500-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200824145511.10500-5-willy@infradead.org> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=QKgWuTDL c=1 sm=1 tr=0 cx=a_idp_d a=GorAHYkI+xOargNMzM6qxQ==:117 a=GorAHYkI+xOargNMzM6qxQ==:17 a=kj9zAlcOel0A:10 a=y4yBn9ojGxQA:10 a=JfrnYn6hAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=eudOcsC1WTTYDsVL2vgA:9 a=CjuIK1q_8ugA:10 a=1CNFftbPRP8L7MoqJWF3:22 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 24, 2020 at 03:55:05PM +0100, Matthew Wilcox (Oracle) wrote: > Now that the bitmap is protected by a spinlock, we can use the > more efficient bitmap ops instead of individual test/set bit ops. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > --- > fs/iomap/buffered-io.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com