Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2533109pxa; Mon, 24 Aug 2020 17:37:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqCHQfAX5tSVaii1kWCP/7D6E5r7Mz+tMYJP3zxbNmQhk8avwot5rdQB1WWcLBxskqeqzJ X-Received: by 2002:a17:906:a3d5:: with SMTP id ca21mr7855276ejb.453.1598315857530; Mon, 24 Aug 2020 17:37:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598315857; cv=none; d=google.com; s=arc-20160816; b=IOqcy/V7RKKM6+s3h246pC+FOBXUwrfrmXNqf9f3FiPNmHBQmOY4BIb85Xu4RZhmcQ siXNhrjEFVnqaffKI/PkLGZU3yNyBT3/OIArsvy4o/XHBUlZw6y5RJoXJrNzoUTem8l3 kN5o4xVerG4VSVM91KcdpQaneOLzg4NoJhTWyDXZFXd/BeDk5NJE4t7b2KEaKBx1VlSR 3u/KoY6iYgA9rtmabNElaTHwbfOv1AD+A1421NlxsqHNKfDxT/ElGXXoWettGcwDy2AL VGRwd+3j65kqX+Xmc330rZZyWCfUk5HidVnqC8mm+RtH7bZHgF+Wt+gSpktUmCfGCl1r zGOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=5sXeua51GG6JVedaTRtYsPWvBA7tTpCucXLjlr/wk8c=; b=T4ZfrebHhT8HiqTYNce+Jk5tpf1mQiTmtn+kZ3QnRQmhse2sHei+7KHMyjwNHHvurR TM5lf5fFlWSplN3YIqxYk2wueRjSzQSQUZ2OT/pVDgkg8Tzfmm3qHuChF6hTgQdApRtV bx3W8Ji6Iql9UvYgVwh3zkw9frClqs7BWqzzlt2iGcav1Mtg0O2HkiBVK3do0VcTEXM0 vsO0IlpKbatqhkhcpPNznMf1Nkr/7R47ttZpze8cGDha+mGj2i3GeXbyvC8BITVdmto2 SBWb5Jf3AxRcjep6t3IQakQhLDAFVuK/3GS/bWgCw7050mna97YQepQqTA6tF58PMyKX VZNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mggVYqUI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y6si5662811edp.363.2020.08.24.17.37.14; Mon, 24 Aug 2020 17:37:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mggVYqUI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728596AbgHYAeD (ORCPT + 99 others); Mon, 24 Aug 2020 20:34:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:44430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728762AbgHYAeA (ORCPT ); Mon, 24 Aug 2020 20:34:00 -0400 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 42D0220767 for ; Tue, 25 Aug 2020 00:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598315639; bh=FZVk5iiXJbmA3My8loC+sCM7p8RHhlYbxo2KYPIse/o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=mggVYqUIgHbDQKb/yVaAMmhrthhgWbYYBwu714YhVe9OQ2/ALMq/Cy86XMLrV9SX/ uHsQgq2f4G38hwoV06S/mM/5jXTexbRiA/MbDFdzed59wrq9ZCjjKcezLf2jFRFip5 yOW67xQag00gSYB+iKbRbVfU9CrDRiNoY6/71ri0= Received: by mail-wm1-f48.google.com with SMTP id g75so580933wme.4 for ; Mon, 24 Aug 2020 17:33:59 -0700 (PDT) X-Gm-Message-State: AOAM532AzlniGmodh4npxFc6hIO4chw5o5AquiPOSYL6b5krQXpbEX3Q /e5pYRuuToLVVn1R91/SpjmWNkce4E8u3GE96P3jhQ== X-Received: by 2002:a1c:ba08:: with SMTP id k8mr1702940wmf.49.1598315637952; Mon, 24 Aug 2020 17:33:57 -0700 (PDT) MIME-Version: 1.0 References: <20200825002645.3658-1-yu-cheng.yu@intel.com> <20200825002645.3658-9-yu-cheng.yu@intel.com> In-Reply-To: <20200825002645.3658-9-yu-cheng.yu@intel.com> From: Andy Lutomirski Date: Mon, 24 Aug 2020 17:33:46 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v11 8/9] x86/vdso: Insert endbr32/endbr64 to vDSO To: Yu-cheng Yu Cc: X86 ML , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , LKML , "open list:DOCUMENTATION" , Linux-MM , linux-arch , Linux API , Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 24, 2020 at 5:30 PM Yu-cheng Yu wrote: > > From: "H.J. Lu" > > When Indirect Branch Tracking (IBT) is enabled, vDSO functions may be > called indirectly, and must have ENDBR32 or ENDBR64 as the first > instruction. The compiler must support -fcf-protection=branch so that it > can be used to compile vDSO. > > Signed-off-by: H.J. Lu > Signed-off-by: Yu-cheng Yu > Acked-by: Andy Lutomirski I revoke my Ack. Please don't repeat the list of object files. Maybe add the option to CFL? --Andy