Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 Aug 2020 09:18:43 +0530
User-Agent: K-9 Mail for Android
In-Reply-To: <20200822232405.GA2261833@BV030612LT>
References: <cover.1598043782.git.cristian.ciocaltea@gmail.com> <20200821222653.GA2255465@BV030612LT> <20200822131343.GA5954@Mani-XPS-13-9360> <20200822232405.GA2261833@BV030612LT>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v2 0/6] Add initial support for ATC260x PMICs
To:     Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
CC:     Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Sebastian Reichel <sre@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>,
        linux-actions@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
        linux-pm@vger.kernel.org
From:   Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Message-ID: <0AD08A2D-9058-4CEF-ACE0-7E8DB1015400@linaro.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 23 August 2020 4:54:05 AM IST, Cristian Ciocaltea <cristian=2Eciocaltea=
@gmail=2Ecom> wrote:
>Hi Mani,
>
>On Sat, Aug 22, 2020 at 06:43:43PM +0530, Manivannan Sadhasivam wrote:
>> Hi Cristi,
>>=20
>> Thanks for the series! I'll take a look soon but there is a quick
>comment
>> below=2E
>>=20
>> On Sat, Aug 22, 2020 at 01:26:53AM +0300, Cristian Ciocaltea wrote:
>> > I have just realized I had omitted the changelog - sorry:
>> >=20
>> > Changes in v2:
>> > - Reworked MFD core & I2C driver
>> >   * Integrated Lee's feedback
>> >   * Added support for using the regmap within atomic contexts
>> >   * Added support for ATC2603C chip variant
>> >   * Reorganized KConfig entries
>> > - Improved regulator driver
>> >   * Added support for ATC2603C variant
>> >   * Used helper macros for more compact specification of
>regulator_desc items
>> >   * Added more regulator capabilities
>> > - Added power controller driver
>> >   * Provides system poweroff/reboot functionalities
>> >   * Requires support for I2C Atomic transfers in the Owl driver
>(already submitted)
>> > - Added onkey driver: exposes the power button as an input device
>> > - Added yaml binding doc
>> > - Rebased patchset on kernel v5=2E9-rc1
>> >=20
>> > Kind regards,
>> > Cristi
>> >=20
>> > On Sat, Aug 22, 2020 at 01:19:46AM +0300, Cristian Ciocaltea wrote:
>> > > This is re-spin of the patch series submitted some time ago by
>Mani,
>> > > who added initial support (MFD core and regulators) for the
>Actions
>> > > Semi ATC260x PMICs:
>> > >
>https://lore=2Ekernel=2Eorg/lkml/20190617155011=2E15376-1-manivannan=2Esa=
dhasivam@linaro=2Eorg/
>> > >=20
>> > > The ATC260x family of PMICs integrates Audio Codec, Power
>management,
>> > > Clock generation and GPIO controller blocks=2E There are currently
>3
>> > > variants: ATC2603A, ATC2603C and ATC2609A=2E
>> > >=20
>> > > In addition to the ATC2609A regulator functionality provided that
>time,
>> > > this patchset adds support for the ATC2603C variant, together
>with some
>> > > new functionalities for both chips: power controller and onkey
>input=2E
>> > > The ATC2603A variant remains unsupported for the moment=2E
>> > >=20
>> > > This has been tested on RoseapplePi, a SBC based on the Action
>Semi S500
>> > > SoC, which integrates ATC2603C PMIC=2E An initial support for this
>board
>> > > has been already submitted:
>> > >
>https://lore=2Ekernel=2Eorg/lkml/cover=2E1592123160=2Egit=2Ecristian=2Eci=
ocaltea@gmail=2Ecom/
>> > >=20
>> > > Please note that enabling the ATC260x PMICs on the compatible
>Actions
>> > > Semi Owl SoC based boards depends on the following:
>> > >=20
>> > > * Actions Semi SIRQ driver (for PMIC DTS setup):
>> > > =20
>https://lore=2Ekernel=2Eorg/lkml/cover=2E1597852360=2Egit=2Ecristian=2Eci=
ocaltea@gmail=2Ecom/
>> > >=20
>> > > * I2C Atomic transfers in Actions Semi Owl driver (for proper
>operation
>> > >   of the power controller driver):
>> > > =20
>https://lore=2Ekernel=2Eorg/lkml/b086ef6d355d9730c839359e15eb06175283e323=
=2E1596485741=2Egit=2Ecristian=2Eciocaltea@gmail=2Ecom/
>> > >  =20
>> > > Thanks,
>> > > Cristi
>> > >=20
>> > > Cristian Ciocaltea (6):
>> > >   dt-bindings: mfd: Add Actions Semi ATC260x PMIC binding
>> > >   mfd: Add MFD driver for ATC260x PMICs
>> > >   regulator: Add regulator driver for ATC260x PMICs
>>=20
>> You need to preserve my authorship for above two patches=2E Adding the
>signed-off-by
>> is not enough=2E
>
>I'm very sorry for the mistake, I was not aware of the correct
>reposting
>procedure=2E Should I resend the series now or could we handle a first
>round
>of review before?
>

You can wait to get review comments=2E=20

Thanks,=20
Mani=20

>Thanks,
>Cristi
>
>> > >   power: reset: Add poweroff driver for ATC260x PMICs
>> > >   input: atc260x: Add onkey driver for ATC260x PMICs
>> > >   MAINTAINERS: Add entry for ATC260x PMIC
>>=20
>> I think this one too=2E
>>=20
>> Thanks,
>> Mani
>>=20
>> > >=20
>> > >  =2E=2E=2E/bindings/mfd/actions,atc260x=2Eyaml         | 221 ++++++=
++
>> > >  MAINTAINERS                                   |  12 +
>> > >  drivers/input/misc/Kconfig                    |  11 +
>> > >  drivers/input/misc/Makefile                   |   2 +-
>> > >  drivers/input/misc/atc260x-onkey=2Ec            | 304 +++++++++++
>> > >  drivers/mfd/Kconfig                           |  18 +
>> > >  drivers/mfd/Makefile                          |   3 +
>> > >  drivers/mfd/atc260x-core=2Ec                    | 290 ++++++++++
>> > >  drivers/mfd/atc260x-i2c=2Ec                     |  73 +++
>> > >  drivers/power/reset/Kconfig                   |   8 +-
>> > >  drivers/power/reset/Makefile                  |   1 +
>> > >  drivers/power/reset/atc260x-poweroff=2Ec        | 274 ++++++++++
>> > >  drivers/regulator/Kconfig                     |   8 +
>> > >  drivers/regulator/Makefile                    |   1 +
>> > >  drivers/regulator/atc260x-regulator=2Ec         | 511
>++++++++++++++++++
>> > >  include/linux/mfd/atc260x/atc2603c=2Eh          | 281 ++++++++++
>> > >  include/linux/mfd/atc260x/atc2609a=2Eh          | 308 +++++++++++
>> > >  include/linux/mfd/atc260x/core=2Eh              |  86 +++
>> > >  18 files changed, 2410 insertions(+), 2 deletions(-)
>> > >  create mode 100644
>Documentation/devicetree/bindings/mfd/actions,atc260x=2Eyaml
>> > >  create mode 100644 drivers/input/misc/atc260x-onkey=2Ec
>> > >  create mode 100644 drivers/mfd/atc260x-core=2Ec
>> > >  create mode 100644 drivers/mfd/atc260x-i2c=2Ec
>> > >  create mode 100644 drivers/power/reset/atc260x-poweroff=2Ec
>> > >  create mode 100644 drivers/regulator/atc260x-regulator=2Ec
>> > >  create mode 100644 include/linux/mfd/atc260x/atc2603c=2Eh
>> > >  create mode 100644 include/linux/mfd/atc260x/atc2609a=2Eh
>> > >  create mode 100644 include/linux/mfd/atc260x/core=2Eh
>> > >=20
>> > > --=20
>> > > 2=2E28=2E0
>> > >=20

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E