Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2635181pxa; Mon, 24 Aug 2020 21:40:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2qoIe6mKdXeC8WMuwA3AgQ2Wvt+yN4gtKXNXAxh+QajQDdOSpf2vbqcZjpGEkoE8U6o/P X-Received: by 2002:aa7:d393:: with SMTP id x19mr8612263edq.283.1598330457923; Mon, 24 Aug 2020 21:40:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598330457; cv=none; d=google.com; s=arc-20160816; b=o1/5ginTmK8ha6+W7DhSJ5E1tI63KG4wZAlTG+jB5z4zmxmU/7BEuqDwYKFE1+eg7q f3yROkMeYERSktQwZEx2AzrPQbAtBdlP4WIUhXVoJwzwo/a8dwVkRNmRoC4YMBkqFUmT I3dEaDk3PPCo6D6oEQJTxyCtHDmHvD3dGFAuMA4q6hf8FsY3oCumJBJYO7ykKXupojha pFLcXLrW07fDvgVfPrmF7qHVlhUdRisGuHH6+ANGlkcSz7Jf7kENTFY9xP7Otw9rH26e QMktNSds+7+dNdqf9G5DxNMquIhIHLL3c+Rn284MeEC6jzhnLkZOwypUeyiPhkxn2qql cGCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LtUHFpNCyHcZnweQyGz62byGxuMAOHTBcm9Rexh1dEI=; b=sUWY7IZORY1kc+j2T6j5J5QVmf4F2qe1K60nNQoMC5ZOcWIgUhE3lnoYfN8/71TX7G FYn2jTlTkOQfDs4lkZsnpbPvJMMde02EuyBcD8ppRIDbl+oWwKWLnlBiG7wylIBoxRxL 1+40rVNKAoUTZlx/lql2x37g8HECtYSenJ36Jqw0SvdREEKO/Zg9Y6buTs9Nwe+figv5 s3ksRGLDbmJAWSKXPXoKZ9+uegTDOUF7ba9XJeHyS5fhiAVjYO4m7mwUosPwkBUhJ05a 4W5OJ1IQ9RN6z0AzFRYeCqlY1v18Kce3eEzMU6112Ex0grQf8FbaqaOMZBQ16+QfvJ5Z QTUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="Tg9Jfq/2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a6si5379174ejv.398.2020.08.24.21.40.35; Mon, 24 Aug 2020 21:40:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="Tg9Jfq/2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728663AbgHYEhC (ORCPT + 99 others); Tue, 25 Aug 2020 00:37:02 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37666 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728603AbgHYEhA (ORCPT ); Tue, 25 Aug 2020 00:37:00 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07P4WBGV109753; Tue, 25 Aug 2020 00:36:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=LtUHFpNCyHcZnweQyGz62byGxuMAOHTBcm9Rexh1dEI=; b=Tg9Jfq/2pwsNbgEPjECYfmuCpEWrdeBV+pifbw/0ls41x0ctF0Y5wzhIdiciyk5JbEPT rfxApVlpCI0H/fdCSe6UxC7zlIEgWRtDs9Ejo1AOWGPlvW1QmmibDK1Rg+WsjNGsLnd4 gpLpOJ7G6p0UdV32K5IoG1GEfWhjfcZXrxUAjJi/ezTn5RzJZfx5xtCgpNHdKl/ohMtp +KvC0LfxwbIfoqkuKCJysMy5rdfc2ryQXezEnbbJhENyz6a51OWQybJF0f1Oa4RkAsLb /6iIiBvdb0VQ3FMN/hwJZrKcF76uwN1zwPFpZC6cOFx8rOvKTu08Uyk1qSQEscxENpGf Hg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 334thmsgmg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Aug 2020 00:36:38 -0400 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 07P4WdUQ111459; Tue, 25 Aug 2020 00:36:38 -0400 Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 334thmsgkr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Aug 2020 00:36:37 -0400 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07P4X44D027926; Tue, 25 Aug 2020 04:36:36 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma04ams.nl.ibm.com with ESMTP id 33498u8xqc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Aug 2020 04:36:35 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07P4Z2kr29688304 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Aug 2020 04:35:02 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C1B3DAE051; Tue, 25 Aug 2020 04:36:32 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 50566AE04D; Tue, 25 Aug 2020 04:36:30 +0000 (GMT) Received: from bangoria.ibmuc.com (unknown [9.199.33.167]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 25 Aug 2020 04:36:30 +0000 (GMT) From: Ravi Bangoria To: mpe@ellerman.id.au, christophe.leroy@c-s.fr Cc: ravi.bangoria@linux.ibm.com, mikey@neuling.org, paulus@samba.org, naveen.n.rao@linux.vnet.ibm.com, pedromfc@linux.ibm.com, rogealve@linux.ibm.com, jniethe5@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 3/8] powerpc/watchpoint/ptrace: Fix SETHWDEBUG when CONFIG_HAVE_HW_BREAKPOINT=N Date: Tue, 25 Aug 2020 10:06:12 +0530 Message-Id: <20200825043617.1073634-4-ravi.bangoria@linux.ibm.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200825043617.1073634-1-ravi.bangoria@linux.ibm.com> References: <20200825043617.1073634-1-ravi.bangoria@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-24_12:2020-08-24,2020-08-24 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 spamscore=0 mlxlogscore=999 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008250030 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When kernel is compiled with CONFIG_HAVE_HW_BREAKPOINT=N, user can still create watchpoint using PPC_PTRACE_SETHWDEBUG, with limited functionalities. But, such watchpoints are never firing because of the missing privilege settings. Fix that. It's safe to set HW_BRK_TYPE_PRIV_ALL because we don't really leak any kernel address in signal info. Setting HW_BRK_TYPE_PRIV_ALL will also help to find scenarios when kernel corrupts user memory. Reported-by: Pedro Miraglia Franco de Carvalho Suggested-by: Pedro Miraglia Franco de Carvalho Signed-off-by: Ravi Bangoria --- arch/powerpc/kernel/ptrace/ptrace-noadv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/ptrace/ptrace-noadv.c b/arch/powerpc/kernel/ptrace/ptrace-noadv.c index 697c7e4b5877..57a0ab822334 100644 --- a/arch/powerpc/kernel/ptrace/ptrace-noadv.c +++ b/arch/powerpc/kernel/ptrace/ptrace-noadv.c @@ -217,7 +217,7 @@ long ppc_set_hwdebug(struct task_struct *child, struct ppc_hw_breakpoint *bp_inf return -EIO; brk.address = ALIGN_DOWN(bp_info->addr, HW_BREAKPOINT_SIZE); - brk.type = HW_BRK_TYPE_TRANSLATE; + brk.type = HW_BRK_TYPE_TRANSLATE | HW_BRK_TYPE_PRIV_ALL; brk.len = DABR_MAX_LEN; if (bp_info->trigger_type & PPC_BREAKPOINT_TRIGGER_READ) brk.type |= HW_BRK_TYPE_READ; -- 2.26.2