Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2643402pxa; Mon, 24 Aug 2020 22:02:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxP3CEcUtGWO4CiYDxMI+Lp4W2h0YtgxNoLjasJDC5DdFgINt2seL55J1x+sSE/NQpw/cN X-Received: by 2002:a50:f386:: with SMTP id g6mr8829431edm.354.1598331728387; Mon, 24 Aug 2020 22:02:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598331728; cv=none; d=google.com; s=arc-20160816; b=kWo4xhq1TfhHs+7FBs4tYOwftRvGldOrLVR2IZeaK92RZGuReTSwQvL47zOgB2PGRg LWX/dnXOho1Kk0pSgXw39hH8MR7mxHDo82qgVa3ph4bbtXcHus/Ile6CuKfKK/CVCEBa X24XjapCq2OvG0ak+fnMoVbCZdpFA0rWS5CKa1zZVevFufA5+SLJWgdcpiBudAipU/l3 ec7eBPmBB5Dw3XZvWEKX1mR0U7Q6SL1mkUh7xOgmOL7Ta4G2II3zwuTsqMcehwYqGJY5 ikJS80QszW1uA/NOcFChZML2YBYPEW9Fp8g/CXgZJqGVStqijKMekEhVW0JLHqEQrmOK mRcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mGpMl3ugLgn+9I6Ohi4ZL/JrXtFqLNEECynrQZWX6Sw=; b=P4pZPdWP4YWQbbY1Ica3QWJyScgV+jr6JX2UNvMYtc/bpedM90wZd9A9Bl2SBXcaeE anoQooukaTV4bmIHBJWKmf8j1wIi6KJdGxVpXqyU+OhiZzVtquAXXeQD92vCpOuiFGlR NrWSno60ydWAdH3nHF8mJV1mhVBw+QvpIPnoUlS7vBoBC70p/r20NQaa66u2uwDHSOc+ AE+9dfLrzPGGaZLtK3hFvJUFRla1+iz5rb/zOc/QYFKQIq/cImR81FFg0iiJEeY6U+xT bvPE1xdIqf8J6E8/UzBz22R/62EiWsfEq0NAG+atnd17d+U39KDGE6nZ1TxGEU4HPiP+ ihDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 26si3408561edv.92.2020.08.24.22.01.45; Mon, 24 Aug 2020 22:02:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728567AbgHYE4u (ORCPT + 99 others); Tue, 25 Aug 2020 00:56:50 -0400 Received: from smtprelay0065.hostedemail.com ([216.40.44.65]:38442 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728089AbgHYE4r (ORCPT ); Tue, 25 Aug 2020 00:56:47 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 5B1DE182CED2A; Tue, 25 Aug 2020 04:56:46 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1311:1314:1345:1359:1437:1515:1534:1542:1711:1730:1747:1777:1792:2393:2559:2562:2898:3138:3139:3140:3141:3142:3352:3865:3866:3868:3872:4321:4605:5007:6119:6261:10004:10848:11026:11658:11914:12043:12297:12438:12555:12895:12986:13870:13894:13972:14181:14394:14721:21080:21627:30054:30070,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: cover96_0806a5227059 X-Filterd-Recvd-Size: 3208 Received: from joe-laptop.perches.com (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Tue, 25 Aug 2020 04:56:44 +0000 (UTC) From: Joe Perches To: Jiri Kosina , Robert Richter Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, oprofile-list@lists.sf.net Subject: [PATCH 02/29] alpha: Avoid comma separated statements Date: Mon, 24 Aug 2020 21:55:59 -0700 Message-Id: <4facd57f80c70437f085ba3a1bcf13ae0b63c3bc.1598331148.git.joe@perches.com> X-Mailer: git-send-email 2.26.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use semicolons and braces. Signed-off-by: Joe Perches --- arch/alpha/kernel/pci_iommu.c | 8 +++++--- arch/alpha/oprofile/op_model_ev4.c | 22 ++++++++++++++-------- arch/alpha/oprofile/op_model_ev5.c | 8 +++++--- 3 files changed, 24 insertions(+), 14 deletions(-) diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c index 81037907268d..b8af7ad6c607 100644 --- a/arch/alpha/kernel/pci_iommu.c +++ b/arch/alpha/kernel/pci_iommu.c @@ -161,10 +161,12 @@ iommu_arena_find_pages(struct device *dev, struct pci_iommu_arena *arena, goto again; } - if (ptes[p+i]) - p = ALIGN(p + i + 1, mask + 1), i = 0; - else + if (ptes[p+i]) { + p = ALIGN(p + i + 1, mask + 1); + i = 0; + } else { i = i + 1; + } } if (i < n) { diff --git a/arch/alpha/oprofile/op_model_ev4.c b/arch/alpha/oprofile/op_model_ev4.c index 086a0d5445c5..004f80a4291f 100644 --- a/arch/alpha/oprofile/op_model_ev4.c +++ b/arch/alpha/oprofile/op_model_ev4.c @@ -46,18 +46,24 @@ ev4_reg_setup(struct op_register_config *reg, map it onto one of the possible values, and write it back. */ count = ctr[0].count; - if (count <= 4096) - count = 4096, hilo = 1; - else - count = 65536, hilo = 0; + if (count <= 4096) { + count = 4096; + hilo = 1; + } else { + count = 65536; + hilo = 0; + } ctr[0].count = count; ctl |= (ctr[0].enabled && hilo) << 3; count = ctr[1].count; - if (count <= 256) - count = 256, hilo = 1; - else - count = 4096, hilo = 0; + if (count <= 256) { + count = 256; + hilo = 1; + } else { + count = 4096; + hilo = 0; + } ctr[1].count = count; ctl |= (ctr[1].enabled && hilo); diff --git a/arch/alpha/oprofile/op_model_ev5.c b/arch/alpha/oprofile/op_model_ev5.c index c300f5ef3482..6f52244e1181 100644 --- a/arch/alpha/oprofile/op_model_ev5.c +++ b/arch/alpha/oprofile/op_model_ev5.c @@ -92,9 +92,11 @@ common_reg_setup(struct op_register_config *reg, if (!ctr[i].enabled) continue; - if (count <= 256) - count = 256, hilo = 3, max = 256; - else { + if (count <= 256) { + max = 256; + hilo = 3; + count = 256; + } else { max = (i == 2 ? 16384 : 65536); hilo = 2; if (count > max) -- 2.26.0